From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DAE53A00C2; Thu, 6 Oct 2022 17:26:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C0D7C42B78; Thu, 6 Oct 2022 17:26:25 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id CC1C441153 for <dev@dpdk.org>; Thu, 6 Oct 2022 17:26:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665069984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=meMyuUUv5TOkj13kzuTAauMKRK3288c9uiM6IwTYVC4=; b=cyg47JmQhGMZ4Dj9tG5NFwoaxxKugr/+RfvPGz+jZptwYpwv9OAgvrT9rZZD8zqYiQqJaR hx2ETFMxXK1zBIyt4MbcDDA1hKiNfiC/osODNbRKds0p+Z4ERLIsqsakGwZTDPRNX2xrsy 0QvhzXcvB3gdiph3AXawyeWy3yIpDgE= Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-652-5UB7VEbkMwCW4lyEc-Yr9A-1; Thu, 06 Oct 2022 11:26:23 -0400 X-MC-Unique: 5UB7VEbkMwCW4lyEc-Yr9A-1 Received: by mail-pg1-f199.google.com with SMTP id s68-20020a632c47000000b00434e0e75076so1328126pgs.7 for <dev@dpdk.org>; Thu, 06 Oct 2022 08:26:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=meMyuUUv5TOkj13kzuTAauMKRK3288c9uiM6IwTYVC4=; b=WwlWv2zZq1nf4BgLOlAmcacjDhphcHGHp9bQaR91n51VKj+2kquSQMYnX3A5Pw0qDj Kx54IC9VAul/lJzeaCWhgFHTBs8snct6q8NOIZnYW2dv9LyVdmFBsMa54tpMnFwM1A5o LmJaPkm4BQU/dw3ue122ZaSJtBQfwcxclY7hx/+DhnWMJfZW7hYqKaC7JjyBrKrNjJPo U3JllJ7NZeIqTCOQ4Mam+vouwmnXKpTwCOTYFqYDbhiJcTMld2q14CRQe+83NabZ3ACs VKte2qDcpqTqO5mWJNgiVcZCQtQSzIDgPWhhkAnmWL+fYENqwCvVizqBH2tBMW3o4JVy 2Oyg== X-Gm-Message-State: ACrzQf3nm3+c9mYOysrxa8MEScRgu0FI/yMCy8mQRCgqL/RTNkGLrg2T aRv/+xGDxbx/ePkYMU2yhsst3qSiy4wD1ZUt3RxywwPvMTz1jLvBZ0F/ivdYBXvos9zTuMsOqq+ cWlY3t7DPNGzz3fhdASs= X-Received: by 2002:a63:5b58:0:b0:452:2ba4:f86b with SMTP id l24-20020a635b58000000b004522ba4f86bmr335315pgm.223.1665069982093; Thu, 06 Oct 2022 08:26:22 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7x93/1xHFE9ptzaNGOo3eBagyvktc5o9N+V1rLCM5PJ8/BRVaaBd8Gplac2LIBS3r6eWxHIdBtmQSW5LbZJ9E= X-Received: by 2002:a63:5b58:0:b0:452:2ba4:f86b with SMTP id l24-20020a635b58000000b004522ba4f86bmr335292pgm.223.1665069981752; Thu, 06 Oct 2022 08:26:21 -0700 (PDT) MIME-Version: 1.0 References: <1654783134-13303-1-git-send-email-roretzla@linux.microsoft.com> <2082798.OBFZWjSADL@thomas> <20221006151020.GA2395@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <2599081.BddDVKsqQX@thomas> <20221006152052.GD2395@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20221006152052.GD2395@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: David Marchand <david.marchand@redhat.com> Date: Thu, 6 Oct 2022 17:26:10 +0200 Message-ID: <CAJFAV8wOJYN_gSkRSchugg1bt=EOTgoV+Ky_kG75b_0n42yHsw@mail.gmail.com> Subject: Re: [PATCH v4 0/6] add thread lifetime and attributes API To: Tyler Retzlaff <roretzla@linux.microsoft.com> Cc: Thomas Monjalon <thomas@monjalon.net>, dmitry.kozliuk@gmail.com, dev@dpdk.org, anatoly.burakov@intel.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Thu, Oct 6, 2022 at 5:20 PM Tyler Retzlaff <roretzla@linux.microsoft.com> wrote: > > On Thu, Oct 06, 2022 at 05:14:55PM +0200, Thomas Monjalon wrote: > > 06/10/2022 17:10, Tyler Retzlaff: > > > On Thu, Oct 06, 2022 at 03:36:12PM +0200, Thomas Monjalon wrote: > > > > 05/10/2022 18:34, Tyler Retzlaff: > > > > > On Wed, Oct 05, 2022 at 09:11:26AM -0700, Tyler Retzlaff wrote: > > > > > > > Newly added code can go to eal_common_thread.c rather than introduce a > > > > > > > new common/rte_thread.c file (or is there a rationale for this?). > > > > > > > > > > > > i will make this change in the next revision. if anyone does object i > > > > > > hope they will do so quickly. > > > > > > > > > > looking at this more closely i'm going to back away from making the > > > > > adjustment here. if Thomas and/or Dmitry could comment it would be > > > > > appreciated. > > > > > > > > > > it appears that functions placed in eal_common_xxx files are consumed > > > > > internally by the eal where rte_xxx files are functions that are exposed > > > > > through public api. > > > > > > > > It is not so clear. > > > > There is already eal_common_thread.c which implements the same kind of functions, > > > > so I think you should move your new functions here. > > > > > > > > > since these additions are public api it seems they should remain in > > > > > rte_thread.c > > > > > > > > Let's not have 2 .c files for the same purpose in the same directory. > > > > > > just as another point there seem to be several other rte_xxx.c files > > > here can we clarify why they were not subject to the same requirement? > > > as a follow on does it mean that the code in those files should also be > > > moved to eal_common_xxx files? > > > > That's just history. > > > > > please let me know if the justification is not the same i'll move the > > > functions to the eal_common file as requested. i just want to make sure > > > it is being done for the consistent/correct reason. > > > > Some file names are not correct, we could rename them. > > > > I think David is already doing the last minor changes on this series > > while merging, so no need to do anything on your side. > > > > Thomas, David with this just a final confirmation no need for a v6? > you're tweaking the series as is for final comments? No need for a v6, the code move is trivial, and for the rest, I'm finished. I'll restart the per patch build all over again to be sure, and then merge the series probably tonight (CET+2). -- David Marchand