From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D9840A0542; Wed, 5 Oct 2022 15:39:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A636440694; Wed, 5 Oct 2022 15:39:25 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4D51B40143 for ; Wed, 5 Oct 2022 15:39:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664977162; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S0RtHRfvTAOCGeKVoDZ23wr9xHUAe/pCiIl9rOeExYg=; b=JsG/+7FC+b/tjythPBM5OhV0b9CTiT3LqabBo71MvlCXl01gi9wjADo1J7nef02a5Ahw26 2W/njfZ8LbgRHyAGokDUFp7BQnVFB+5idYwfCbttsOEqlvFGpOfCGzy3/Q01Eig5KhmXTq wNOxtwr/l9TLwvNrKHeiuhbYusrSLGE= Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-479-IW4NhaiQNsuJVCIhAd5ILA-1; Wed, 05 Oct 2022 09:39:18 -0400 X-MC-Unique: IW4NhaiQNsuJVCIhAd5ILA-1 Received: by mail-pg1-f198.google.com with SMTP id f186-20020a636ac3000000b0044adaa7d347so6480430pgc.14 for ; Wed, 05 Oct 2022 06:39:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=S0RtHRfvTAOCGeKVoDZ23wr9xHUAe/pCiIl9rOeExYg=; b=MfHkb32M5kR0fXSfbuXWYbmExq+Qxv55GOsfDbaqAoJhBVGoWV8dvr9AtDJtttuNvU cNKJqPrzmbmAbflviIT9mAuLTKhsrfajWnS2NU4RkMciUa4rMmAaXpZAKmYfPusllvZs PMsEDYVGMhB7riyJGtwkf9izW6ONOPVi3dTC4NGEbLSbQtdb9Bb51/PADs0SYpwS1v6J 7TDH42Qahn/HYcownesM9vIO3F/IMjBWWCUCyzvO7iMH6xM678zCyOyneZWszC6vtAdL LR3kQxTvkusHr17NhCYSSq3baivk4Hk5/RZxQkwjP6pkPVnbz59ZC5UXQZlcqjyrB0dx 1wJQ== X-Gm-Message-State: ACrzQf2yoo8A6QyY/dUprcnI1oti5REVSI8ps35j4ruj+OURf4NN1VXU jf6tpWdwdnCgg7mnOHKPfnKRUrMBJgLP4Ve/Wzaj33sZSLIntp3ld8IGUQEcLkyFTCZZ3vUgfh4 uW2VjTRIq92Uxiu3Rl9Q= X-Received: by 2002:a63:2a97:0:b0:457:23e9:586d with SMTP id q145-20020a632a97000000b0045723e9586dmr5140797pgq.190.1664977156944; Wed, 05 Oct 2022 06:39:16 -0700 (PDT) X-Google-Smtp-Source: AMsMyM42QvRVUSI0SSgRAL50AQScSXlS86N4F2eED3irly4rFZCUFgwdZoLnFUhhBIUgggSv9B0L/+atmbne7ZKq+DU= X-Received: by 2002:a63:2a97:0:b0:457:23e9:586d with SMTP id q145-20020a632a97000000b0045723e9586dmr5140780pgq.190.1664977156642; Wed, 05 Oct 2022 06:39:16 -0700 (PDT) MIME-Version: 1.0 References: <20220906161352.296110-1-mattias.ronnblom@ericsson.com> <20221005091615.94652-1-mattias.ronnblom@ericsson.com> In-Reply-To: <20221005091615.94652-1-mattias.ronnblom@ericsson.com> From: David Marchand Date: Wed, 5 Oct 2022 15:39:04 +0200 Message-ID: Subject: Re: [PATCH v2 0/6] Service cores performance and statistics improvements To: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= Cc: Harry , dev@dpdk.org, Honnappa Nagarahalli , =?UTF-8?Q?Morten_Br=C3=B8rup?= , nd , hofors@lysator.liu.se X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 5, 2022 at 11:20 AM Mattias R=C3=B6nnblom wrote: > > This series contains performance improvements and new statistics- > related functionality for the EAL service cores framework. > > A new per-lcore TSC cycle counter is introduced, which reflect the > total amount of cycles spent by that lcore running services. This may > be used to estimate service lcore load. > > The patchset introduces a backward-compatible convention, where a DPDK > service may signal to the framework that no useful work was performed, > which in turn is used to make the busy cycles statistics more > accurate. > > Depends-on: series-23959 ("test/service: add perf measurements for with s= tats mode ") > > Mattias R=C3=B6nnblom (6): > service: reduce statistics overhead for parallel services > service: introduce per-lcore cycles counter > service: reduce average case service core overhead > service: tweak cycle statistics semantics > event/sw: report idle when no work is performed > service: provide links to functions in documentation > > app/test/test_service_cores.c | 2 +- > drivers/event/sw/sw_evdev.c | 3 +- > drivers/event/sw/sw_evdev.h | 2 +- > drivers/event/sw/sw_evdev_scheduler.c | 6 +- > lib/eal/common/rte_service.c | 228 +++++++++++++++++------- > lib/eal/include/rte_service.h | 32 ++-- > lib/eal/include/rte_service_component.h | 5 + > 7 files changed, 192 insertions(+), 86 deletions(-) Added acks. Series applied, thanks. --=20 David Marchand