From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E80E42D06; Tue, 20 Jun 2023 10:38:48 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 712E44068E; Tue, 20 Jun 2023 10:38:48 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 1CB3C400D6 for <dev@dpdk.org>; Tue, 20 Jun 2023 10:38:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687250326; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xvt7eTKQPwpgIoRLILMASInBcfoMMJMKZffyLVW+PoU=; b=cSresbh56eIIEJBxtpoFnybbg/4QrXkuTAi3eh7AE0wWURIXP87LyMgrOC4IUjrkT2otwk 5U1J0HtQr2hOjJcrvg5qT8MPDwEJKrUK1p68baCzBwuHfKA18Nd2EMHadb8NWqgxn+0HIm 7FewC0eEjesN+N5hxgGENU609sqtCMw= Received: from mail-oi1-f199.google.com (mail-oi1-f199.google.com [209.85.167.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-204-HsaTJjjqMw2m9KUoccUs1Q-1; Tue, 20 Jun 2023 04:38:45 -0400 X-MC-Unique: HsaTJjjqMw2m9KUoccUs1Q-1 Received: by mail-oi1-f199.google.com with SMTP id 5614622812f47-39e9c7227d9so3539202b6e.1 for <dev@dpdk.org>; Tue, 20 Jun 2023 01:38:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687250324; x=1689842324; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Xvt7eTKQPwpgIoRLILMASInBcfoMMJMKZffyLVW+PoU=; b=SK6Y8JxwSPn5LESXoakegil8uxt0UK31bMNzL8CfYdGOxU0vF1cIzqMueUJ6bROIhl NzDJ4VFQPZLpJrxEXqSAqAPxFrxqYeduuSCWMstbxTXif0s3hK0TilgdMK9cgXylgz6z Xr3ijVT2klB6MMKIK0ezMBOgIW9QTD130xkmRCjjum86e3G1cKP5NJRDfWzemcb8PWNu K56Np0/DEj2IuvgZmsd6Xzo4AM6+SuEQVhzicwdXZTxx7ytYIDpK3JH1hnngJHp+Gd0P f13q5jr4CelzhCqPBwhSB5WOHaIJt37M0jjCMY8QQvUCPkkbiyr1qVchGoMF5o14EAU8 o18g== X-Gm-Message-State: AC+VfDw5pbyT4UXwacZWTkWQqidRiibjl6bRk426sDmjb7luMbwHPL/V 3LruyyRDhpoBYFXBEyAcjDbiYDb5Ud2JzOOou5XveX90h0PjtzsD4scRS1yGU1i+fGQImJKXWCA IGx9IlOtnOXnxHOuNzt8= X-Received: by 2002:a05:6808:1a8d:b0:39e:ff3d:af9d with SMTP id bm13-20020a0568081a8d00b0039eff3daf9dmr3313819oib.46.1687250324739; Tue, 20 Jun 2023 01:38:44 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7l41ja8O6b17ohTyMHwFHZkd7Qw6jgLVMVRvh0NRlECjMHuRRn7Kx0CM9cvx3mZ6sUoVaBeTwjkLePwggiQDs= X-Received: by 2002:a05:6808:1a8d:b0:39e:ff3d:af9d with SMTP id bm13-20020a0568081a8d00b0039eff3daf9dmr3313810oib.46.1687250324559; Tue, 20 Jun 2023 01:38:44 -0700 (PDT) MIME-Version: 1.0 References: <20211117112847.7362-6-david.marchand@redhat.com> <20230616071450.3542479-1-david.marchand@redhat.com> <CAJFAV8y3ejgVUydSvYDM9tPU-zJz+gFJcD3QPHn7V-5nVP5oNA@mail.gmail.com> <ZJBlkqojcvpEwMjJ@bricha3-MOBL.ger.corp.intel.com> <CAJFAV8w8dcH09mQjXuDWHjUPOi-1fbgxyJSxZNasE0tr8G-bWw@mail.gmail.com> <ZJFk3N9ooG5ZVRnS@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <ZJFk3N9ooG5ZVRnS@bricha3-MOBL.ger.corp.intel.com> From: David Marchand <david.marchand@redhat.com> Date: Tue, 20 Jun 2023 10:38:33 +0200 Message-ID: <CAJFAV8wOXM3nyQJ4csn3h4EUjNkJ5HMOwpEdioP7d4tAd=RKuw@mail.gmail.com> Subject: Re: [PATCH v3] build: select optional libraries To: Bruce Richardson <bruce.richardson@intel.com>, thomas@monjalon.net Cc: dev@dpdk.org, bluca@debian.org, tredaelli@redhat.com, i.maximets@ovn.org, james.r.harris@intel.com, mohammed@hawari.fr, Aaron Conole <aconole@redhat.com>, Michael Santana <maicolgabriel@hotmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Tue, Jun 20, 2023 at 10:36=E2=80=AFAM Bruce Richardson <bruce.richardson@intel.com> wrote: > On Tue, Jun 20, 2023 at 10:31:19AM +0200, David Marchand wrote: > > On Mon, Jun 19, 2023 at 4:26=E2=80=AFPM Bruce Richardson > > <bruce.richardson@intel.com> wrote: > > > > > > On Mon, Jun 19, 2023 at 04:11:37PM +0200, David Marchand wrote: > > > > On Fri, Jun 16, 2023 at 9:21=E2=80=AFAM David Marchand > > > > <david.marchand@redhat.com> wrote: > > > > > @@ -141,13 +137,25 @@ foreach l:libraries > > > > > deps +=3D ['eal'] > > > > > endif > > > > > > > > > > - if disabled_libs.contains(l) > > > > > + if not enable_libs.contains(l) > > > > > + build =3D false > > > > > + reason =3D 'not in enabled libraries build config' > > > > > + elif disable_libs.contains(l) > > > > > build =3D false > > > > > reason =3D 'explicitly disabled via build config' > > > > > - if dpdk_libs_deprecated.contains(l) > > > > > + endif > > > > > > > > There is also a change in behavior for current users of the > > > > -Ddisable_libs=3D configuration (which was used for enabling deprec= ated > > > > libraries, for example). > > > > > > I notice the change in behaviour for enabling the deprecated libs. Is= there > > > any other change in behaviour for current users? > > > > The only change I see, is that this implementation breaks enabling > > deprecated libs via disable_libs. > > It may break existing developer build directory and maybe some > > packaging scripts, this is why I am a bit puzzled. > > > > Relooking at the disable_libs option current implementation, it seems > > backward to pass a disable_libs option when you want to build some > > deprecated library. > > It is more straightforward to request building libraries via > > -Denable_libs=3D<deprecated_lib> explicitly or -Denable_libs=3D* > > implicitly. > > > > But again, we may be breaking something for people who relied on this b= ehavior. > > > > That's what I expected, and I think that is ok. I just wanted to check th= at > the change in behaviour was only for the deprecated libs case. Thomas, wdyt? It requires some release note, at least. --=20 David Marchand