From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7BE6A034F; Fri, 12 Nov 2021 17:27:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 78C47410E3; Fri, 12 Nov 2021 17:27:51 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 9B63740692 for ; Fri, 12 Nov 2021 17:27:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636734470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5XrLX7U9aQAHdV6YM8yPNB6xYQvowHwJd5y0+9YwwmY=; b=HRruvMRoGN8AvoVIwU7kH6LuA7GKE8qxgf+da2pof0ldI+6dGbxdyjxgcPGirkcXg99Hf3 Y2mhvCqtsN3bqRVmSN/3uSic58TlKt0WgsrIsB08SyKb/vJneVDCuqA8eynXMXdTYgMTVq 86vTgAm5e06p+5VvGxlLi9hZq8dacHY= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-529-F0bMn9HqMGiXG6Ow_5lZYw-1; Fri, 12 Nov 2021 11:27:49 -0500 X-MC-Unique: F0bMn9HqMGiXG6Ow_5lZYw-1 Received: by mail-lf1-f72.google.com with SMTP id b23-20020a0565120b9700b00403a044bfcdso3012877lfv.13 for ; Fri, 12 Nov 2021 08:27:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5XrLX7U9aQAHdV6YM8yPNB6xYQvowHwJd5y0+9YwwmY=; b=CZTpmSjjb2TWEwOMw+Q2j+oIH92074GewHlpttdRKTBBL2svB31pYC5TzsKUzHP0Cc Qr6MtHRXtibhOzGjeHctNyiRKWsixMqjpae8QPgihpXuKOcmJBy/8hVO1nfyJVM9AYo5 2kuZSpeEkMm/6xdZH2kHjwU3gYUHhUZ1bG+ggzDvyVprINheh4EBgMijhpsMCaB1cQ3F 8D4G2X8LFqqxRGvjmyDgn7szpjr5ZPF0OmNzqQD8F4pGu195sqkzugO0Rd+7W1kEGQVI MBABK3BQnUP+Dxg+0Fu8mFGw7kx8yMzfETH3C/lLDXyOZK9ekjkkYRcHWnJw61h5fpqF /yZg== X-Gm-Message-State: AOAM532smefVijIr21tPcI88663eiAxC7W1L9UpiXB2hhPDNZIkDa1Lr YhYxE87wigoc01rNnPg1UgxnZnucc+BSpD8OKjlQRGtUO96KgXuU/Nqe8rdAUTCo58WZ33ktD/c FgIaxWbVNPi9VvKEmeHQ= X-Received: by 2002:a05:6512:3e11:: with SMTP id i17mr14420354lfv.560.1636734467471; Fri, 12 Nov 2021 08:27:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJwHakI+M5WsPHUzSFMWYpQ+Sl+2oQPV2ttcwo3CU7MB3dSrncHeCPWu5uwRQgYT/sABBFVAjKoqdT4eF16M4+4= X-Received: by 2002:a05:6512:3e11:: with SMTP id i17mr14420288lfv.560.1636734467206; Fri, 12 Nov 2021 08:27:47 -0800 (PST) MIME-Version: 1.0 References: <20211112140111.922171-1-conor.walsh@intel.com> <20211112140111.922171-6-conor.walsh@intel.com> In-Reply-To: From: David Marchand Date: Fri, 12 Nov 2021 17:27:36 +0100 Message-ID: Subject: Re: [PATCH 5/7] drivers/net: fix unused but set variables To: Ferruh Yigit Cc: Conor Walsh , "Liang, LongfengX" , dev , David Hunt , "Wang, Yipeng1" , "Gobriel, Sameh" , Bruce Richardson , Vladimir Medvedkin , Hemant Agrawal , Sachin Saxena , "Trahe, Fiona" , John Griffin , Deepak Kumar Jain , Van Haaren Harry , Ajit Khaparde , Somnath Kotur , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Shijith Thotton , Srisivasubramanian Srinivasan , heinrich.kuhn@corigine.com, Harman Kalra , Rasesh Mody , Devendra Singh Rawat , Jiawen Wu , Yong Wang , "Mcnamara, John" , Shreyansh Jain , santosh.shukla@caviumnetworks.com, Akhil Goyal , Fan Zhang , "Kusztal, ArkadiuszX" , michael.baucom@broadcom.com, Venkat Duvvuru , Lance Richardson , kishore.padmanabha@broadcom.com, Jerin Jacob , derek.chickles@caviumnetworks.com, ssrinivasan@caviumnetworks.com, mjatharakonda@oneconvergence.com, simon.horman@corigine.com, david.george@sophos.com, sony.chacko@qlogic.com, harish.patil@qlogic.com, Stephen Hemminger , Tomasz Kulasek , ian.betts@intel.com, Liang Ma , lei.a.yao@intel.com Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Nov 12, 2021 at 5:18 PM Ferruh Yigit wrote: > > On 11/12/2021 2:01 PM, Conor Walsh wrote: > > static void > > vmxnet3_tq_tx_complete(vmxnet3_tx_queue_t *txq) > > { > > + #ifdef RTE_LIBRTE_VMXNET3_DEBUG_TX > > int completed = 0; > > + #endif > > vmxnet3_comp_ring_t *comp_ring = &txq->comp_ring; > > struct Vmxnet3_TxCompDesc *tcd = (struct Vmxnet3_TxCompDesc *) > > (comp_ring->base + comp_ring->next2proc); > > > > while (tcd->gen == comp_ring->gen) { > > + #ifdef RTE_LIBRTE_VMXNET3_DEBUG_TX > > completed += vmxnet3_unmap_pkt(tcd->txdIdx, txq); > > + #endif And this vmxnet_unmap_pkt does useful work. We should probably still call it regardless of debug logs. > > > > vmxnet3_comp_ring_adv_next2proc(comp_ring); > > tcd = (struct Vmxnet3_TxCompDesc *)(comp_ring->base + > > comp_ring->next2proc); > > } > > > > + #ifdef RTE_LIBRTE_VMXNET3_DEBUG_TX > > PMD_TX_LOG(DEBUG, "Processed %d tx comps & command descs.", completed); > > + #endif > > } > > 'PMD_TX_LOG' doesn't require 'RTE_LIBRTE_VMXNET3_DEBUG_TX' wrap. > -- David Marchand