From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 406A241BBD; Fri, 3 Feb 2023 10:22:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1C3D34021E; Fri, 3 Feb 2023 10:22:11 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id CD6614014F for <dev@dpdk.org>; Fri, 3 Feb 2023 10:22:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675416128; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JeiqpBSy1RDYW+bWLgl9f/aMo/uqIYHIASnMlXO6EVk=; b=Wdrzj0X/jsamdkC7AnxMjIRrWM81dwJnI5aZbh+x6f06tXhiXPFJqFiFAfUeWaCMVQXVP2 Y51g5pavErrDJ4naQPlr3fSdF1zEQIfwjT70M3uw1FsqRt3ET1Ck/Oaw5/LhJ94sZR020u mPNdI0M3Wvlt7efXyuTOb/Zlky/bD2I= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-637-9iBxBQbYNzGY74hx3bjAlg-1; Fri, 03 Feb 2023 04:22:05 -0500 X-MC-Unique: 9iBxBQbYNzGY74hx3bjAlg-1 Received: by mail-pj1-f70.google.com with SMTP id l17-20020a17090a409100b0022c0ba4b754so4316394pjg.3 for <dev@dpdk.org>; Fri, 03 Feb 2023 01:22:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JeiqpBSy1RDYW+bWLgl9f/aMo/uqIYHIASnMlXO6EVk=; b=wG0SxVl8CXHkynTG09e6LIOMlDbO1KjnNgmjTpBn31pVgU2NjtihPNn6KQj+TSHhtW hxIBzfFKdnN1oBqvkGgKMXTOIUHQtJaIZqZ2ZOXtr4naTh9zUHSFBu74zQTJ0Hx3u9TU diGaS9+BH2P8YwxWbvfziHOG4EJneHWpmh3p1SEwQUwI9nYdUV0UFuz7/wa4CCKbEyKj fk8X1HTzwE5xapQkvOOLiqwfesQJs+21AJxzmS+EDKvrJwk3Z7ibuIxtAyZ9jj/KgIa3 mGrCvD7HPeQ0R1JQc3OZjo8XtrbE+YKC/CjUEatU2YPwq8lnLjbkOEDxLcrmiMHmDt73 8GYg== X-Gm-Message-State: AO0yUKUbHTJOPGxVX3JDiyDPvZ6Sb49syDjh/Wo6TZVhxiNmXuyFW9cI Uojxxcoj6km4aYkwgcTbAoclRShgY88odSpYEDkPKRCOHQFcOF6vm4od5qlNy+ReRZ1qMx3z+P6 QHcqq4RpeMEK76G8JeZ4= X-Received: by 2002:a17:90a:4a16:b0:22c:39eb:3723 with SMTP id e22-20020a17090a4a1600b0022c39eb3723mr1080561pjh.116.1675416124232; Fri, 03 Feb 2023 01:22:04 -0800 (PST) X-Google-Smtp-Source: AK7set+8kGaj1+fVpaSpBvX4NNJ3CAVdPs3DYY9EYxzDBmBFqYiOr+LjwXGb6K7CasCJTdC0pt9/yBaWyFb9BjQhjHA= X-Received: by 2002:a17:90a:4a16:b0:22c:39eb:3723 with SMTP id e22-20020a17090a4a1600b0022c39eb3723mr1080558pjh.116.1675416123920; Fri, 03 Feb 2023 01:22:03 -0800 (PST) MIME-Version: 1.0 References: <1669241687-18810-1-git-send-email-roretzla@linux.microsoft.com> <1673380001-16558-1-git-send-email-roretzla@linux.microsoft.com> <20230120221418.GA9231@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <CAJFAV8xRFfuCH7dGy=3KW50n-x2xidpfr0uDqM0j1im7-y6DFg@mail.gmail.com> <20230202155640.GA20115@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20230202155640.GA20115@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: David Marchand <david.marchand@redhat.com> Date: Fri, 3 Feb 2023 10:21:52 +0100 Message-ID: <CAJFAV8wPH6ppjA1XaQKCgeYCFGJ+sDCN1LOKO8hV51-Eh_fzcw@mail.gmail.com> Subject: Re: [PATCH v6 0/2] eal: provide leading and trailing zero bit count abstraction To: Tyler Retzlaff <roretzla@linux.microsoft.com> Cc: dev@dpdk.org, thomas@monjalon.net, mb@smartsharesystems.com, bruce.richardson@intel.com, ferruh.yigit@amd.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Thu, Feb 2, 2023 at 4:56 PM Tyler Retzlaff <roretzla@linux.microsoft.com> wrote: > > On Thu, Feb 02, 2023 at 10:14:41AM +0100, David Marchand wrote: > > Hello Tyler, > > > > On Fri, Jan 20, 2023 at 11:14 PM Tyler Retzlaff > > <roretzla@linux.microsoft.com> wrote: > > > > > > hi folks, > > > > > > i think this one can probably be merged? > > > > > > Series-acked-by: Morten Br=C3=B8rup <mb@smartsharesystems.com> > > > Series-acked-by: Bruce Richardson <bruce.richardson@intel.com> > > > patch 1/2 Acked-by: Ferruh Yigit <ferruh.yigit@amd.com> > > > > I like the cleanup of rte_common.h and additional unit tests, but the > > MSVC bits don't belong here. > > Please move them in your MSVC enablement series > > hm, the way i'm approaching this is to keep specific features together > similar to if i added new platform functionality for threads i add > windows or linux in the same series. similarly, in this case i'm adding > msvc and gcc in the same series. > > the msvc enablement series introduces the changes for the build system > so it's about enabling a compiler not adding functionality to dpdk so > this change/API really aren't related to the other, but i agree the other > series is part of converging on the platform, toolchain combination > being enabled overall. > > reconsider? if not i guess i'll just withdraw the actual API for now > and have to resubmit and review later since i don't think it belongs > mixed in with the compiler enablement. > > > https://patchwork.dpdk.org/project/dpdk/list/?series=3D26662&state=3D%2= A&archive=3Dboth. > > if the msvc series were just merged, i think the above discussion would b= e > moot no? Indeed, but until we have support for MSVC, this part of the patch is putting dead (untested) code in the tree. It is also confusing to see references to MSVC in the tree while we have nothing setting this config item, and no documentation explaining how/when this will be actually usable. --=20 David Marchand