From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9E8AA0C41; Wed, 15 Sep 2021 17:16:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6B90A4068F; Wed, 15 Sep 2021 17:16:29 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 220114014F for ; Wed, 15 Sep 2021 17:16:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631718987; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rB5gNnRcW3B7+3n5wYuY6+FUrso1jdBzX7oVmprJLCU=; b=b/9t0p+7rkl9JNQtDfnC7arGrDL6h2DxCpXkorCivoF76gbss8CvsiQAynit0rxJH9ak4R pPZUd95KMVtZVn8UDXgY9fev8JyfF/7BQwBD24fQMWpdIzD6WXPea0bTH7sbqlHQDsD8z9 9D8y5k23Zcxm3cEsCGx48a3TAHvoVlw= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-300-Bw1Uzb0bMOORbwg_ikbZMQ-1; Wed, 15 Sep 2021 11:16:24 -0400 X-MC-Unique: Bw1Uzb0bMOORbwg_ikbZMQ-1 Received: by mail-lj1-f200.google.com with SMTP id e10-20020a05651c04ca00b001c99c74e564so462032lji.11 for ; Wed, 15 Sep 2021 08:16:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=rB5gNnRcW3B7+3n5wYuY6+FUrso1jdBzX7oVmprJLCU=; b=HcztRdRRkPsstGA6dIeOi5cHnZVwIqBhQA8nhZze0BXfPvNeIrlKYSloJbCEyXdKk6 TAPxSrj5TJ2DEahdfhyj72LurKvrA5YIrFSeffGm7FpwoWnYrWALmlpIOXAAjMsFkPg4 Ed1RBFWxihCYAP492+QCg69GopCLLMeWBb7jlbnYx+VM86Ja/mHEvKYLSXJ8yoNWDEDD 1ntp/d4aDRwg9m1Ij2+zW8Rm9RXXDum6pVVfhHBy/8EPQ6d/JddG9jKbLmQocMWgOxJj 4Sqh8ogTvfqSVFt79Wp+m0Rk0YqY1XZjtd2C23xb+f/LHvEbITzZ5BbBrIQk5QYeCLJH RtGw== X-Gm-Message-State: AOAM533wJ7cNWaEaMARYfaC/DMepnkJdjdVKX6HFW67SbZKbDNyy1Ls6 rE/mVhFCstsAtIIqjbPM+8MN/B/5UaiZ+7CBSFDLbupOgvut1/Zrc1MrIS+78AmYtXteto0jocV 0uzQBz7aaZ7ruh8Ab/+4= X-Received: by 2002:a05:6512:3f0c:: with SMTP id y12mr318303lfa.499.1631718979695; Wed, 15 Sep 2021 08:16:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx1EyOW5lrKDnKMaQt7VIK07vRrfHZ8OJdyUZfvEXoY0cfJLgO1AwkEy1xy6USugxonYv4ydxiqG0uCyeCLXLk= X-Received: by 2002:a05:6512:3f0c:: with SMTP id y12mr318278lfa.499.1631718979453; Wed, 15 Sep 2021 08:16:19 -0700 (PDT) MIME-Version: 1.0 References: <20210412215339.2439530-1-thomas@monjalon.net> <20210808125139.3573701-1-thomas@monjalon.net> <20210808125139.3573701-2-thomas@monjalon.net> In-Reply-To: From: David Marchand Date: Wed, 15 Sep 2021 17:16:08 +0200 Message-ID: To: Devendra Singh Rawat Cc: Thomas Monjalon , "dev@dpdk.org" , "bruce.richardson@intel.com" , Rasesh Mody Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [EXT] [PATCH v3 1/5] net/qede: fix minsize build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Aug 9, 2021 at 7:15 AM Devendra Singh Rawat wrote: > > > > -----Original Message----- > From: Thomas Monjalon > Sent: Sunday, August 8, 2021 6:22 PM > To: dev@dpdk.org > Cc: bruce.richardson@intel.com; david.marchand@redhat.com; Rasesh Mody ; Devendra Singh Rawat > Subject: [EXT] [PATCH v3 1/5] net/qede: fix minsize build > > External Email > > ---------------------------------------------------------------------- > Error occurs when configuring meson with --buildtype=3Dminsize with GCC 1= 1.1.0: > > In function =E2=80=98__internal_ram_wr_relaxed=E2=80=99, > inlined from =E2=80=98internal_ram_wr=E2=80=99 at ecore_int_api.h:166= :2, > inlined from =E2=80=98qede_update_rx_prod.constprop=E2=80=99 at qede_= rxtx.c:736:2: > drivers/net/qede/base/bcm_osal.h:136:9: error: > =E2=80=98rx_prods=E2=80=99 is used uninitialized [-Werror=3Duninitialized= ] > | rte_write32_relaxed((_val), (_reg_addr)) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > ecore_int_api.h:151:17: note: in expansion of macro =E2=80=98DIRECT_REG_W= R_RELAXED=E2=80=99 > | DIRECT_REG_WR_RELAXED(p_hwfn, &((u32 OSAL_IOMEM *)addr)= [i], > | ^~~~~~~~~~~~~~~~~~~~~ > drivers/net/qede/qede_rxtx.c: In function =E2=80=98qede_update_rx_prod.co= nstprop=E2=80=99: > drivers/net/qede/qede_rxtx.c:724:33: note: =E2=80=98rx_prods=E2=80=99 dec= lared here > | struct eth_rx_prod_data rx_prods =3D { 0 }; > | ^~~~~~~~ > > Signed-off-by: Thomas Monjalon Can you configure your mail client so that it quotes the original mail with some '> ' prefix? Your reply confused patchwork which added back a SoB from Thomas. > --- > drivers/net/qede/qede_rxtx.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c = index 298f4e3e42..35cde561ba 100644 > --- a/drivers/net/qede/qede_rxtx.c > +++ b/drivers/net/qede/qede_rxtx.c > @@ -721,9 +721,10 @@ qede_update_rx_prod(__rte_unused struct qede_dev *ed= ev, { > uint16_t bd_prod =3D ecore_chain_get_prod_idx(&rxq->rx_bd_ring); > uint16_t cqe_prod =3D ecore_chain_get_prod_idx(&rxq->rx_comp_ring= ); > - struct eth_rx_prod_data rx_prods =3D { 0 }; > + struct eth_rx_prod_data rx_prods; > > /* Update producers */ > + memset(&rx_prods, 0, sizeof(rx_prods)); > rx_prods.bd_prod =3D rte_cpu_to_le_16(bd_prod); > rx_prods.cqe_prod =3D rte_cpu_to_le_16(cqe_prod); > > -- > 2.31.1 > > ACKed. Please reply with a full tag so that patchwork catches it. It saves me some time/brain cycles when applying patches. Thanks. --=20 David Marchand