From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1580141CEC; Mon, 20 Feb 2023 15:18:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0589C43058; Mon, 20 Feb 2023 15:18:47 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 3342340395 for ; Mon, 20 Feb 2023 15:18:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676902725; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=resCwr0cfj73emI+ziDgJnh79REKwn9pzfo5bHmB3Lo=; b=fP931L8Im6JbXyCFlJ21Z6L5uXVOfDd2kg1zMjegwiH33g5jKVEdFbtT6o6A4avL7cQYn0 BZRtYXcjsPbgfZc2R2P+0u7ezS9UyVWV+CczWa9KcQm+YC2TI9pEUu5ueq80ooGN9eXn7D WOTdX/WQT16dv7SQ1TRxPnBY7cxnSss= Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-368-aZ7vujNXN0-aGE-6zpg2uw-1; Mon, 20 Feb 2023 09:18:43 -0500 X-MC-Unique: aZ7vujNXN0-aGE-6zpg2uw-1 Received: by mail-pg1-f198.google.com with SMTP id n66-20020a634045000000b004e8c27fa528so446806pga.17 for ; Mon, 20 Feb 2023 06:18:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=resCwr0cfj73emI+ziDgJnh79REKwn9pzfo5bHmB3Lo=; b=eYiTgWlFxX8Aob/AzBVqXE8WFS4P1gFhiohDxZbDcbFtrBqPJEzhzlhrmqM77PnN4c 0CIWXYG4a21Ez2Yu1gufPe5g7H7eFU5r5p/lamzoFWOu7a/IPHh5Iw/3NU5/TGWiSgVW cYUrTy8dFKSxu48MOPhSFwXSp2c4oEoR5k3nEDzfO/wfTqfQPpoZSAkYZQ96NXkFlcB0 yrnsoKkp7jI2aKqL3dwtgninx93kGobXQvExTiwkOygn5hwX54CqhkGj29wBBtz0KgKE k1br1/qw8CF4b2kV8zQUE2hVkFywZxgIfboP9UfdA6uph4OLXIzb6HjXvSX6O+pj7FtH PsDw== X-Gm-Message-State: AO0yUKUXaIwT4Qp2ZTYN3Vpnt0Cgdij1ay/42PrqcylOcjKJDt1yzE5b rpcONOglB+wEphhXUKVlGXEFfGWki9+sHSxU29YnY1h8ADq7CbxPnV6/RVB27xjKF62N8mL1XUp 1XxdoeYXheGVFwehWwK9u0f3C X-Received: by 2002:a17:903:13cf:b0:19a:fa2f:559e with SMTP id kd15-20020a17090313cf00b0019afa2f559emr323575plb.3.1676902722568; Mon, 20 Feb 2023 06:18:42 -0800 (PST) X-Google-Smtp-Source: AK7set9yt5CuQL55qgzU09YYzGSr746dGkKIL8pOaT5wZJ/N/DKuU4jSyYw2PaX/2lIvvpzuoGKIO8ypb0WfZfzJEHA= X-Received: by 2002:a17:903:13cf:b0:19a:fa2f:559e with SMTP id kd15-20020a17090313cf00b0019afa2f559emr323566plb.3.1676902722186; Mon, 20 Feb 2023 06:18:42 -0800 (PST) MIME-Version: 1.0 References: <20230209133019.933380-1-adwivedi@marvell.com> <20230209133019.933380-2-adwivedi@marvell.com> In-Reply-To: From: David Marchand Date: Mon, 20 Feb 2023 15:18:30 +0100 Message-ID: Subject: Re: [EXT] Re: [PATCH v1 1/5] mempool: remove internal tracepoints from version map To: Ankur Dwivedi Cc: Jerin Jacob , "dev@dpdk.org" , "thomas@monjalon.net" , "ferruh.yigit@amd.com" , Jerin Jacob Kollanukkaran X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Feb 14, 2023 at 12:37 PM Ankur Dwivedi wrote: > > >Subject: Re: [EXT] Re: [PATCH v1 1/5] mempool: remove internal tracepoints > >from version map > > > >On Fri, Feb 10, 2023 at 7:54 PM David Marchand > > wrote: > >> > >> On Fri, Feb 10, 2023 at 8:06 AM Jerin Jacob wrote: > >> > > >> > On Fri, Feb 10, 2023 at 12:30 PM Ankur Dwivedi > >wrote: > >> > > > >> > > >On Thu, Feb 9, 2023 at 7:00 PM Ankur Dwivedi > >> > > > > >> > > >wrote: > >> > > >> > >> > > >> The file rte_mempool_trace.h contains tracepoints which are > >> > > >> internal to the mempool library. This file is renamed to > >> > > >> mempool_trace.h, and is made an internal header. The > >> > > >> tracepoints in this file are removed from the experimental section in > >version.map file. > >> > > >> > >> > > >> Signed-off-by: Ankur Dwivedi > >> > > > > >> > > >> @@ -47,22 +47,8 @@ EXPERIMENTAL { > >> > > >> __rte_mempool_trace_generic_get; > >> > > >> __rte_mempool_trace_get_bulk; > >> > > >> __rte_mempool_trace_get_contig_blocks; > >> > > > > >> > > >I think, FP ones also can be removed. > >> > > > >> > > The FP symbols are used in header file rte_mempool.h. Removing the > >> > > symbols will cause build failure in shared build. > >> > > >> > OK. Please update the below note documentation only for FP symbols > >then. > >> > >> I disagree. > >> > >> We may enhance this note, but it is not a matter of being FP / non-FP. > >> A simple example is the "generic" non-FP tracepoints provided by EAL. > > > >OK. Then what's your recommendation for the document update ? > >Generic datatype exposed by EAL trace library or FP trace point object. or > >something else? > >I am trying to see what needs to be added/changed in documentation? > > Will the following line in document cover the different cases: > > For generic tracepoint or for tracepoint used in public header files, the user must export a ``__`` symbol in the library ``.map`` file, for this tracepoint to be used out of the library in shared builds. Yes, this sounds ok to me. Thanks for updating in v3. -- David Marchand