From: David Marchand <david.marchand@redhat.com>
To: Michal Krawczyk <mk@semihalf.com>,
"Wiles, Keith" <keith.wiles@intel.com>
Cc: dev <dev@dpdk.org>, Igor Chauskin <igorch@amazon.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] Fix loss of data stored in udata64 mbuf field
Date: Thu, 4 Feb 2021 10:01:19 +0100 [thread overview]
Message-ID: <CAJFAV8wPZRQ13NrD-fNKve4B8bwi3hw-gYKbF+wyejD29wWLxA@mail.gmail.com> (raw)
In-Reply-To: <20210204085209.2716232-1-mk@semihalf.com>
On Thu, Feb 4, 2021 at 9:52 AM Michal Krawczyk <mk@semihalf.com> wrote:
>
> DPDK v20.11 removed udata64 field, and changed type of the dynfield1 to
> uint32_t.
>
> Due to define:
> lib/common/pg_compat.h:#define udata64 dynfield1[0]
> the copy of udata64 was in fact copying only the first 32 bits.
I did not look at the pktgen code, but directly accessing mbuf field
dynfieldX is likely a bug.
pktgen should register a dynfield for its own usage to avoid conflicts
with other parts of the dpdk.
Example of such a conversion to the new mechanism:
https://git.dpdk.org/dpdk/commit/?id=eb8258402b3f
--
David Marchand
next prev parent reply other threads:[~2021-02-04 9:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 8:52 Michal Krawczyk
2021-02-04 9:01 ` David Marchand [this message]
2021-02-04 9:17 ` Michał Krawczyk
2021-02-04 9:35 ` Thomas Monjalon
2021-02-04 12:24 ` [dpdk-dev] [PATCH v2] " Michal Krawczyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8wPZRQ13NrD-fNKve4B8bwi3hw-gYKbF+wyejD29wWLxA@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=igorch@amazon.com \
--cc=keith.wiles@intel.com \
--cc=mk@semihalf.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).