From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D913A04DD; Thu, 26 Nov 2020 16:29:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DAC6CC9DE; Thu, 26 Nov 2020 16:29:08 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 45F4CC9BC for ; Thu, 26 Nov 2020 16:29:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606404544; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DshHU91FMobXV8V+bdpeycN7ZOJLwV6GLdF84drAD6M=; b=BLNRkKEQuWp5RarT2vPEWmW0c0MoaDm0dKmusdEtqBIoyb6nNJQ9XlzRKBIFy5baEaqS7Z WJkvf0EtVIJJ2CtUMFK3wPLnLpTc6gIunG2MOCMyJSRE6y/zXFuj0HNH4ZlNwHUTXjpp2p 9NKLzJzVHHtWhNN5MXx2fya3FDSnYmc= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-520--rCjK-24PGyK9vDWVBh-9w-1; Thu, 26 Nov 2020 10:29:02 -0500 X-MC-Unique: -rCjK-24PGyK9vDWVBh-9w-1 Received: by mail-ua1-f71.google.com with SMTP id m3so673028uak.9 for ; Thu, 26 Nov 2020 07:29:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DshHU91FMobXV8V+bdpeycN7ZOJLwV6GLdF84drAD6M=; b=n/htrZeiN4XSTA3Z8AairbMYIJy1ntFhSUVCCFIUo03mq5WBQEm2SS6dv19VVAg/1c NV/FFcZryhLROaPv6m3wsswhR0JSlQurHqIRxVfeCG/KRerLZ6WXk3ypjA3/xIjbXMfa YMA0dyU9hWnoIPEN5PU49EAa0UaxI6WNmvS8ii5N7gPrbuVAKKDsDEyU27VZxXRuLmZ4 MerVFs4wjUPswIRCzMMwEqpr38fQmyDX1+zC5F4j69BtlWSCYhPIggyq9uJ3pC3bSELy /sSZz9+EvsW+NXhwghwHs9MiFqBjNcf53TF9J7XkmAWgO+Ddcm+7MA4lb2+afJXYETYe f44A== X-Gm-Message-State: AOAM532Osz2Xs4tBzp51M10KlLZ+DHG3Zpk2rK2kohvSqQBnPOyehI9H 5toKEgl9bIZ4g1hXjuXo/WB9V8XJpOUXusULENHVHhfJf2YNMN9LxBu5zfZi2M8sKVJawiNA6Ln FYOFw0zq19Fo/PEEsOoE= X-Received: by 2002:ab0:6dd3:: with SMTP id r19mr1614414uaf.86.1606404542411; Thu, 26 Nov 2020 07:29:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJzIMrmEj0fjghxNhGsywTl3lF9G+EN9nWJqMzTOcYAV27LqOte4S1ZpstG04m+qtT/6oCyxNIzZ1/WXapboG1w= X-Received: by 2002:ab0:6dd3:: with SMTP id r19mr1614408uaf.86.1606404542273; Thu, 26 Nov 2020 07:29:02 -0800 (PST) MIME-Version: 1.0 References: <1594650325-151798-1-git-send-email-reshma.pattan@intel.com> <1606398674-32351-1-git-send-email-reshma.pattan@intel.com> In-Reply-To: <1606398674-32351-1-git-send-email-reshma.pattan@intel.com> From: David Marchand Date: Thu, 26 Nov 2020 16:28:51 +0100 Message-ID: To: Reshma Pattan Cc: dev , Bruce Richardson Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] doc: update pdump documentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Nov 26, 2020 at 2:58 PM Reshma Pattan wrote: > > Update the pdump library programmers guide and Howto doc > with the use of multi process channel replacing socket > based communication. > > Signed-off-by: Reshma Pattan > Acked-by: Bruce Richardson [snip] > The library APIs ``rte_pdump_disable()`` and ``rte_pdump_disable_by_deviceid()`` disables the packet capture. > -On each call to these APIs, the library creates a separate client socket, creates the "pdump disable" request and sends > -the request to the server. The server that is listening on the socket will take the request and disable the packet > -capture by removing the Ethernet RX and TX callbacks for the given port or device_id and queue combinations. The server > -also sends the response back to the client about the status of the request that was processed. After the response is > -received from the server, the client socket is closed. > +For the calls to these APIs from secondary process, the library creates the "pdump disable" request and sends > +the request to the primary process over the multi process channel. The primary process takes this request and disables the packet capture by removing the Ethernet RX and TX callbacks for the given port or device_id and queue combinations. I split this long line to multiple ~100 characters lines like the rest of the document. Applied, thanks. -- David Marchand