From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7957C427E2; Mon, 20 Mar 2023 14:22:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 06C6940A7F; Mon, 20 Mar 2023 14:22:48 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 8270E406BC for ; Mon, 20 Mar 2023 14:22:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679318565; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X0KernMKO+W2jXGZ64rUDNBPEOU8Z4XOCLA7wq3OkmY=; b=har69/Qwfypqr1S0dy+7DYVvRQTd4JdAMMXVq4GneibvsRO83XgZ1g6U7tK3vODeIlzij4 OmIhsAHysbLbRoe4xEOD4jvlu36oC1BHdyNZIt6IYZ/agd1s/QSMGWTzOBkMUbuFsrYHSU KcQ3tSagTZUJw9rga8DMcznjesQ7DDE= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-353-gtnRiXOWPBqwtoiG0YWUCQ-1; Mon, 20 Mar 2023 09:22:44 -0400 X-MC-Unique: gtnRiXOWPBqwtoiG0YWUCQ-1 Received: by mail-pf1-f197.google.com with SMTP id i26-20020aa796fa000000b006261da7aeceso4716183pfq.5 for ; Mon, 20 Mar 2023 06:22:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679318564; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X0KernMKO+W2jXGZ64rUDNBPEOU8Z4XOCLA7wq3OkmY=; b=pnJ5KDPfQhc5+epReVYpzemATK36m6r08FE3nMyJ1RI6SItTqVrrkzUc7X2ljFSWSD ITRW9jCuLPZf6L4xXPMsynJUju3Qs+2XBotYiEl6a8shtCBXToB9h7I1aNKI2GTepWCR iVM7ctnvipeYUTqWU43colc37AuZvbvcrviOARyLjjeRx5MjdGO2N3aSVOHRWjYmVsMn PFBW6OHlWJLWGHoTpPDnE4nXZgUpnQH+WULYvV1YLhOS2AOIjEFEDz1v0PAQpf3CGiIp cTfxBgkP3GDmHgyu4yK0DBTIArm5iSXkPSHlZKMHMmz0v8w3Pn4pbtzC0hULNBV97mdg QyhA== X-Gm-Message-State: AO0yUKXsJbA/jV9RraOzzAD1nVagNA0wecQCOnMDE/xcO1tgGOn9eY2Z JQBWe/Dci7CtrbnbAO+cVvH6vLjT8pW1gzHVGZ5vaFe6f5vBYnBG+P7edpaOmKV6XYvLlvmkj1+ 29LV3ygdBrRBoWSdZEjk= X-Received: by 2002:a05:6a00:c8b:b0:628:30d:2d2f with SMTP id a11-20020a056a000c8b00b00628030d2d2fmr765454pfv.5.1679318563781; Mon, 20 Mar 2023 06:22:43 -0700 (PDT) X-Google-Smtp-Source: AK7set+n5n5V7mbzmhZIW+CFeJpBIGIzED7rUIzvxAiAiLniDathSANC9Nz1LVLHt3hUuzJSj9IFEJocB00DUwPw8FU= X-Received: by 2002:a05:6a00:c8b:b0:628:30d:2d2f with SMTP id a11-20020a056a000c8b00b00628030d2d2fmr765439pfv.5.1679318563517; Mon, 20 Mar 2023 06:22:43 -0700 (PDT) MIME-Version: 1.0 References: <20230223152840.634183-1-juraj.linkes@pantheon.tech> <20230303102507.527790-1-juraj.linkes@pantheon.tech> <20230303102507.527790-4-juraj.linkes@pantheon.tech> In-Reply-To: From: David Marchand Date: Mon, 20 Mar 2023 14:22:32 +0100 Message-ID: Subject: Re: [PATCH v6 03/10] dts: add dpdk build on sut To: =?UTF-8?Q?Juraj_Linke=C5=A1?= Cc: thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, lijuan.tu@intel.com, bruce.richardson@intel.com, probb@iol.unh.edu, dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Mar 20, 2023 at 2:12=E2=80=AFPM Juraj Linke=C5=A1 wrote: > On Mon, Mar 20, 2023 at 9:30=E2=80=AFAM David Marchand > wrote: > > On Fri, Mar 3, 2023 at 11:25=E2=80=AFAM Juraj Linke=C5=A1 wrote: > > > +class MesonArgs(object): > > > + """ > > > + Aggregate the arguments needed to build DPDK: > > > + default_library: Default library type, Meson allows "shared", "s= tatic" and "both". > > > + Defaults to None, in which case the argument won't be= used. > > > + Keyword arguments: The arguments found in meson_options.txt in r= oot DPDK directory. > > > + Do not use -D with them, for example: > > > + meson_args =3D MesonArgs(enable_kmods=3DTrue). > > > + """ > > > + > > > + _default_library: str > > > + > > > + def __init__(self, default_library: str | None =3D None, **dpdk_= args: str | bool): > > > + self._default_library =3D ( > > > + f"--default-library=3D{default_library}" if default_libr= ary else "" > > > + ) > > > + self._dpdk_args =3D " ".join( > > > + ( > > > + f"-D{dpdk_arg_name}=3D{dpdk_arg_value}" > > > + for dpdk_arg_name, dpdk_arg_value in dpdk_args.items= () > > > + ) > > > + ) > > > > I am missing something here. > > Afair, meson accepts the -Ddefault_library form. > > > > Why do we need this special case? > > I did not know that specifying default_library with -D is possible. > Should I submit a fix? This is not a big/pressing issue. This can go in the next release. Thanks. --=20 David Marchand