From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5243D43382; Wed, 22 Nov 2023 17:03:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DD5544028C; Wed, 22 Nov 2023 17:03:14 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 3CD7140265 for ; Wed, 22 Nov 2023 17:03:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700668992; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yojJWffQH49afBMubHB26OJFo2GKYx0wKvP5Pfe8ZvE=; b=LHoyiW0o+mJjr/5Rdwous7V/Qht/DH0bWvnoQRZSwEiGVe6r5ltUFZFk/Mr8UKEHEjy433 S6bV6w8XAZz7RdxVMcZG567iBYG10LRiSaOybJuRKXWT1F7S47u4+Pp8fOsE1iADndnm/X j4W7xunOTi4kMT+cNrYMcFIxG88/BA0= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-134-K4eTd2tcPJqp7DqySONY9w-1; Wed, 22 Nov 2023 11:03:10 -0500 X-MC-Unique: K4eTd2tcPJqp7DqySONY9w-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2c737d1ba09so57791741fa.1 for ; Wed, 22 Nov 2023 08:03:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700668989; x=1701273789; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yojJWffQH49afBMubHB26OJFo2GKYx0wKvP5Pfe8ZvE=; b=GUDvwNXia4SEZIMPONkAQAQXsbsrAkrfh/pTqx71DxXgHrGeD3F7YayUVHmc6WB5ep hNSg5Y9jLojEvyr19dn7nqk0ajYwix5YUFqJFRBxEIGwEMHzZs8BX4nniod0u75FeHhy pFNyo/2pFNtCr7mcB257rCc1d51iNkBYq8cBuqwP5MqGcy1cw7nQUBIt0LYLca4c1fu+ FK778HnsHw12w/63Ckw2NI4kpI+qLuALW+gOlp5jBDhcyrW8umaia2KL5Vp06uVDcy2I pSbat54ye6IyaKj0Kp+0+/hSiHiQF+xszCn/5gFOe/IyODVVUNkW/8QlBDiAhq48zuou MeXg== X-Gm-Message-State: AOJu0YxLx3OsFMVkBVFlDqo99mFcA7tA4LH49V3ZD8jG9pUY9cpdv1io RekCj8V8lfhMUQ/OC4hf6sNEkYuv6+1sCNHbAwjI4iFdad7sJNR3nsAKbyNfOEFIo/pDET9mmax UYvoCf2/JbBQ4reHYa6I= X-Received: by 2002:a2e:8845:0:b0:2c8:7c1d:211b with SMTP id z5-20020a2e8845000000b002c87c1d211bmr1977935ljj.52.1700668988723; Wed, 22 Nov 2023 08:03:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IHi+UPKzEkN8uEayJRgQ7KhvYjzsZp0DfPwdlyPASqjrhCUebn66FiyaF/lSD1HA193StXoa8GHfY+8qYapujQ= X-Received: by 2002:a2e:8845:0:b0:2c8:7c1d:211b with SMTP id z5-20020a2e8845000000b002c87c1d211bmr1977860ljj.52.1700668987710; Wed, 22 Nov 2023 08:03:07 -0800 (PST) MIME-Version: 1.0 References: <20231121164903.3982163-1-christian.ehrhardt@canonical.com> In-Reply-To: <20231121164903.3982163-1-christian.ehrhardt@canonical.com> From: David Marchand Date: Wed, 22 Nov 2023 17:02:56 +0100 Message-ID: Subject: Re: [PATCH] build: riscv is not a valid -march value To: christian.ehrhardt@canonical.com, Bruce Richardson Cc: dev , Thomas Monjalon , Luca Boccassi , Stanislaw Kardach X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Nov 21, 2023 at 5:49=E2=80=AFPM = wrote: > > From: Christian Ehrhardt > > If building riscv natively with -Dplatform=3Dgeneric config/meson.build > will select cpu_instruction_set=3Driscv. > > That was fine because config/riscv/meson.build did override it to valid > values later, but since b7676fcccab4 ("config: verify machine arch > flag") it will break the build as it tries to test -march=3Driscv which > is not a value value. > > The generic setting used in most cases is rv64gc, set this here > as well. > > Fixes: b7676fcccab4 ("config: verify machine arch flag") > Fixes: f22e705ebf12 ("eal/riscv: support RISC-V architecture") > > Signed-off-by: Christian Ehrhardt > --- > config/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/config/meson.build b/config/meson.build > index d732154731..a9ccd56deb 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -152,7 +152,7 @@ if cpu_instruction_set =3D=3D 'generic' > elif host_machine.cpu_family().startswith('ppc') > cpu_instruction_set =3D 'power8' > elif host_machine.cpu_family().startswith('riscv') > - cpu_instruction_set =3D 'riscv' > + cpu_instruction_set =3D 'rv64gc' Copying more people. This fix is probably the best, so close to the release. However, I think a more complete fix would be to set this here to generic. And do the march validation in config/riscv/meson.build in a similar fashion to ARM. Or maybe the validation added in b7676fcccab4 ("config: verify machine arch flag") should be moved after subdir(arch_subdir). Bruce, opinion? --=20 David Marchand