From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA362A04B1; Thu, 5 Nov 2020 09:28:17 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B5A6B5B3A; Thu, 5 Nov 2020 09:28:16 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 583955AB3 for ; Thu, 5 Nov 2020 09:28:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604564893; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lo7/YEGKMaLme2P29pmR/oR8fsyoY14bSh4S4aK2hnE=; b=IlPA8eleLqQX4Do0eqlf+Pv7nDIXCFto6p/NORELJc2kbz/hFjQWTR0fia8CotBSPEmNUE FfEnWsyznLOq5hxMLz22s76NFgU9z+rQxdiBszxw7XRIpb6iWur/HKL6DssE8ikwICxM8Z z00Ab0J2cM7n1yT3HLUM/iD1wmFCFPU= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-90-a3tea5fzNli_aAmtwc6tlQ-1; Thu, 05 Nov 2020 03:28:11 -0500 X-MC-Unique: a3tea5fzNli_aAmtwc6tlQ-1 Received: by mail-vs1-f70.google.com with SMTP id i5so454480vsb.6 for ; Thu, 05 Nov 2020 00:28:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lo7/YEGKMaLme2P29pmR/oR8fsyoY14bSh4S4aK2hnE=; b=rNv6iODdJ5XXXnvBF+OJeNNm946x9VKaoQb2MOhdds6pblyjSAxwKJQICZpNTuRLTs 8kLdPoMqIs9NbUpB6frOv44WdZiVUQ3PPJ1GLZE5bmjBavVcJ8ghhwsAisXBxPnXPJ8S v6YBQeU03+Met3F0eSchu6EYBoQhYm2IdL/XTN0xp8qRzbmLtAiMuOmRaCqYo30BUhuh bDLrBeQfAxbYP7AvhV1Pr8GlgaqD43paFDl32ls+kw/LV/tV+XM1DU8TVQdXBXHWjCMc wm7dBCfAUUVrF5QN3+eBic4tDf62hOsbUqGbuuuVxhLN9wWAp3/ZCv0Oz7Rd3Ksln+UP tKFg== X-Gm-Message-State: AOAM532Qd0D4lzCV493EOPVt/NAIG3HO91rytDaPLU15Ar6KHy9TxK1S tTiVaof5wwaePhLaXAzIgr+hqrqdN3UOTHAMINdN3PGAlYucpie8DGsUAgrBm2dzOBwLuYj0VSO ShmttQOyqy2tGfDHLI9Q= X-Received: by 2002:a05:6102:4b6:: with SMTP id r22mr496595vsa.10.1604564890429; Thu, 05 Nov 2020 00:28:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJxZQ3IaX5BWhcAY5MeA/H/fiTH77D98yHcTxbZflCM7o4/SaSI6hbgVh66vVWa4kZR8+CzZjm2wuVmle+sOvyc= X-Received: by 2002:a05:6102:4b6:: with SMTP id r22mr496587vsa.10.1604564890241; Thu, 05 Nov 2020 00:28:10 -0800 (PST) MIME-Version: 1.0 References: <20200922143202.8755-1-stephen@networkplumber.org> <20201024010146.27689-1-stephen@networkplumber.org> In-Reply-To: <20201024010146.27689-1-stephen@networkplumber.org> From: David Marchand Date: Thu, 5 Nov 2020 09:27:59 +0100 Message-ID: To: Stephen Hemminger Cc: dev , Luca Boccassi , Gaetan Rivet , Hemant Agrawal , Thomas Monjalon , "Yigit, Ferruh" , "Mcnamara, John" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5 0/5] replace blacklist/whitelist with block/allow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Oct 24, 2020 at 3:02 AM Stephen Hemminger wrote: > > This is a revised version of the earlier RFC patch set for changing > the blacklist/whitelist terms in DPDK. > > The first patch is a duplicate from the other patch set about > use of master/slave in API. > > Note: > This may cause some warnings in existing programs in the CI > tests using the -w flag. > > It also causes checkpatch complaints because we are replacing > blacklist which is flagged by the current versions. > > v5 - rebase and fix conflicts in documentation > > Stephen Hemminger (5): > eal: replace usage of blacklist/whitelist in enum > drivers: replace references to blacklist > eal: replace pci-whitelist/pci-blacklist options > app/test: use new allowlist and blocklist > doc: change references to blacklist and whitelist - This series does not implement what had been announced in the deprecation notice: https://git.dpdk.org/dpdk/commit/doc/guides/rel_notes/deprecation.rst?id=714e3e60014206cb616cd4157bf11a5209e7186f >From my pov, the implementation with ALLOWED/BLOCKED is as good as the one initially proposed so this is fine. But in this case, please stick to it, there are still some traces about "included" / "include" / "excluded" "exclude" devices, in comments and usage strings. Idem, please stick to a consistent wording in all patches, I noted "Blocklisted" "Blocked" "Marked as blocked". - The release note and deprecation notice (which is missing) must both be updated atomically with the patches that change API. - Compilation is broken at patch1, since patch2 changes are required. - The documentation patch has misses: doc/guides/nics/fail_safe.rst: -w 81:00.0 -- -i doc/guides/nics/fail_safe.rst: .//app/dpdk-testpmd -c 0xff -n 4 -w ff:ff.f \ doc/guides/sample_app_ug/vdpa.rst: -w 0000:06:00.3,vdpa=1 -a 0000:06:00.4,vdpa=1 \ - The documentation patch has a rebase issue in ice.rst, as flow mark devargs has been dropped in 62451c94ad - net/ice: remove devargs for flow mark (7 weeks ago) -- David Marchand