From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BDA6DA0547; Tue, 19 Oct 2021 22:09:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8279C40142; Tue, 19 Oct 2021 22:09:32 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 69DF34003E for ; Tue, 19 Oct 2021 22:09:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634674170; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NqqG65JZ4BK3YcrsK2kF/zr5mFX9c2xHuR+FGF1DSCs=; b=g/ZQW1ujhVKEVv/AEExyQHFXKeyNfWu7aKT6uSjCNJWmZ6d9398UgHhzGRrqDdzFOWSvHZ 5sofzrOCyRX07saGLPFfrSnYB4Mij1N4cGTtnU40XkDa/zf+YDWK3UaBqecTd5zosbsPqf 9W3NmSv8RSvLfVFqkMXqsBsGtDdOtak= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-499-JDsOxKgAPrq7pbi_OtkUEA-1; Tue, 19 Oct 2021 16:09:29 -0400 X-MC-Unique: JDsOxKgAPrq7pbi_OtkUEA-1 Received: by mail-lf1-f70.google.com with SMTP id bi16-20020a0565120e9000b003fd56ef5a94so1909752lfb.3 for ; Tue, 19 Oct 2021 13:09:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NqqG65JZ4BK3YcrsK2kF/zr5mFX9c2xHuR+FGF1DSCs=; b=LHqQ+mexPZU3a+uXvEDUn5kgCQRibIbiLPTrJiN6Z0ZT65kwGpnO0oQWaKi/I5sY83 zrNrNxhSEIz8DjM5ZZvb0bNMv6C7i6ShUreKvyrokufuoVC9BbP2sCr4LcVtBWWypTqK SlpnmKjLS1XH5S+r5GroOghM653hKX1vk6Gi7kMWVR8/hlZc8hn0xWaJiw6gCRUnIE1W Iy/jWlGx4f2qYcXXm+vbD2xkbntSPRL8QcfLNAvsbQ66Bfci2dZmAdwl2/EFNyO873n7 /OK5YoBFRWh/IYp+KoeKV+mAkMEHFtdv2AlA9FasuDx9pvuzRLFZJkgEeGfyaqVcf4fh lQgg== X-Gm-Message-State: AOAM533XktYUTULMAvHhstwL6U/RDr9vDwSJ7VHM+u4/w9VqgTqJvUTV 1pz36F4H9CXxb8MeVwtxR6AY9sxeLfESQ/Rtloa6aJz9osuyyAID4gZ40P1fisnXqr5sWMyAgWl W3xct9lm7ld9+uJb3Qwo= X-Received: by 2002:a05:6512:31c3:: with SMTP id j3mr7960047lfe.217.1634674167952; Tue, 19 Oct 2021 13:09:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzN+Geh+j0AX+PRC3QNp7aiuzljfmd1ALi1w0zof8DYLUWPRDzqDTC5VU8ZDfC99DHD61mLouopc0bqK4jmC2I= X-Received: by 2002:a05:6512:31c3:: with SMTP id j3mr7960027lfe.217.1634674167735; Tue, 19 Oct 2021 13:09:27 -0700 (PDT) MIME-Version: 1.0 References: <20211018144907.1145028-1-andrew.rybchenko@oktetlabs.ru> <20211019174022.2036272-1-andrew.rybchenko@oktetlabs.ru> In-Reply-To: <20211019174022.2036272-1-andrew.rybchenko@oktetlabs.ru> From: David Marchand Date: Tue, 19 Oct 2021 22:09:16 +0200 Message-ID: To: Andrew Rybchenko Cc: Olivier Matz , dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 0/6] mempool: cleanup namespace X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 19, 2021 at 7:40 PM Andrew Rybchenko wrote: > > Add RTE_ prefix to mempool API including internal. Keep old public API > with fallback to new defines. Internal API is just renamed. > > v3: > - fix typo > - rebase on top of current main > - add prefix to newly added MEMPOOL_F_NON_IO > - fix deprecation usage > - add Fixes tag the patch which deprecates unused macros Thanks for the quick rebase. I had rebased v2 before Olivier comments. I spotted a little issue diffing with your v3 (see comment on patch 2), and fixed your v3 in a local branch of mine. It passes my checks. I'll wait tomorrow, to see if Olivier wants to send some acks. -- David Marchand