From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83451A034C; Mon, 24 Oct 2022 13:37:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2EB8240A8B; Mon, 24 Oct 2022 13:37:50 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 94A804069C for ; Mon, 24 Oct 2022 13:37:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666611468; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2a3WqhuGJoNNZwFmu6jwhHCVj+qznOBm0/0QTiz8rL8=; b=Ov+inENX6koKyin9RZ22HiC/19xit+WhLmuNoBB+CF0Xil3N25KxtrQg8ZPqp2EmGOJZBZ jaz/la1itgVs7Hyb9HvUkgV/vdsK5FysSIAW646txsh0XeZjZVy0SN9pbx1vwSpL1KXIut HAvn61cxKbrHD/1sE++G+K3bHNQ5nGk= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-307-Fr-VHidyNLG3nmlHwueTxQ-1; Mon, 24 Oct 2022 07:37:38 -0400 X-MC-Unique: Fr-VHidyNLG3nmlHwueTxQ-1 Received: by mail-pl1-f200.google.com with SMTP id p3-20020a170902e74300b0018546b77dccso6281675plf.17 for ; Mon, 24 Oct 2022 04:37:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2a3WqhuGJoNNZwFmu6jwhHCVj+qznOBm0/0QTiz8rL8=; b=A4E+MdSsd2mzp0c57cP0/bckr7ilbJsfVndSzCN4ZpY8vL6tBrq+4iSRPS6XTC47p2 VDCmenWtWuXNlpPuzI7Rx7uHH6ZdpjDwCmQPsbNK6+U/qhg+nvVFQcMY10z+CowsfoFx VByJhgVpfgvwTMEMgY/qlL0zggWBKrBs8aVdB+Y3lDusmAX8l6DQ6CdHCFTBG59fg4ep IjqkBp0EqnS8du88BvNmxJ7sK071UV8LaZqMz8fRoJDNpMZfZxjbXC90+9fhr7rxC9w4 1qX+Skk0l19nrAC00xqOqUQiQhecEgSWSXIsPVqErTAo4n4i7370RQL4HfpdZBXC9/gN teSA== X-Gm-Message-State: ACrzQf07teTfqSpqWU0Ea9O9l9NC9qSAi0M/e77LeOOH38w7sszZqCHa fwiyZIDy6oTdkqGJz08Lbz6qQEwOpcjydqX0qcjpnH/rw/CHue3AcVrOWm0AIC3VZiLHqwLGqVE TrxC3d7GkOcZx4xGVjsI= X-Received: by 2002:aa7:979a:0:b0:563:a69:96c7 with SMTP id o26-20020aa7979a000000b005630a6996c7mr32480157pfp.29.1666611457914; Mon, 24 Oct 2022 04:37:37 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5V9yYouMDfGZFavxeQh/+uRe62LYAmmg8UqFszbIdRmUIXtdt1PegUfjjcYqhZsAm4LwR3HPFD56bjsMGZZzI= X-Received: by 2002:aa7:979a:0:b0:563:a69:96c7 with SMTP id o26-20020aa7979a000000b005630a6996c7mr32480141pfp.29.1666611457621; Mon, 24 Oct 2022 04:37:37 -0700 (PDT) MIME-Version: 1.0 References: <20221022083108.3759-1-olivier.matz@6wind.com> <20221024071214.20980-1-olivier.matz@6wind.com> In-Reply-To: <20221024071214.20980-1-olivier.matz@6wind.com> From: David Marchand Date: Mon, 24 Oct 2022 13:37:26 +0200 Message-ID: Subject: Re: [PATCH v2] app/test: fix PMD perf test on devices with no socket ID To: Olivier Matz Cc: dev@dpdk.org, linglix.chen@intel.com, yux.jiang@intel.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Oct 24, 2022 at 9:12 AM Olivier Matz wrote: > > If the socket ID of a device is unknown, rte_eth_dev_socket_id(portid) > now returns -1 instead of 0 since commit 7dcd73e37965 ("drivers/bus: set > device NUMA node to unknown by default"). > > This change breaks the pmd_perf test on environment where the device > socket ID is unknown. The test fails with the following error, because > it does not find a lcore on socket -1: > > > No avail lcore to run test > > Take the new behavior in account in the pmd_perf test: in this > environment, the test can now run on any lcore, and not only those from > socket 0 (this was the old behavior). > > Bugzilla ID: 1105 > Fixes: 7dcd73e37965 ("drivers/bus: set device NUMA node to unknown by default") > > Signed-off-by: Olivier Matz >From the bugzilla comments: Tested-by: Lingli Chen Reviewed-by: David Marchand Applied, thanks. -- David Marchand