From: David Marchand <david.marchand@redhat.com>
To: "Namburu, Chandu-babu" <chandu@amd.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "835703180@qq.com" <835703180@qq.com>
Subject: Re: [PATCH] crypto/ccp: Check for the NULL pointer after calling rte_malloc
Date: Wed, 20 Jul 2022 15:43:35 +0200 [thread overview]
Message-ID: <CAJFAV8wSpHR-67uHDHgw8oAwsOs0HqyAA_okvgi5S_08PiNFfQ@mail.gmail.com> (raw)
In-Reply-To: <SN1PR12MB254448054BD7321762898094C88E9@SN1PR12MB2544.namprd12.prod.outlook.com>
On Wed, Jul 20, 2022 at 8:29 AM Namburu, Chandu-babu <chandu@amd.com> wrote:
> From: Shiqi Liu <835703180@qq.com>
>
> As the possible failure of the rte_malloc(), the not_checked and checked could be NULL pointer.
> Therefore, it should be better to check it in order to avoid the dereference of the NULL pointer.
>
> Fixes: 09a0fd736a0 ("crypto/ccp: enable IOMMU")
> Signed-off-by: Shiqi Liu <835703180@qq.com>
This sha_ctx variable and its accesses are suspicious.
It seems to be used as some kind of intermediate buffer, but I fail to
see the need.
Can't the existing code rely on sess->auth.ctx ?
There is also a suspicious mention (in ccp_perform_sha) of sha_ctx but
with no calling rte_mem_virt2iova().
--
David Marchand
next prev parent reply other threads:[~2022-07-20 13:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-09 11:01 835703180
2022-07-20 6:29 ` Namburu, Chandu-babu
2022-07-20 13:43 ` David Marchand [this message]
2022-08-16 16:01 ` [EXT] " Akhil Goyal
2022-08-23 6:14 ` Namburu, Chandu-babu
2022-07-20 15:42 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8wSpHR-67uHDHgw8oAwsOs0HqyAA_okvgi5S_08PiNFfQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=835703180@qq.com \
--cc=chandu@amd.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).