From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B8F6DA0093; Tue, 19 May 2020 09:43:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8D0E41D423; Tue, 19 May 2020 09:43:59 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 2DC1C1D37F for ; Tue, 19 May 2020 09:43:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589874237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Cet4FmXP0/ZISBR6Jmgr4O11eqXlNFF7fQzHKD1sOGI=; b=PGc1KuQARcf7kEe1BZlabTB88sWNiJBtNFYYvqVE/nCqhTDoV7Hl5uot6VNWlki02HwV3Y mIp24/BpcWrfiE/x+cbpicphDDZ7fGANwwgrOJWmMBUK241ZFd0Rj4CaupN4sCZzCL4mYf SsHLAvi0y3xmMc6Md4j6kYqas51GWbA= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-423-7WdfWbkKOBuCK9xi7g5WDQ-1; Tue, 19 May 2020 03:43:56 -0400 X-MC-Unique: 7WdfWbkKOBuCK9xi7g5WDQ-1 Received: by mail-vk1-f197.google.com with SMTP id k20so5627189vke.1 for ; Tue, 19 May 2020 00:43:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Cet4FmXP0/ZISBR6Jmgr4O11eqXlNFF7fQzHKD1sOGI=; b=Sg6kVcGX2JwXjeeJSikviD5FNePbLzWKgFPKBfkoarW3b9VL06IHzap3uAWhRpneUp xEue7O33kk53EM3mCgfq94ZP2t/BBXpf8RdvF+8bt2OMJiL5g0OFQwalKIGj9+PYHW9W O/nP7JDg+w+ZLfkV2ND2HUevQTyB5pGp57M+jbY0ePSjrk9m4nt2doRLXSoo1K6WynLk k8aplYKeLyhEFgnTU0zf3iYyt397EzrFqQ9duM+E3yElbRoW0N+A7jF0Ya/mk55RZqKj SMuk0zb7/5mDbSh+9a9Pz90T8SV/Zvq4xbf+HQnVcCetyseINanMJTnRGflg4QRJmwst B3VA== X-Gm-Message-State: AOAM5314EH/KzqN6atgkom9SdScdDiZbK/hePUXIn4x2oSMRDEKXer5J aqLJR3hMRA+QUlPK17pSEAWggf7cajjkFUxoxageHestjY3GHfixt6YnocH8EBXHZNjiA+zilmY T9nziBwT2UlN+6K59Na0= X-Received: by 2002:a9f:2c87:: with SMTP id w7mr15010808uaj.41.1589874235490; Tue, 19 May 2020 00:43:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyLY+bniWAADxQ4EizeTZcd4Oi1kyQKlHuxHfbS+aC33R8PcacMSgtgkT+uyirl5qNWsSIwG1rSMvvu3zofaBc= X-Received: by 2002:a9f:2c87:: with SMTP id w7mr15010792uaj.41.1589874235214; Tue, 19 May 2020 00:43:55 -0700 (PDT) MIME-Version: 1.0 References: <1589859720-16224-1-git-send-email-wangyunjian@huawei.com> In-Reply-To: <1589859720-16224-1-git-send-email-wangyunjian@huawei.com> From: David Marchand Date: Tue, 19 May 2020 09:43:44 +0200 Message-ID: To: wangyunjian , "Burakov, Anatoly" , Luca Boccassi , Kevin Traynor Cc: dev , Hemant Agrawal , Sachin Saxena , "Lilijun (Jerry)" , xudingke , dpdk stable X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] vfio: fix check for vfio_group_fd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, May 19, 2020 at 5:42 AM wangyunjian wrote: > > From: Yunjian Wang > > The issue is that a file descriptor at 0 is a valid one. Currently > the file not found, the return value will be set to 0. As a result, > it is impossible to distinguish between a correct descriptor and a > failed return value. Fix it to return -ENOENT instead of 0. > > Fixes: b758423bc4fe ("vfio: fix race condition with sysfs") > Fixes: ff0b67d1c868 ("vfio: DMA mappinge") > Cc: stable@dpdk.org This patch reverts the (marked for stable) fix b758423bc4fe ("vfio: fix race condition with sysfs") and comes with a different fix. - Kevin, Luca, I would put this b758423bc4fe backport on hold. - Anatoly, I don't want to put 20.05 at risk. My simple question for 20.05 is, should we revert b758423bc4fe? - This patchset will go to 20.08 as I don't feel confident in taking it now. -- David Marchand