From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E18742397; Mon, 20 Mar 2023 09:30:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2C55140A7F; Mon, 20 Mar 2023 09:30:25 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 8F001406BC for ; Mon, 20 Mar 2023 09:30:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679301023; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OKecvoqdzK9UBAHBvFCRbyL8qGaMUF6tJLFmsyfyCLE=; b=LRrOjdzNWQqOzXcoATa72pF+6rlCfxu77eadjLoeTWNkALcWInSQo5kgYzJIb0h/GsWMAJ 3QDZA8PbrTz+FAkfc738nlCnzI2/IE+2XIwgfjfU7OtI5CLGu2IOrEhiFRYJw73CWPKV4Q 2eG0JBlZg6BgzPUGwei+WTLnviJt1PY= Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-427-ulYq4rKAOIOtYa0J35silg-1; Mon, 20 Mar 2023 04:30:21 -0400 X-MC-Unique: ulYq4rKAOIOtYa0J35silg-1 Received: by mail-pf1-f200.google.com with SMTP id d12-20020a056a0024cc00b006256990dddeso5923973pfv.9 for ; Mon, 20 Mar 2023 01:30:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679301021; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OKecvoqdzK9UBAHBvFCRbyL8qGaMUF6tJLFmsyfyCLE=; b=W6l2JjATljV+Hknbz3xSrun7ElMEHC9dd5pXUK3q+ASc5UFnMj5QpVsj4AC5dV+u8A 7SWOlBojPHyiY5s2zzRK/dl53RaILKifBpJ0Om4CpnLueIcLEy0LGzho14nBeSgdWTNH eFrYfrhgHCCMZH53wWNQF4bd/ranQrU8jpM+Td5uAIz5gGVn1oJaK4QLmOOBBR2hJQIT zs4IpgVpb3xHanp5ANpgtM1s8ESOzRFwrFJRdnivdgKONsDmriBf4ltJ/ObW2hMTWvJJ E1FrQiDqVI+oOf7LbOqiPjnrvbV8GEaROBVplVArXUo2aHTBYcJgvG/uNBx7D0xnvaTR n4sA== X-Gm-Message-State: AO0yUKVwjNsKEEsk1iFlugtV1SBPVsMyUlHgDG1JNnSTNXHOHq8xeLPO 0IQrJ6a9LKnVwV6nruZUUQ9CM2dYlBXe3961YNOQxGjnLFUGd1f/Hm8ExnGS24WA6ikieaTjpVc VV4+XQMWZa3wUnskaiuw= X-Received: by 2002:a05:6a00:234a:b0:625:ccea:1627 with SMTP id j10-20020a056a00234a00b00625ccea1627mr7607027pfj.5.1679301020806; Mon, 20 Mar 2023 01:30:20 -0700 (PDT) X-Google-Smtp-Source: AK7set8WHLvBBEkj0gTy5kGeGlp8HztTCLa3qCo3q5vvRgNQZuanctFIuWqcsD58OyugER0t38AZdvrxEOm4xsyNmQs= X-Received: by 2002:a05:6a00:234a:b0:625:ccea:1627 with SMTP id j10-20020a056a00234a00b00625ccea1627mr7607017pfj.5.1679301020505; Mon, 20 Mar 2023 01:30:20 -0700 (PDT) MIME-Version: 1.0 References: <20230223152840.634183-1-juraj.linkes@pantheon.tech> <20230303102507.527790-1-juraj.linkes@pantheon.tech> <20230303102507.527790-4-juraj.linkes@pantheon.tech> In-Reply-To: <20230303102507.527790-4-juraj.linkes@pantheon.tech> From: David Marchand Date: Mon, 20 Mar 2023 09:30:09 +0100 Message-ID: Subject: Re: [PATCH v6 03/10] dts: add dpdk build on sut To: =?UTF-8?Q?Juraj_Linke=C5=A1?= Cc: thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, lijuan.tu@intel.com, bruce.richardson@intel.com, probb@iol.unh.edu, dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Juraj, On Fri, Mar 3, 2023 at 11:25=E2=80=AFAM Juraj Linke=C5=A1 wrote: > +class MesonArgs(object): > + """ > + Aggregate the arguments needed to build DPDK: > + default_library: Default library type, Meson allows "shared", "stati= c" and "both". > + Defaults to None, in which case the argument won't be use= d. > + Keyword arguments: The arguments found in meson_options.txt in root = DPDK directory. > + Do not use -D with them, for example: > + meson_args =3D MesonArgs(enable_kmods=3DTrue). > + """ > + > + _default_library: str > + > + def __init__(self, default_library: str | None =3D None, **dpdk_args= : str | bool): > + self._default_library =3D ( > + f"--default-library=3D{default_library}" if default_library = else "" > + ) > + self._dpdk_args =3D " ".join( > + ( > + f"-D{dpdk_arg_name}=3D{dpdk_arg_value}" > + for dpdk_arg_name, dpdk_arg_value in dpdk_args.items() > + ) > + ) I am missing something here. Afair, meson accepts the -Ddefault_library form. Why do we need this special case? > + > + def __str__(self) -> str: > + return " ".join(f"{self._default_library} {self._dpdk_args}".spl= it()) > -- > 2.30.2 > --=20 David Marchand