From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3409A0527; Wed, 15 Jul 2020 15:28:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D20731BEB1; Wed, 15 Jul 2020 15:28:31 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 418821BEAA for ; Wed, 15 Jul 2020 15:28:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594819709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oyoLzRkgDNo/iPm1fKG4+RM2SRBg6gS1KhV9tcM2oGI=; b=M0pFDSIiH6KM+aBRLlIeeKtteXs06RGWD/qU7U7/eVnoVQS3o+S7ZCvNtOToyA8T3KxX2A Y6h57nGj7RmFk7j1AEkeTRB+NThsxQbiGDFDmfhDVmYj0xJDbz0XNB6566wVy9zteSGE1/ y5lyVIcAkoqFt/WcZ6ARNldI/vtLbOg= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-495-ujEyq0UYNLCQwQ7I7IdtXQ-1; Wed, 15 Jul 2020 09:28:27 -0400 X-MC-Unique: ujEyq0UYNLCQwQ7I7IdtXQ-1 Received: by mail-vk1-f199.google.com with SMTP id o62so764159vko.21 for ; Wed, 15 Jul 2020 06:28:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oyoLzRkgDNo/iPm1fKG4+RM2SRBg6gS1KhV9tcM2oGI=; b=ePdF05y1Qv7PitgRwCDXtitDvKWePRpny+So+fHXvY6R4ej85gB+aprzD4i0Uo+1tf jp97IndRUBpLof2OI+Clc38kYpJU9evkyHMsUajvClnJvdxNSrMwC7MYAiA1jPzsBxls 3IgEZJBV59X8TP3VQAPsl4lajy/cw3LDsaeObIjdlq+imiQqZ6XzP3sEn43mXYvsGEoc bpHo2gck34DrTORfMM/nLJ3cMsqEjjSs6Pqivx4qYIc27sOsg6dIFYqIG8pYgISwXsF+ sKwqRTImTC0U9OEm141uOAxavl++bZVGfnsCqSsjNDMOVIGvb1+iUG6xJfsgZvBEh/Q9 47hg== X-Gm-Message-State: AOAM5306fXFf16bxUrPKxGxjJ9cXJQ14RmZkMmxhYOZYRwmt/8pTzume ocwg+2Er5VkLWDLJNX5QN1IpULVvVvkJoJIFJv+OJNuSb3wxkzlXISFHBmI3dSv6aobGHVY09XJ /sNJN9K432nR07ql8nEs= X-Received: by 2002:a1f:acc2:: with SMTP id v185mr7822148vke.18.1594819706769; Wed, 15 Jul 2020 06:28:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJybR0OZhug2ZJKipZ2bjYWfzRfar1cljXtrintkpVCkwDmwFIstpl7DkVjLFdjUaWWAHdS0j02/M3XE3/ynPxc= X-Received: by 2002:a1f:acc2:: with SMTP id v185mr7822128vke.18.1594819706514; Wed, 15 Jul 2020 06:28:26 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Wed, 15 Jul 2020 15:28:15 +0200 Message-ID: To: Lukasz Wojciechowski Cc: Aaron Conole , Van Haaren Harry , Igor Romanov , Honnappa Nagarahalli , Phil Yang , dev X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] Random failure in service_autotest X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jul 15, 2020 at 3:09 PM Lukasz Wojciechowski wrote: > > > W dniu 15.07.2020 o 15:02, David Marchand pisze: > > On Wed, Jul 15, 2020 at 2:56 PM Aaron Conole wrote: > >> I guess the service_lcore_attr_get failed, but with no useful > Why do you suspect service_lcore_attr_get() ? https://travis-ci.com/github/ovsrobot/dpdk/jobs/361097992#L18697 RTE>>service_autotest + ------------------------------------------------------- + + Test Suite : service core test suite + ------------------------------------------------------- + + TestCase [ 0] : unregister_all succeeded + TestCase [ 1] : service_name succeeded + TestCase [ 2] : service_get_by_name succeeded Service dummy_service Summary dummy_service: stats 1 calls 0 cycles 0 avg: 0 Service dummy_service Summary dummy_service: stats 0 calls 0 cycles 0 avg: 0 + TestCase [ 3] : service_dump succeeded + TestCase [ 4] : service_attr_get succeeded *** + TestCase [ 5] : service_lcore_attr_get failed *** + TestCase [ 6] : service_probe_capability succeeded + TestCase [ 7] : service_start_stop succeeded + TestCase [ 8] : service_lcore_add_del skipped + TestCase [ 9] : service_lcore_start_stop succeeded + TestCase [10] : service_lcore_en_dis_able succeeded + TestCase [11] : service_mt_unsafe_poll skipped + TestCase [12] : service_mt_safe_poll skipped perf test for MT Safe: 56.9 cycles per call + TestCase [13] : service_app_lcore_mt_safe succeeded perf test for MT Unsafe: 83.4 cycles per call + TestCase [14] : service_app_lcore_mt_unsafe succeeded + TestCase [15] : service_may_be_active succeeded + TestCase [16] : service_active_two_cores skipped + ------------------------------------------------------- + > >> information. We should have the test suite app turn the log level all > >> the way up. I realize it will increase the log data even higher, but > >> without it, we have no idea why this test failed. > >> > >> Something like the following > >> --- > >> > >> diff --git a/app/test/test.c b/app/test/test.c > >> index 94d26ab1f6..c47cb075f9 100644 > >> --- a/app/test/test.c > >> +++ b/app/test/test.c > >> @@ -150,6 +150,9 @@ main(int argc, char **argv) > >> > >> prgname = argv[0]; > >> > >> + rte_log_set_global_level(RTE_LOG_DEBUG); > >> + rte_log_set_level(RTE_LOGTYPE_EAL, RTE_LOG_DEBUG); > >> + > >> recursive_call = getenv(RECURSIVE_ENV_VAR); > >> if (recursive_call != NULL) { > >> ret = do_recursive_call(); > >> --- > >> > >> That way we can at least debug when it happens. > > Debugging is one thing. > > But here service_lcore_attr_get() has a lot of asserts that should > > trigger a straight error. > > > Yes, but without debugs enabled, the assert message won't be printed out. Changing the whole debug levels could have side effects on the libraries being tested: maybe hide races (too bad) or reveal races (that would be interesting ;-)). On the other hand, what I am saying is that using debug level logs for test asserts might not be the best solution. -- David Marchand