* [dpdk-dev] [PATCH] eventdev: fix signed comparison
@ 2021-04-13 22:16 pbhagavatula
2021-04-14 6:26 ` David Marchand
0 siblings, 1 reply; 4+ messages in thread
From: pbhagavatula @ 2021-04-13 22:16 UTC (permalink / raw)
To: david.marchand, jerinj, Jay Jayatheerthan; +Cc: dev, Pavan Nikhilesh
From: Pavan Nikhilesh <pbhagavatula@marvell.com>
Since queue identifier is passed as signed integer, a compilation error
is generated:
rte_event_eth_rx_adapter.c:1810:57: error: signed and unsigned type
in conditional expression [-Werror=sign-compare]
Make queue identifier as unsigned when adding it to vector data.
Fixes: d7c428e557ba ("eventdev: support Rx adapter event vector")
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
lib/librte_eventdev/rte_event_eth_rx_adapter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
index e273b3acf..ca166a65f 100644
--- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
@@ -1790,7 +1790,7 @@ rxa_update_queue(struct rte_event_eth_rx_adapter *rx_adapter,
static void
rxa_set_vector_data(struct eth_rx_queue_info *queue_info, uint16_t vector_count,
- uint64_t vector_ns, struct rte_mempool *mp, int32_t qid,
+ uint64_t vector_ns, struct rte_mempool *mp, uint32_t qid,
uint16_t port_id)
{
#define NSEC2TICK(__ns, __freq) (((__ns) * (__freq)) / 1E9)
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] eventdev: fix signed comparison
2021-04-13 22:16 [dpdk-dev] [PATCH] eventdev: fix signed comparison pbhagavatula
@ 2021-04-14 6:26 ` David Marchand
2021-04-14 6:52 ` Jerin Jacob
0 siblings, 1 reply; 4+ messages in thread
From: David Marchand @ 2021-04-14 6:26 UTC (permalink / raw)
To: Pavan Nikhilesh, Jerin Jacob Kollanukkaran; +Cc: Jay Jayatheerthan, dev
On Wed, Apr 14, 2021 at 12:16 AM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Since queue identifier is passed as signed integer, a compilation error
> is generated:
> rte_event_eth_rx_adapter.c:1810:57: error: signed and unsigned type
> in conditional expression [-Werror=sign-compare]
> Make queue identifier as unsigned when adding it to vector data.
>
Bugzilla ID: 672
> Fixes: d7c428e557ba ("eventdev: support Rx adapter event vector")
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
LGTM and fixes compilation for RHEL7.
Acked-by: David Marchand <david.marchand@redhat.com>
Jerin, do you mind if I take it directly in main?
--
David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] eventdev: fix signed comparison
2021-04-14 6:26 ` David Marchand
@ 2021-04-14 6:52 ` Jerin Jacob
2021-04-14 8:06 ` David Marchand
0 siblings, 1 reply; 4+ messages in thread
From: Jerin Jacob @ 2021-04-14 6:52 UTC (permalink / raw)
To: David Marchand
Cc: Pavan Nikhilesh, Jerin Jacob Kollanukkaran, Jay Jayatheerthan, dev
On Wed, Apr 14, 2021 at 11:56 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Wed, Apr 14, 2021 at 12:16 AM <pbhagavatula@marvell.com> wrote:
> >
> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> > Since queue identifier is passed as signed integer, a compilation error
> > is generated:
> > rte_event_eth_rx_adapter.c:1810:57: error: signed and unsigned type
> > in conditional expression [-Werror=sign-compare]
> > Make queue identifier as unsigned when adding it to vector data.
> >
>
> Bugzilla ID: 672
>
> > Fixes: d7c428e557ba ("eventdev: support Rx adapter event vector")
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> LGTM and fixes compilation for RHEL7.
>
> Acked-by: David Marchand <david.marchand@redhat.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
>
> Jerin, do you mind if I take it directly in main?
Yes . Please
>
>
> --
> David Marchand
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] eventdev: fix signed comparison
2021-04-14 6:52 ` Jerin Jacob
@ 2021-04-14 8:06 ` David Marchand
0 siblings, 0 replies; 4+ messages in thread
From: David Marchand @ 2021-04-14 8:06 UTC (permalink / raw)
To: Pavan Nikhilesh; +Cc: Jerin Jacob Kollanukkaran, Jay Jayatheerthan, dev
On Wed, Apr 14, 2021 at 8:52 AM Jerin Jacob <jerinjacobk@gmail.com> wrote:
>
> On Wed, Apr 14, 2021 at 11:56 AM David Marchand
> <david.marchand@redhat.com> wrote:
> >
> > On Wed, Apr 14, 2021 at 12:16 AM <pbhagavatula@marvell.com> wrote:
> > >
> > > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > >
> > > Since queue identifier is passed as signed integer, a compilation error
> > > is generated:
> > > rte_event_eth_rx_adapter.c:1810:57: error: signed and unsigned type
> > > in conditional expression [-Werror=sign-compare]
> > > Make queue identifier as unsigned when adding it to vector data.
> > >
> >
> > Bugzilla ID: 672
> > > Fixes: d7c428e557ba ("eventdev: support Rx adapter event vector")
> > >
> > > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > Acked-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Jerin Jacob <jerinj@marvell.com>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-14 8:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-13 22:16 [dpdk-dev] [PATCH] eventdev: fix signed comparison pbhagavatula
2021-04-14 6:26 ` David Marchand
2021-04-14 6:52 ` Jerin Jacob
2021-04-14 8:06 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).