From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED39842606; Thu, 21 Sep 2023 15:26:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8FFDD402D2; Thu, 21 Sep 2023 15:26:54 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 43021402C5 for ; Thu, 21 Sep 2023 15:26:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695302812; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6yiLVLEpEqk4DC9/1v477mb9SXhehzr8Y279Xt6Tngw=; b=cqFDzVHFA4oYLBbd/AP+X/GEIW4mh0YuXacmvQUoVgWgVX5TkSi0qlRdZSJb7Z+/Me7bey XRm46AOwSG423hgoSLimV35S+E+553nDdDCSKZoW1akgVowsG6B9wDaKpUyfnSS8wwihBL 8BYUW5FYbV6lnbN0oAg0idwTAjIgoH4= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-690-q3YdulswN3Ox_MexqCD-Ew-1; Thu, 21 Sep 2023 09:26:51 -0400 X-MC-Unique: q3YdulswN3Ox_MexqCD-Ew-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2c129cb765bso11215031fa.2 for ; Thu, 21 Sep 2023 06:26:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695302808; x=1695907608; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6yiLVLEpEqk4DC9/1v477mb9SXhehzr8Y279Xt6Tngw=; b=QMzrEMsLx3hxBKvpLLEiu669tOeuVmwJQOhOqsNDrhKP0XZLn6PL0A+Zcjr7SsUm5n Ty8XAZkIrempssj8VzT98kcuZwFWkG2PitzerajTpghWbQhaK683RFrEBnr5gzaxX7pU lhUMYOjYFw0tl+5kCByZXESwIG3vwYx8/h/OqGO2chY2HLg5Te4G9MKSQT6g0nX+o22f Zl3EiMZcTDkihYkcByJWVrDPW7SEN80P2osq/cFWV0nc6n96u8pGBFgahLqVwcy5Ucu5 WbqeOZEx17LdJLzY+HPKwT1b10KDM1RPGUT2VG5JeujV2vPZmuHfr+kxntaAYNyHZFkN Q1lw== X-Gm-Message-State: AOJu0Ywj8SrtJGjTi6Hql69BpqfTl4ntMrBkAGfrXuRlWGOukRKEJRgD HHhFmPPuHPmjCVdfBmKXowIzuy1NTIi/3/ARbMj0xtNzTskWqsrAmTSe9YiYRVwicX+wEIscHGl qA9nlMHQ7z1YRQe2w1w0= X-Received: by 2002:a2e:9189:0:b0:2c0:20e3:990f with SMTP id f9-20020a2e9189000000b002c020e3990fmr4823494ljg.10.1695302808158; Thu, 21 Sep 2023 06:26:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGDkC4FH/VRXo68MyAUHzpRCPsDKS4szi2ddCDZqHx4i2tBHWdvR5aqpDUy9GcP2wrLqSXcPRAjckMp/OQcldo= X-Received: by 2002:a2e:9189:0:b0:2c0:20e3:990f with SMTP id f9-20020a2e9189000000b002c020e3990fmr4823483ljg.10.1695302807831; Thu, 21 Sep 2023 06:26:47 -0700 (PDT) MIME-Version: 1.0 References: <20230830155927.3566-1-syalavarthi@marvell.com> <20230830155927.3566-3-syalavarthi@marvell.com> In-Reply-To: From: David Marchand Date: Thu, 21 Sep 2023 15:26:36 +0200 Message-ID: Subject: Re: [EXT] Re: [PATCH v1 02/34] ml/cnxk: drop use of RTE API for firmware read To: Srikanth Yalavarthi Cc: Jerin Jacob , Prince Takkar , "dev@dpdk.org" , Shivah Shankar Shankar Narayan Rao , Anup Prabhu X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Sep 21, 2023 at 3:06=E2=80=AFPM Srikanth Yalavarthi wrote: > > > > archive. This causes the ML firmware binary to be parsed > > > > incorrectly. > > > > > > + @David Marchand rte_firmware_read() author for his opinions > > > > /lib/firmware/mlip-fw.bin does not seem to be something packaged in > > Fedora, and I found no trace in linux-firmware repo, so I can't reprodu= ce > > your issue. > > > > Please add some debug and give more details about the issue you are fac= ing. > > The "/lib/firmware/mlip-fw.bin" is Marvell's ML firmware binary. This fil= e is in un-compressed form. > > When DPDK is built without libarchive support, No issues are observed wit= h using rte_firmware_read to load the firmware file as open and read syste= m calls are used. > > When libarchive support is enabled, rte_firmware_read tries to parse the = firmware binary as an xz archive. Since the file is not an archive, this st= ep is failing. Please debug this part and point at the exact place where it fails. > > Hence, added new ML driver function to read the firmware binary. This is just avoiding the issue without understanding it... --=20 David Marchand