From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7EA7CA0350; Thu, 27 Jan 2022 09:09:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 70BF540E28; Thu, 27 Jan 2022 09:09:32 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id DD6584067C for ; Thu, 27 Jan 2022 09:09:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643270970; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PbWUsu8t8CrLRwNfSxn3h4Q7y7SUx5Flm2s8qcJkm+c=; b=bfbU0E2+4PezrNEuk3oMifzzUmEgrBJHY14SBcSRDzhBm8BQLHjg680m6BLdfL+YZGNvdL GiqaXhPYiOypcpJI9GBpoVuky8k2/4yj6ALEqP5zrVcd3j+kKF/ARk0JRSoAdDhytsA4pi kPoorJbhY9ZEZMFLX4NWEV93B/zjqSY= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-370-B9PCZ-xoMD-ChqiNWUW4Mw-1; Thu, 27 Jan 2022 03:09:29 -0500 X-MC-Unique: B9PCZ-xoMD-ChqiNWUW4Mw-1 Received: by mail-lj1-f199.google.com with SMTP id u4-20020a2e8544000000b0023aeea9107dso802932ljj.21 for ; Thu, 27 Jan 2022 00:09:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PbWUsu8t8CrLRwNfSxn3h4Q7y7SUx5Flm2s8qcJkm+c=; b=gu7cB5F19r99XdHPUcJoHerDCicqOO3pbTroIqxkNaCKZSQgMtnf3OYGOwHPU8F/PV gmXth9PIFIjB4P65ULoC6FNDnImZfXBVHN/TU6hPFSlDpXinKZueHqqeXnusMN8NewcW 3BiujM7iNwMdcfZqCJEzNbrldgTuHmCyGDbtoTQ+11Yssyl0yHUCMWk1WGW022QX6F19 6mb9WlHIQ9RxrLbcMEXmz/8q7YzIfTkw2O0Ov+Cz542TypJkIVyr+ebYujX6NuLSCaa+ pGk4tbLt+YhKEJ7GLrsiCv6E0hBeE3bilsEOStj9K4sXCFxeatOj4YXSoGznPcLi0l3X 4J7Q== X-Gm-Message-State: AOAM5309PjepWDU5jcpk905Q5re6LSLm/2IXQMGBlLZE6VZgpMdhLFz2 s4SrA10MANzubuaKmH2kICR/ZZzDt7t5kTAb3i3YitjbpI0TvQpDMGTAx+3wMjIoLJnMzicQyw3 yUb/sizVgzA82V6EIU84= X-Received: by 2002:a2e:5848:: with SMTP id x8mr1987545ljd.297.1643270967634; Thu, 27 Jan 2022 00:09:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJyclf68roFq9H7ud7fN8Sme9PH10Yt4tjWGT/78hvOTYCC2WbuzWE4W39rj23cXG8fUgk2NLX4z7Jcgutmlqps= X-Received: by 2002:a2e:5848:: with SMTP id x8mr1987532ljd.297.1643270967438; Thu, 27 Jan 2022 00:09:27 -0800 (PST) MIME-Version: 1.0 References: <20220126095510.389566-1-maxime.coquelin@redhat.com> In-Reply-To: From: David Marchand Date: Thu, 27 Jan 2022 09:09:16 +0100 Message-ID: Subject: Re: [PATCH v3 0/9] vhost: improve logging To: "Xia, Chenbo" Cc: Maxime Coquelin , "dev@dpdk.org" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jan 27, 2022 at 6:37 AM Xia, Chenbo wrote: > > From: Maxime Coquelin > > > > This series aims at easing Vhost logs analysis, by > > prepending the Vhost-user socket path to all logs and to > > remove multi-line comments. Doing so, filtering Vhost-user > > ports logs is much easier. > > > > Changes in v3: > > ============== > > - Fix various typos reported (Chenbo) > > - Revert one multi-line comment removal (Chenbo) > > > > Changes in v2: > > ============== > > - Add missing socket paths (David) > > - avoid identical logs in iotlb code (David) > > - Use data log type when used in datapath (David) > > > > Maxime Coquelin (9): > > vhost: improve IOTLB logs > > vhost: improve vDPA registration failure log > > vhost: improve Vhost layer logs > > vhost: improve Vhost-user layer logs > > vhost: improve socket layer logs > > vhost: improve Virtio-net layer logs > > vhost: remove multi-line logs > > vhost: differentiate IOTLB logs > > vhost: use proper logging type for data path > > > > lib/vhost/iotlb.c | 30 +- > > lib/vhost/iotlb.h | 10 +- > > lib/vhost/socket.c | 148 ++++----- > > lib/vhost/vdpa.c | 4 +- > > lib/vhost/vhost.c | 108 ++++--- > > lib/vhost/vhost_user.c | 678 ++++++++++++++++++++--------------------- > > lib/vhost/vhost_user.h | 4 +- > > lib/vhost/virtio_net.c | 165 +++++----- > > 8 files changed, 548 insertions(+), 599 deletions(-) > > > > -- > > 2.34.1 > > Series applied to next-virtio/main, thanks For the series: Reviewed-by: David Marchand -- David Marchand