From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E5574310C; Sat, 26 Aug 2023 10:33:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3844440E6E; Sat, 26 Aug 2023 10:33:54 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 7005D4068E for ; Sat, 26 Aug 2023 10:33:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1693038832; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iJWjRL/V+kCeO0qXOKztrjGQJ7UmKiPn5tkgS8PBwpY=; b=gi+SP5iUSw0I88Rc+yR5OCLtv1AfXDjyP2JrIW8c+Z/PehkVQvsXk/qbs24LLaMS4Di1P2 PSSAQfi/mKyJO3d452ctD9jkJbPYwIfRc9m5qMKciAxU0DHDuK2PlV6Xsq+O3kDGqrMApn Qx4jeJM4J6Fp7fXXAn0aq11UT9YHbb8= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-592-OXfLdiaYNke91LX7sqq4Uw-1; Sat, 26 Aug 2023 04:33:51 -0400 X-MC-Unique: OXfLdiaYNke91LX7sqq4Uw-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-5007ac1c653so1890898e87.2 for ; Sat, 26 Aug 2023 01:33:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693038830; x=1693643630; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iJWjRL/V+kCeO0qXOKztrjGQJ7UmKiPn5tkgS8PBwpY=; b=Cn3zFsNJw9swSLZjiQFH/DyZqo8XkWY67tYbHQ2aQ6amLhsI6/Gc1j0dDHoFtB7reh /WVGW+yDY9KhqdultoJYJvX/WLHSmiJgbS/5mRLBQ7/tT2hsVeVkRBRpckhIpSruDlvY hrec7p8NyCnKF4rKOTIbGwHYqeD0yVfh5yrgTgZ06BnlfoBHLtcUqcW7KpKCF3dqumRr G8EKnmPAJIK8G3eYnCZaEQK4aYlEYZs2YVLcRMJ5qxqTPiK7ByIY1Kujt2X7jTXjbaej ZSragnPZ0xHYiWKb1UuVab7hxpdMrFNWTTktQ9IrjrOaSwefv+fXuBZe7SOgAcNh7564 Vjaw== X-Gm-Message-State: AOJu0Yzu4GtPRcVvWt9/wtyGpWbKcuNLCGQT4QknLv1eCg3KgDNUbBfP 3it0r75ZASac3uTXaaIaqwxKCE3V+wmQIMOlFVlwJRsb9a19LsZopAv3tuIUIL9cv09crWpDSym 07Dd0+Wl/a8q7gIyqzjg= X-Received: by 2002:a05:6512:12c4:b0:4fb:9712:a717 with SMTP id p4-20020a05651212c400b004fb9712a717mr16271898lfg.13.1693038829921; Sat, 26 Aug 2023 01:33:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHuGe1/d3xa0TXLMGYr4zocct7m7g3mwCPJTlFsRZLviV0OdJq0n/4FxBJMYC72azHVHJ8uhqgvxbc3ISwuNGg= X-Received: by 2002:a05:6512:12c4:b0:4fb:9712:a717 with SMTP id p4-20020a05651212c400b004fb9712a717mr16271892lfg.13.1693038829620; Sat, 26 Aug 2023 01:33:49 -0700 (PDT) MIME-Version: 1.0 References: <20230824083034.806773-1-david.marchand@redhat.com> <20230825161429.GB18422@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20230825161429.GB18422@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: David Marchand Date: Sat, 26 Aug 2023 10:33:28 +0200 Message-ID: Subject: Re: [PATCH] remove wrappers for GCC < 4.8 To: Tyler Retzlaff Cc: dev@dpdk.org, Ruifeng Wang , David Christensen , Bruce Richardson , Konstantin Ananyev X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Aug 25, 2023 at 6:14=E2=80=AFPM Tyler Retzlaff wrote: > On Thu, Aug 24, 2023 at 10:52:04AM +0200, David Marchand wrote: > > Hello Tyler, > > > > On Thu, Aug 24, 2023 at 10:30=E2=80=AFAM David Marchand > > wrote: > > > diff --git a/lib/eal/include/rte_debug.h b/lib/eal/include/rte_debug.= h > > > index 2c4b94a7c9..74593cd4d4 100644 > > > --- a/lib/eal/include/rte_debug.h > > > +++ b/lib/eal/include/rte_debug.h > > > @@ -60,11 +60,7 @@ void rte_dump_stack(void); > > > * documentation. > > > */ > > > void __rte_panic(const char *funcname , const char *format, ...) > > > -#ifdef __GNUC__ > > > -#if (__GNUC__ > 4 || (__GNUC__ =3D=3D 4 && __GNUC_MINOR__ > 2)) > > > __rte_cold > > > -#endif > > > -#endif > > > > I don't see some wrapping around __rte_cold for MSVC in your series. > > Would this patch break MSVC buidlds? > > If it gets expanded on MSVC probably. But don't let it stop you from > applying this series. You can just expand it empty if you want. That's what I did for safety when I applied the msvc series. > > Until the atomics series is merged msvc still won't build so I'll supply > minor fixes as these things pop up. > > Once everything is staged I'll work with UNH to get a basic build CI > going to reduce the overhead of worrying about this kind of change being > breaking. Yes, the sooner, the better. --=20 David Marchand