From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dmarchan@redhat.com>
Received: from mail-vk1-f194.google.com (mail-vk1-f194.google.com
 [209.85.221.194]) by dpdk.org (Postfix) with ESMTP id 7FDFE1B480
 for <dev@dpdk.org>; Thu, 14 Feb 2019 18:45:43 +0100 (CET)
Received: by mail-vk1-f194.google.com with SMTP id l136so1597815vke.2
 for <dev@dpdk.org>; Thu, 14 Feb 2019 09:45:43 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=4MNXqE75a6DTRO+HjYDPFC76TA97d7LktrgynRPL8xs=;
 b=SDjHhPU1DhtiVtNGHUy3XaYPQwJ/lfHr1oz+K0+1gSmqdDlcuWN7mlSIDlWytGQsd9
 4b0H1h/JIPLhw+Mure5KPrCyj8tNys2a3za9lnbwUw2aieJy0DAxoDz8WR9Ram9oEcpq
 uOIUhr1SsnkpV5HrmsrjZngUczguLpz6ft+LoA0GdJ83RXXqUANgK1piBK8cK61XOTuN
 KXvO1pf87KR0vm8HPz/9udnj2vkFzEqPusaCN+DeIZLargL3pRPWQfZWy5TCQmGwFViD
 rOa3wd3HSGDv4PoC+3Nx3/++LT08EyIuSWOZXyxH+KFIwbONEqiEAKZGBEYKbCfK95D5
 2ASw==
X-Gm-Message-State: AHQUAuaH2m/fMYDlAbUmXbDdJzRbsCda6Y+zDZfUFXvbBfdhDg6dQqXc
 00NTuRaRXRNlf7UElNB8ff2V7kOhGms6maMldTcE9g==
X-Google-Smtp-Source: AHgI3IZ/8cbV45eL32Va5Z1uRZD2ZO2KZEiEGGv6lCBCoTm5FE5Xai0yasr64UtPMM3S8PD2zaFsjKNChtig2JRk214=
X-Received: by 2002:a1f:35f:: with SMTP id 92mr2629970vkd.52.1550166342824;
 Thu, 14 Feb 2019 09:45:42 -0800 (PST)
MIME-Version: 1.0
References: <1550074412-31285-1-git-send-email-david.marchand@redhat.com>
 <1550151042-9764-1-git-send-email-david.marchand@redhat.com>
 <32bd2385-b979-12f8-26ef-e03e28e53462@intel.com>
In-Reply-To: <32bd2385-b979-12f8-26ef-e03e28e53462@intel.com>
From: David Marchand <david.marchand@redhat.com>
Date: Thu, 14 Feb 2019 18:45:32 +0100
Message-ID: <CAJFAV8wYLDCR_NL4gByXy5SjAbctedDZ-LBDyq=FK06wji2a5A@mail.gmail.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, Olivier Matz <olivier.matz@6wind.com>, 
 Kevin Traynor <ktraynor@redhat.com>, dpdk stable <stable@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v2 1/2] eal: fix potential incorrect pinning
	for ctrl threads
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Feb 2019 17:45:43 -0000

On Thu, Feb 14, 2019 at 5:12 PM Burakov, Anatoly <anatoly.burakov@intel.com>
wrote:

> On 14-Feb-19 1:30 PM, David Marchand wrote:
> > pthread_setaffinity_np returns a >0 value on error.
> > We could end up letting the ctrl threads on the current process cpu
> > affinity.
> >
> > Fixes: d651ee4919cd ("eal: set affinity for control threads")
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> >   lib/librte_eal/common/eal_common_thread.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/librte_eal/common/eal_common_thread.c
> b/lib/librte_eal/common/eal_common_thread.c
> > index 48ef4d6..a3985ce 100644
> > --- a/lib/librte_eal/common/eal_common_thread.c
> > +++ b/lib/librte_eal/common/eal_common_thread.c
> > @@ -209,7 +209,7 @@ static void *rte_thread_init(void *arg)
> >               CPU_SET(rte_get_master_lcore(), &cpuset);
> >
> >       ret = pthread_setaffinity_np(*thread, sizeof(cpuset), &cpuset);
> > -     if (ret < 0)
> > +     if (ret)
> >               goto fail;
> >
> >       ret = pthread_barrier_wait(&params->configured);
> >
>
> CC: stable?
>

Yes, I again forgot to check with check-git-log.sh...


-- 
David Marchand