DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] dpdk-devbind: fix indentation
@ 2024-07-01 17:45 Stephen Hemminger
  2024-07-02 11:57 ` Robin Jarry
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2024-07-01 17:45 UTC (permalink / raw)
  To: dev; +Cc: Stephen Hemminger, Robin Jarry, Radha Mohan Chintakuntla

The python check tool (flake8) is picky about the indentation
of continuation lines, and dpdk-devbind was not following standard.

Error is:
	 E127 continuation line over-indented for visual indent

Fixes: 2ff801515e49 ("usertools/devbind: update octeontx2 DMA device")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 usertools/dpdk-devbind.py | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
index a278f5e7f3..5dc42d8fe2 100755
--- a/usertools/dpdk-devbind.py
+++ b/usertools/dpdk-devbind.py
@@ -66,17 +66,17 @@
                  'SVendor': None, 'SDevice': None}
 
 cnxk_sso = {'Class': '08', 'Vendor': '177d', 'Device': 'a0f9,a0fa',
-                 'SVendor': None, 'SDevice': None}
+            'SVendor': None, 'SDevice': None}
 cnxk_npa = {'Class': '08', 'Vendor': '177d', 'Device': 'a0fb,a0fc',
-                 'SVendor': None, 'SDevice': None}
+            'SVendor': None, 'SDevice': None}
 cn9k_ree = {'Class': '08', 'Vendor': '177d', 'Device': 'a0f4',
-                 'SVendor': None, 'SDevice': None}
+            'SVendor': None, 'SDevice': None}
 
 virtio_blk = {'Class': '01', 'Vendor': "1af4", 'Device': '1001,1042',
-                    'SVendor': None, 'SDevice': None}
+              'SVendor': None, 'SDevice': None}
 
 cnxk_ml = {'Class': '08', 'Vendor': '177d', 'Device': 'a092',
-            'SVendor': None, 'SDevice': None}
+           'SVendor': None, 'SDevice': None}
 
 network_devices = [network_class, cavium_pkx, avp_vnic, ifpga_class]
 baseband_devices = [acceleration_class]
-- 
2.43.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dpdk-devbind: fix indentation
  2024-07-01 17:45 [PATCH] dpdk-devbind: fix indentation Stephen Hemminger
@ 2024-07-02 11:57 ` Robin Jarry
  2024-07-09  4:49   ` David Marchand
  0 siblings, 1 reply; 3+ messages in thread
From: Robin Jarry @ 2024-07-02 11:57 UTC (permalink / raw)
  To: Stephen Hemminger, dev; +Cc: Radha Mohan Chintakuntla

Stephen Hemminger, Jul 01, 2024 at 19:45:
> The python check tool (flake8) is picky about the indentation
> of continuation lines, and dpdk-devbind was not following standard.
>
> Error is:
> 	 E127 continuation line over-indented for visual indent
>
> Fixes: 2ff801515e49 ("usertools/devbind: update octeontx2 DMA device")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---

Acked-by: Robin Jarry <rjarry@redhat.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dpdk-devbind: fix indentation
  2024-07-02 11:57 ` Robin Jarry
@ 2024-07-09  4:49   ` David Marchand
  0 siblings, 0 replies; 3+ messages in thread
From: David Marchand @ 2024-07-09  4:49 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: dev, Radha Mohan Chintakuntla, Robin Jarry

On Tue, Jul 2, 2024 at 1:58 PM Robin Jarry <rjarry@redhat.com> wrote:
>
> Stephen Hemminger, Jul 01, 2024 at 19:45:
> > The python check tool (flake8) is picky about the indentation
> > of continuation lines, and dpdk-devbind was not following standard.
> >
> > Error is:
> >        E127 continuation line over-indented for visual indent
> >
> > Fixes: 2ff801515e49 ("usertools/devbind: update octeontx2 DMA device")
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Acked-by: Robin Jarry <rjarry@redhat.com>

Applied, thanks.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-07-09  4:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-01 17:45 [PATCH] dpdk-devbind: fix indentation Stephen Hemminger
2024-07-02 11:57 ` Robin Jarry
2024-07-09  4:49   ` David Marchand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).