From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F3E843D66; Wed, 27 Mar 2024 11:04:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 46FD1410D5; Wed, 27 Mar 2024 11:04:31 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 73CFB4029F for ; Wed, 27 Mar 2024 11:04:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711533859; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XTN+j+bqzu7UmHLkV/xKObojtGteZngbeJhRKBqBqzs=; b=izRrdxM4QPewN3+CMF39QpzLPQe96n9C43AQeKgUHx41BX63tw+d3CaxN3oyEwCJ1UNAYE kEbZZvb9DDZl9ByuczspFoCohnc3C0vjAxqwE1vhOm1w+VefAfB8gQUCHQM3XxE0u0e/a7 yMU9wFDDEwr5CQ7fPX/7E8k+QxekSk4= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-48-d_eCxMN_NrOxZPmuv8wAnA-1; Wed, 27 Mar 2024 06:04:15 -0400 X-MC-Unique: d_eCxMN_NrOxZPmuv8wAnA-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-515af96a73bso2106961e87.2 for ; Wed, 27 Mar 2024 03:04:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711533854; x=1712138654; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XTN+j+bqzu7UmHLkV/xKObojtGteZngbeJhRKBqBqzs=; b=FTDpQZ31ynTFyqYL53HH4eEQO47YwR4/Xyl90P46SWpuCi5hktQqc8V8Hr/yQ4VcEv AHZ2q1Xlpl6Q8ksighULP3yrJsg0O9uSS0zodh2L/X+0CEeicoeVjOAg/v2zzeU3t22x /9P1so2Q+A5vVEowul/ja1MfI9afepZWEy+RM8tFJufNE7O/nBdCDkSDIRAW3em+KGsR mFyiHAUI7cA3pFHO7FtYFYJSRtK/zSbEzFPyHIicDPxnQIXH7r4Zv/OXN9eRWke99XXW XgDYIjhoD4pOKVaYy4SDAD5d9u6YWybSV/3jIjuqrDb2g6yZF9niFZ8HSDYe+8qy3fQA 0Yww== X-Gm-Message-State: AOJu0Yw5anhRQ31NbtlIMlS4CEtNbGVKwiDYEVfUMVW9N6qC8Y/tgxAF 6r+qanUaff2MI4pmagaKbwC7ho42AuDk5sksS38e4E55ufMUn9vjnTtAKTWdD0bruPFhBmLbRU2 ZR6ltmexXHduph9TtKSyC+ltPW9gaMzUAoNuTkzqEaOl1avqLJ6BmxrEoUxWU+c0KB7Ea4oUGEK aihVo3qV3+gz9wAfc= X-Received: by 2002:a2e:9c92:0:b0:2d6:9e7a:1524 with SMTP id x18-20020a2e9c92000000b002d69e7a1524mr1307592lji.13.1711533853936; Wed, 27 Mar 2024 03:04:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHcLq04SWnxSHGsXgCTD0GbqFJewl9ry2gY0+gSo1nG13w9vRRir+O0rl2NEdE2OzsfvNM4906BL6KKiXg26YI= X-Received: by 2002:a2e:9c92:0:b0:2d6:9e7a:1524 with SMTP id x18-20020a2e9c92000000b002d69e7a1524mr1307574lji.13.1711533853521; Wed, 27 Mar 2024 03:04:13 -0700 (PDT) MIME-Version: 1.0 References: <20240327094032.2400951-1-maxime.coquelin@redhat.com> In-Reply-To: <20240327094032.2400951-1-maxime.coquelin@redhat.com> From: David Marchand Date: Wed, 27 Mar 2024 11:04:01 +0100 Message-ID: Subject: Re: [PATCH 0/4] Virtio-user queues setup fixes To: Maxime Coquelin Cc: dev@dpdk.org, chenbox@nvidia.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Maxime, On Wed, Mar 27, 2024 at 10:40=E2=80=AFAM Maxime Coquelin wrote: > > This series aims at fixing several issues found in > Virtio-user PMD related to queues setup and cleanup. > > It has been tested with Vhost-vDPA backend using Nvidia > Cx6-Dx vDPA VF. > > First patch in the series renames the queues iterator > helper, so it is not a fix. But I would suggest to have it > backported to ease backporting of the fixes. > > Maxime Coquelin (4): > net/virtio: rename Virtio-user queue iterator > net/virtio: use iterator to destroy Virtio-user queues > net/virtio: fix shadow control queue notification init > net/virtio: fix shadow control queue allocation > > .../net/virtio/virtio_user/virtio_user_dev.c | 132 +++++++++--------- > 1 file changed, 67 insertions(+), 65 deletions(-) I would prefix those titles with net/virtio-user: as was done in the past. This will show the changes only affect virtio-user. For patch 2, it is better to highlight the functional change/fix in the title, so something like: net/virtio-user: fix control queue destruction With this fixed, you can add on the series: Acked-by: David Marchand --=20 David Marchand