From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 24185A00E6
	for <public@inbox.dpdk.org>; Fri, 17 May 2019 10:16:40 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id E17A52BBD;
	Fri, 17 May 2019 10:16:39 +0200 (CEST)
Received: from mail-vs1-f67.google.com (mail-vs1-f67.google.com
 [209.85.217.67]) by dpdk.org (Postfix) with ESMTP id 2645A2BBD
 for <dev@dpdk.org>; Fri, 17 May 2019 10:16:39 +0200 (CEST)
Received: by mail-vs1-f67.google.com with SMTP id o5so4095986vsq.4
 for <dev@dpdk.org>; Fri, 17 May 2019 01:16:39 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=vvpogwqmOpEPA3adRYRktoG3dnzxgj95J/aMs/B6Tlo=;
 b=fclBeHFoecznOe+EA4Q4cSVJ8l+HCqbTZKSjGfMBAJUC+2lx2/idZj2jKIbylzWzlX
 Mzl6NSbDch83CZtiLq2Kux7Yzwk7M9AxUPhJe7T0ZNFssjnFcrYVyiIHUfNEv3vqu9CI
 QDxfD7rxdEvQ+q0NKQqtZBjJ6kQTZoNu+ilYQhyKOCt2bWZRTGYyqyyNGiJEtMDYClVL
 G5UbV0niHNJXypdKDHt2JJLsV1DGki5/Fv8cgd68Zhl1oLVsWiE6msaCGJxGq21Ok715
 tbLp/oE1nuLA8medj4/oQQc7957unOJqoEtFhzsx0vHETFxt1sxPKgTIePOWfaEcEnMQ
 5OrQ==
X-Gm-Message-State: APjAAAX1mdK5uZKyWMMY/DqvU1cRwbaWn+sNSP8yVFynDdfXWZKgcFt2
 sh2RtQg/+PAvcYHITUHAe93rYLdPIeIbDbBDXXPkiQ==
X-Google-Smtp-Source: APXvYqx8YPkEgEiy4MEGN87cciPB83pF/Gkblq9YaPfAi6xlQ/uzij4vZ2p0GVW8MPogWv428Pq3q076eutkP3zNHGs=
X-Received: by 2002:a67:61c6:: with SMTP id
 v189mr10462123vsb.198.1558080998601; 
 Fri, 17 May 2019 01:16:38 -0700 (PDT)
MIME-Version: 1.0
References: <1557389028-2462-1-git-send-email-david.marchand@redhat.com>
 <20190509132901.nvcvz374pi53mnip@jenstp.localdomain>
In-Reply-To: <20190509132901.nvcvz374pi53mnip@jenstp.localdomain>
From: David Marchand <david.marchand@redhat.com>
Date: Fri, 17 May 2019 10:16:27 +0200
Message-ID: <CAJFAV8wYzaCx6M9ZjEcpLthmVqcHjjEpdwESfNh_Q+RNHQx3iA@mail.gmail.com>
To: Jens Freimann <jfreimann@redhat.com>
Cc: dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>, 
 Maxime Coquelin <maxime.coquelin@redhat.com>, Tiwei Bie <tiwei.bie@intel.com>, 
 Zhihong Wang <zhihong.wang@intel.com>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH] net/virtio: remove useless check on mempool
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, May 9, 2019 at 3:29 PM Jens Freimann <jfreimann@redhat.com> wrote:

> On Thu, May 09, 2019 at 10:03:48AM +0200, David Marchand wrote:
> >This .rx_queue_setup devop is called after ethdev already dereferenced
> >the mempool pointer.
> >No need to check and we can remove this rte_exit.
> >
> >Fixes: 48cec290a3d2 ("net/virtio: move queue configure code to proper
> place")
> >Cc: stable@dpdk.org
> >
> >Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> Agree, the pointer is accessed before in the caller. That said, afaics the
> pointer is never checked in rte_eth_rx_queue_setup() before it's
> dereferenced...
>

Yep, sent a patch.
http://patchwork.dpdk.org/patch/53503/

Thanks for the review Jens.


-- 
David Marchand