DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: dev <dev@dpdk.org>, Anatoly Burakov <anatoly.burakov@intel.com>
Cc: Owen Hilyard <ohilyard@iol.unh.edu>,
	dpdk stable <stable@dpdk.org>,  Qi Zhang <qi.z.zhang@intel.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] ipc: stop mp control thread on cleanup
Date: Wed, 16 Jun 2021 10:34:45 +0200	[thread overview]
Message-ID: <CAJFAV8wZ71KravYKfrftBavGp0wT1ftxP71ZVPUmOYumS8Hr+g@mail.gmail.com> (raw)
In-Reply-To: <20210614091213.3953-1-david.marchand@redhat.com>

On Mon, Jun 14, 2021 at 11:13 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> When calling rte_eal_cleanup, the mp channel cleanup routine only sets
> mp_fd to -1 leaving the rte_mp_handle control thread running.
> This control thread can spew warnings on reading on an invalid fd.
>
> To handle this situation, sets mp_fd to -1 to signal the control thread
> it should exit, but since this thread might be sleeping on the socket,
> cancel the thread too.
>
> Fixes: 85d6815fa6d0 ("eal: close multi-process socket during cleanup")
> Cc: stable@dpdk.org
>

Reported-by: Owen Hilyard <ohilyard@iol.unh.edu>

> Signed-off-by: David Marchand <david.marchand@redhat.com>

Anatoly, review please.


-- 
David Marchand


  reply	other threads:[~2021-06-16  8:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-14  9:12 [dpdk-dev] " David Marchand
2021-06-16  8:34 ` David Marchand [this message]
2021-07-07 11:02 ` [dpdk-dev] [PATCH v2] " David Marchand
2021-07-08  7:23   ` Maxime Coquelin
2021-07-08  9:54     ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8wZ71KravYKfrftBavGp0wT1ftxP71ZVPUmOYumS8Hr+g@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=ohilyard@iol.unh.edu \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).