From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35A64A054D; Thu, 18 Feb 2021 12:14:19 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ACFF9160727; Thu, 18 Feb 2021 12:14:18 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id 04FAE160724 for ; Thu, 18 Feb 2021 12:14:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613646857; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hhv3o2+NB+lWK708reEQ7KNmFPt5DmU9aDK5+g1YmWY=; b=ZPWAwvSAnn3MsC01H939nMT7PgV1NPNWFhCq5aw804JSvkHQ0owS2Q59RzCO6ku5mp8SEd oCHnInvMXs5bLSbScYYicsHfNyxWQgBUn15xG4RhExyi0D+WWKB/uppTpBxriq4paS0x/+ NOIj0PfJ0QnMddz0IK+zuw6KeX35cyg= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-496-3dRHx-AeMR2fMncvCjCssw-1; Thu, 18 Feb 2021 06:14:15 -0500 X-MC-Unique: 3dRHx-AeMR2fMncvCjCssw-1 Received: by mail-ua1-f71.google.com with SMTP id a19so750391uak.21 for ; Thu, 18 Feb 2021 03:14:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hhv3o2+NB+lWK708reEQ7KNmFPt5DmU9aDK5+g1YmWY=; b=sy6kHlOuKpDxpElo0rfUT1CW/RuD5qC8ucmYGTM90qXmKJsynqtCFIpdLATkpF1KMZ WOcxzyR+OscWiewL9MhYP0hUqH3Wl1xbuhvdWE9ilHzpiKhSrDciHebJvi2sPRKs8W8f Xjgs1MaCEOEMo0Z3DxdlW4xFMef5Gong31HHu1zJup4Dc0I08RXM2gwVvbOGuzHe9Ghs zhArnJbovSumhMlf/oo7ptvQ0ZqCXCxZTgN22BZU4aDd4iMU4c7EHLAduR0OZGFY/Xth +PRBaB8BDbn/plVKTD0cFRmuMigcVTxZgFg3paUZwuCk4BsVm0NTsqtSQRNh1Bt6LdhI HKzg== X-Gm-Message-State: AOAM532si3ECpOdMpb5ictTiLgsEcdpHxzIIadO6gKRDxsca/766BRCr uFTVNUxlu8idpQeYR/vrhL4AM/VMMqrEtAoU/cZz+hArZjyovitkDl5ESlZ9Xehd/H6sMtR7Hz+ vEQUxYJ8QbCmtzMuo1XQ= X-Received: by 2002:ab0:310a:: with SMTP id e10mr2583489ual.126.1613646855082; Thu, 18 Feb 2021 03:14:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJxjyl4ZCPSQMFP8KE+wcmLKf1JD/TOZ+nNkuDz3ZcQVX7FjXsZDlhIHg/KBDGQwtHlz9p4VBkav1tWN339vrKY= X-Received: by 2002:ab0:310a:: with SMTP id e10mr2583474ual.126.1613646854882; Thu, 18 Feb 2021 03:14:14 -0800 (PST) MIME-Version: 1.0 References: <20210204073420.2421-1-ibtisam.tariq@emumba.com> In-Reply-To: From: David Marchand Date: Thu, 18 Feb 2021 12:14:03 +0100 Message-ID: To: Ibtisam Tariq Cc: Maxime Coquelin , "Xia, Chenbo" , Cristian Dumitrescu , "Singh, Jasvinder" , "Mcnamara, John" , "Pattan, Reshma" , "Ananyev, Konstantin" , "Kovacevic, Marko" , dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 1/7] examples/fips_validation: enhance getopt_long usage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Feb 18, 2021 at 11:48 AM Ibtisam Tariq wrote: > On Thu, Feb 18, 2021 at 2:59 PM David Marchand wrote: >> >> On Thu, Feb 4, 2021 at 8:34 AM Ibtisam Tariq wrote: >> > >> > Instead of using getopt_long return value, strcmp was used to >> > compare the input parameters with the struct option array. This >> > patch get rid of all those strcmp by directly binding each longopt >> > with an int enum. This is to improve readability and consistency in >> > all examples. >> > >> > Bugzilla ID: 238 >> > Cc: marko.kovacevic@intel.com >> > >> > Reported-by: David Marchand >> > Signed-off-by: Ibtisam Tariq >> >> For such a series, please provide a cover letter, this is easier when >> replying on the whole series (and for me when applying). Please do not top post. > Thanks for the recommendation. In future, I will add a cover letter for a long patch set. > If you want, I can submit the cover letter for this patch set too. No need to send a new revision just for this, thanks. -- David Marchand