Re: [PATCH v2 0/4] remove driver-specific logic for AVX builds

[David Marchand <david.marchand@redhat.com>]

On Fri, Mar 14, 2025 at 6:44 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> A number of drivers had special optimized AVX2 and AVX512 code paths
> for performance reasons, and these tended to have copy-pasted logic
> to build those files. Centralise that logic in the main
> drivers/meson.build file to avoid duplication.
>
> v2: add patch 4 to remove use of unnecessary CC_AVX2_SUPPORT flag
>
> Bruce Richardson (4):
>   build: add generalized AVX handling for drivers
>   net/intel: use common AVX build code
>   drivers/net: build use common AVX handling
>   drivers/net: remove AVX2 build-time define
>
>  drivers/meson.build                   | 30 +++++++++++++++++++++++++++
>  drivers/net/bnxt/bnxt_ethdev.c        |  2 --
>  drivers/net/bnxt/meson.build          | 10 +--------
>  drivers/net/enic/meson.build          | 10 +--------
>  drivers/net/intel/i40e/meson.build    | 26 ++---------------------
>  drivers/net/intel/iavf/meson.build    | 25 ++--------------------
>  drivers/net/intel/ice/meson.build     | 25 ++--------------------
>  drivers/net/intel/idpf/meson.build    | 25 ++--------------------
>  drivers/net/nfp/meson.build           | 10 +--------
>  drivers/net/octeon_ep/meson.build     | 13 +-----------
>  drivers/net/octeon_ep/otx_ep_ethdev.c |  4 ----
>  drivers/net/virtio/meson.build        |  9 +-------
>  12 files changed, 43 insertions(+), 146 deletions(-)

event/dlb2 can be converted too, or is there something special about
this driver?


As part of the discussion on the base drivers, and seeing this series,
it would be cool if we had a generic framework to specify a set of
cflags for a set of sources.
But at least this series lgtm and is a first step.


-- 
David Marchand