From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2 0/4] remove driver-specific logic for AVX builds
Date: Mon, 17 Mar 2025 10:50:24 +0100 [thread overview]
Message-ID: <CAJFAV8w_gdDZ49nJNMxaxvk-Sv8v6T_FK6nWbVyaoKELjaJRUg@mail.gmail.com> (raw)
In-Reply-To: <20250314174439.112658-1-bruce.richardson@intel.com>
On Fri, Mar 14, 2025 at 6:44 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> A number of drivers had special optimized AVX2 and AVX512 code paths
> for performance reasons, and these tended to have copy-pasted logic
> to build those files. Centralise that logic in the main
> drivers/meson.build file to avoid duplication.
>
> v2: add patch 4 to remove use of unnecessary CC_AVX2_SUPPORT flag
>
> Bruce Richardson (4):
> build: add generalized AVX handling for drivers
> net/intel: use common AVX build code
> drivers/net: build use common AVX handling
> drivers/net: remove AVX2 build-time define
>
> drivers/meson.build | 30 +++++++++++++++++++++++++++
> drivers/net/bnxt/bnxt_ethdev.c | 2 --
> drivers/net/bnxt/meson.build | 10 +--------
> drivers/net/enic/meson.build | 10 +--------
> drivers/net/intel/i40e/meson.build | 26 ++---------------------
> drivers/net/intel/iavf/meson.build | 25 ++--------------------
> drivers/net/intel/ice/meson.build | 25 ++--------------------
> drivers/net/intel/idpf/meson.build | 25 ++--------------------
> drivers/net/nfp/meson.build | 10 +--------
> drivers/net/octeon_ep/meson.build | 13 +-----------
> drivers/net/octeon_ep/otx_ep_ethdev.c | 4 ----
> drivers/net/virtio/meson.build | 9 +-------
> 12 files changed, 43 insertions(+), 146 deletions(-)
event/dlb2 can be converted too, or is there something special about
this driver?
As part of the discussion on the base drivers, and seeing this series,
it would be cool if we had a generic framework to specify a set of
cflags for a set of sources.
But at least this series lgtm and is a first step.
--
David Marchand
prev parent reply other threads:[~2025-03-17 9:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 17:23 [PATCH 0/3] " Bruce Richardson
2025-03-14 17:23 ` [PATCH 1/3] build: add generalized AVX handling for drivers Bruce Richardson
2025-03-14 17:23 ` [PATCH 2/3] net/intel: use common AVX build code Bruce Richardson
2025-03-14 17:23 ` [PATCH 3/3] drivers/net: build use common AVX handling Bruce Richardson
2025-03-14 17:31 ` David Marchand
2025-03-14 17:37 ` Bruce Richardson
2025-03-14 17:44 ` [PATCH v2 0/4] remove driver-specific logic for AVX builds Bruce Richardson
2025-03-14 17:44 ` [PATCH v2 1/4] build: add generalized AVX handling for drivers Bruce Richardson
2025-03-14 17:44 ` [PATCH v2 2/4] net/intel: use common AVX build code Bruce Richardson
2025-03-14 17:44 ` [PATCH v2 3/4] drivers/net: build use common AVX handling Bruce Richardson
2025-03-14 17:44 ` [PATCH v2 4/4] drivers/net: remove AVX2 build-time define Bruce Richardson
2025-03-17 9:47 ` David Marchand
2025-03-17 9:50 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8w_gdDZ49nJNMxaxvk-Sv8v6T_FK6nWbVyaoKELjaJRUg@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).