From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74E83A0565; Mon, 23 Mar 2020 14:19:54 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4A9CE1C067; Mon, 23 Mar 2020 14:19:53 +0100 (CET) Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [63.128.21.74]) by dpdk.org (Postfix) with ESMTP id DE5291C065 for ; Mon, 23 Mar 2020 14:19:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584969591; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KKDCKGwAG7puCKDz2T+Oici4fwlBHh6cj/sry5Objhs=; b=KammLAbqURMVRRLKM1ZSEv4wD/JsjFiYz8ARxT+mRxQHRYr8jPyZVIEb36KOMvItniB7xI HRDCxPi7i3sszqQ24ZTKjun2qwYjzSr+OiltY5odqLwM2aLMcXKFnTlHbDzrHaXNNfvPU4 C2FdflshpKuSI4nPdFGIHvHhcWbblgw= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-490-EFLR-rSiNFGnSigsiqWTjw-1; Mon, 23 Mar 2020 09:19:47 -0400 X-MC-Unique: EFLR-rSiNFGnSigsiqWTjw-1 Received: by mail-vs1-f70.google.com with SMTP id u203so1808866vsu.1 for ; Mon, 23 Mar 2020 06:19:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uYfdew5HmSVDPpOMNx0Ui656tOgez3Ec00zIBYQNMjA=; b=XOWpQWnITjkbeH8vOq6Xdcrkfa7r3Pcgjpn6CaJv+xBEQ3z36o2n7+rcnx7peBSpTt vf3iLQB435uqbe3ryfp1ZcIcvu9HPcrO4ou3uLrQVJAdkANDpqEHtQrL2gzJv0ge1aEl y4So68PgAk/jCnsUI903Pr95qXOsUi2G0Q81AArqyqIJzn6CulBElPGtRgQBnsztTSRY gQqTIXQXSIXrty213qCta4T4VYAeZxFCrZh/TUUbsfNafEOCe6rzGGvqE0bujWSg2Z3M tXZ0iidNuxQ7FsUpRR8u+s0hSY0uFJB14VL7/pjEgaBGPpfOWy2knJuqiMi9Lua1UBG3 wA+w== X-Gm-Message-State: ANhLgQ2D/soyG9LaZlNvkuuqxxwfZrTkiLNjSNjgHjK1YYJEIgdT/fOo ms1S4rAeBBLpSsdkOxP2d9Tj1g/Irp5bJcjGIwoc37kifUaiYhsmjK4IRFv+grN+1k8Ox4QYeEK 6nlziA6o03jaLV9QjAr4= X-Received: by 2002:ab0:6796:: with SMTP id v22mr13864552uar.41.1584969587121; Mon, 23 Mar 2020 06:19:47 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvsK2lEKKho0prE0pbSOzOwyLQPnYKP3Q5I4XEaz+SETOtUQP4jrYshYWD/yzJhcmvWODx2zMiTh2FwlTg3xB0= X-Received: by 2002:ab0:6796:: with SMTP id v22mr13864522uar.41.1584969586752; Mon, 23 Mar 2020 06:19:46 -0700 (PDT) MIME-Version: 1.0 References: <20200319144418.15661-1-ndabilpuram@marvell.com> <20200323115613.29677-1-ndabilpuram@marvell.com> In-Reply-To: <20200323115613.29677-1-ndabilpuram@marvell.com> From: David Marchand Date: Mon, 23 Mar 2020 14:19:35 +0100 Message-ID: To: Nithin Dabilpuram Cc: Thomas Monjalon , Neil Horman , dev , Jerin Jacob Kollanukkaran , bingz@mellanox.com, dpdk stable X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2] devtools: fix check symbol change script X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Mar 23, 2020 at 12:56 PM Nithin Dabilpuram wrote: > > Fix check symbol change script to detect new diff file when > it is in between "--- /dev/null" to "b/lib/...". > Current awk line expects line to start with "a/..." > which is not always true for all diffs. > As a result if in_map was '1' earlier, it will not be changed > to '0' and we get check patch errors which are not true. > > Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > Signed-off-by: Nithin Dabilpuram > Acked-by: Neil Horman > Tested-by: Jerin Jacob Thanks Nithin, applied. --=20 David Marchand