From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id DECFEA0471 for ; Mon, 17 Jun 2019 10:03:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0E34F1BE35; Mon, 17 Jun 2019 10:03:37 +0200 (CEST) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id 1A0341BE2B for ; Mon, 17 Jun 2019 10:03:36 +0200 (CEST) Received: by mail-io1-f67.google.com with SMTP id d12so11229918iod.5 for ; Mon, 17 Jun 2019 01:03:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6n1+zRWJ/H742WanTdKOqkpk0tgB9qzDuUvoD6UMk2Y=; b=qlSd5InDzVXBgosBLuAdaaofiPaKOuAJ8GLCkULjZFDvFM/2+5rsFdhvqlZI2knxMD 8eR7CkeAWKtEbCm7kGuA4487GvJvOZemLllbVaEgtVxmwAvZZZvBkKE7amxox2HiXKT1 GxtL9pxPM2xWDJBYdbQGrq1JSa+Qr9o+pz2kjF5txWA8smYvqcg4XY2+ieTv0Sy2gN9Z L4IIfgXPgFdUUZOkPUsTGLOlUCPvqWF6PxYGTLupDJ+Z73wDvkqUlEuLM08OK68nWYLW A9IpUeaUl0j/wmQ2sqO8EJ9q1/VTU7wE+sywDTqSVGvqHG9cDd3fRyxmUiRrlEnRFE3+ 6QwQ== X-Gm-Message-State: APjAAAX8aeM4RgfrHOfcPWB6eD7U3K+Jau3ehLWK3TilFWi5LX6+1FYR Qov723y95zhiGNnsMwYt1DDuf/1DebtK4SUWdxaH6w== X-Google-Smtp-Source: APXvYqz+DKyFhyNQxdoSzRfgKW9hDH4Leo/yFZHmtUciKwizhmoifIyOX5Xgro4UWoXTIVyYwRGYNR2vlBTX8ehoLOg= X-Received: by 2002:a6b:f80b:: with SMTP id o11mr33008792ioh.40.1560758615428; Mon, 17 Jun 2019 01:03:35 -0700 (PDT) MIME-Version: 1.0 References: <20190617142303.85240-1-xiaolong.ye@intel.com> In-Reply-To: <20190617142303.85240-1-xiaolong.ye@intel.com> From: David Marchand Date: Mon, 17 Jun 2019 10:03:24 +0200 Message-ID: To: Xiaolong Ye Cc: Qi Zhang , Karlsson Magnus , Topel Bjorn , yuan.peng@intel.com, dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v1] net/af_xdp: support need wakeup feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jun 17, 2019 at 9:42 AM Xiaolong Ye wrote: > This patch adds a new devarg to support the need_wakeup flag for Tx and > fill rings, when this flag is set by the driver, it means that the > userspace application has to explicitly wake up the kernel Rx or kernel Tx > processing by issuing a syscall. Poll() can wake up both and sendto() or > its alternatives will wake up Tx processing only. > > This feature is to provide efficient support for case that application and > driver are executing on the same core. > > Signed-off-by: Xiaolong Ye > --- > > Original busy poll feature has morphed into need_wakeup flag in > kernel side, the main purpose is the same, that is to support both > application and driver executing on the same core efficiently. > > kernel side patchset can be found at netdev mailing list. > > https://lore.kernel.org/netdev/CAJ8uoz2szX=+JXXAMyuVmvSsMXZuDqp6a8rjDQpTioxbZwxFmQ@mail.gmail.com/T/#t > > It is targeted for v5.3 > - Is this really optional? Adding too many options is just a nightmare later... - I suppose this will break compilation with kernels that have af_xdp but are < 5.3. -- David Marchand