From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 675FF43A95; Tue, 6 Feb 2024 13:48:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4E67740EF1; Tue, 6 Feb 2024 13:48:14 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 32D324021E for ; Tue, 6 Feb 2024 13:48:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707223691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jMHm4Nn7UY5BVsxWSQanvd2NmaiL+ckXwp/GJjj5IPI=; b=hwzmFOE43N+v9nDcX5VatlOCXmps+J4aCErOGic30OLAtgLG10ZBTiNDjJscKN6MWlcKuG vjHPjYgD0W85gnhc421HPJV8yug17PUenYdcJ7CZUDs476YKynbrXPDLVk8yH47t14BUY+ IV7E1uEnIoXSJqH2DtWOgz7Y9BLElfg= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-16-sdTx2g2GPa2YQhdEa4Fv1g-1; Tue, 06 Feb 2024 07:48:10 -0500 X-MC-Unique: sdTx2g2GPa2YQhdEa4Fv1g-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2d0c13c8d64so4133401fa.3 for ; Tue, 06 Feb 2024 04:48:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707223689; x=1707828489; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jMHm4Nn7UY5BVsxWSQanvd2NmaiL+ckXwp/GJjj5IPI=; b=BFXnXMPnyv5UHwd4SeqXdVyhkubCvuj6x9yRXkgx6fR8WqNOKeEQeok4yo5PDNbcBt jirwlEoQhHhIf24ngVx2BWmevvfrRyivjJ+1NjjKSb64isRkAKTA4pHMwVNeIr987DmU ODRkSb01kInvPObm/IgByNDdBu0n+uSR6NHq3aCuTYnOh86QtyKn06SSlr1Oy79ffWaG IBVyJx1qUWyL0B+ZKBEdA0kkJSIZrMCWWA+hoNNydz5PUgW6L6/sfL9ww5oBsl3ZRUyQ Kjbcvu+gDO4Xxv7y0WBgmPqPnfq1NWM8QamtPuNA3N2d2l0vmP3ScvNJu82jQ/JI4+Vk tt1w== X-Gm-Message-State: AOJu0YyWJm8OVw2phI4GMWi0rWBJZ8YZeTiinr0IYtFnDAX0tMMpRQRQ dwBCGqKsKBbBoay2izzh5L36y43bI7vFa9iz4J6NQ9T5vY9p4sg86jfSE9dD8xeM/NRk/qOmoJY HogD5QGs7f+M8PIFn3l+CPnNLYN+jnzClfgMgOZgtMxl4C9M02pYOdRIFknBhd9+jjZp1U9zuXR cK05+sdu50Kus78co= X-Received: by 2002:a2e:99c2:0:b0:2d0:a347:1cd3 with SMTP id l2-20020a2e99c2000000b002d0a3471cd3mr1956367ljj.28.1707223689092; Tue, 06 Feb 2024 04:48:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IGUGuo38d8XISDFvwfYE3d3/swCoqfmx493Mi668fjKIVOqzaP74yuglBX6n3dZ0YS/53ETZpb0PMUKry9/5qM= X-Received: by 2002:a2e:99c2:0:b0:2d0:a347:1cd3 with SMTP id l2-20020a2e99c2000000b002d0a3471cd3mr1956347ljj.28.1707223688717; Tue, 06 Feb 2024 04:48:08 -0800 (PST) MIME-Version: 1.0 References: <20240206095607.339410-1-david.marchand@redhat.com> <20240206103420.341328-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Tue, 6 Feb 2024 13:47:57 +0100 Message-ID: Subject: Re: [PATCH v2] net/iavf: remove error logs for vlan offloading To: Amiya Ranjan Mohakud Cc: dev@dpdk.org, bruce.richardson@intel.com, stable@dpdk.org, Jingjing Wu , Qiming Yang , Qi Zhang , Haiyue Wang X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Feb 6, 2024 at 1:46=E2=80=AFPM David Marchand wrote: > > On Tue, Feb 6, 2024 at 1:44=E2=80=AFPM Amiya Ranjan Mohakud > wrote: > > I also see a similar error with iavf using dpdk-22.11.1. But in my case= , I see 2 more additional error logs showing up during iavf_dev_configure(= ). It's with ESX-8.0U1 with an inbox driver. Firmware upgrade did not resol= ve the issue though. > > > > 2023-12-08T09:58:00.906 |9322| MSG [NET] dpdk_log_write:107 iavf_e= xecute_vf_cmd(): Return failure -4 for cmd 27 > > 2023-12-08T09:58:00.906 |9322| MSG [NET] dpdk_log_write:107 iavf_e= nable_vlan_strip(): Failed to execute command of OP_ENABLE_VLAN_STRIPPING > > 2023-12-08T09:58:00.906 |9322| MSG [NET] dpdk_log_write:107 iavf_d= ev_init_vlan(): Failed to update vlan offload > > 2023-12-08T09:58:00.906 |9322| MSG [NET] dpdk_log_write:107 iavf_d= ev_configure(): configure VLAN failed: -5 > > 2023-12-08T09:58:01.156 |9322| MSG [NET] dpdk_log_write:107 iavf_e= xecute_vf_cmd(): Return failure -5 for cmd 14 > > > > I was currently following up with KaiwenX on this. Attached the mail th= read for reference. > > > > Could you please let me know if this patch would fix the issue or any m= ore additional fixes are needed? > > Those logs above are about actually requesting vlan offloading. > While in my case, I was not requesting anything. Ah sorry, I read too quickly and missed the iavf_dev_init_vlan(). Well, it may be related, though I can't produce the mailbox errors in my case, which seems specific to the ESX PF driver. And for this, I have no clue what is wrong. --=20 David Marchand