DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Maryam Tahhan <maryam.tahhan@intel.com>,
	Reshma Pattan <reshma.pattan@intel.com>,
	 Jerin Jacob <jerinj@marvell.com>,
	Wisam Jaddo <wisamm@nvidia.com>,
	 Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
	Xiaoyun Li <xiaoyun.li@intel.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	 Jay Jayatheerthan <jay.jayatheerthan@intel.com>,
	Chas Williams <chas3@att.com>,
	"Min Hu (Connor)" <humin29@huawei.com>,
	Pavan Nikhilesh <pbhagavatula@marvell.com>,
	 Shijith Thotton <sthotton@marvell.com>,
	Ajit Khaparde <ajit.khaparde@broadcom.com>,
	 Somnath Kotur <somnath.kotur@broadcom.com>,
	John Daley <johndale@cisco.com>,
	 Hyong Youb Kim <hyonkim@cisco.com>,
	Qi Zhang <qi.z.zhang@intel.com>,
	 Xiao Wang <xiao.w.wang@intel.com>,
	Beilei Xing <beilei.xing@intel.com>,
	 Haiyue Wang <haiyue.wang@intel.com>,
	Matan Azrad <matan@nvidia.com>,
	 Shahaf Shuler <shahafs@nvidia.com>,
	Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
	 Keith Wiles <keith.wiles@intel.com>,
	Jiayu Hu <jiayu.hu@intel.com>,
	 Olivier Matz <olivier.matz@6wind.com>,
	Ori Kam <orika@nvidia.com>,  Akhil Goyal <gakhil@marvell.com>,
	Declan Doherty <declan.doherty@intel.com>,
	 Ray Kinsella <mdr@ashroe.eu>,
	Radu Nicolau <radu.nicolau@intel.com>,
	 Hemant Agrawal <hemant.agrawal@nxp.com>,
	Sachin Saxena <sachin.saxena@oss.nxp.com>,
	 Nithin Dabilpuram <ndabilpuram@marvell.com>,
	Kiran Kumar K <kirankumark@marvell.com>,
	 Sunil Kumar Kori <skori@marvell.com>,
	Satha Rao <skoteshwar@marvell.com>,
	 "John W. Linville" <linville@tuxdriver.com>,
	Ciara Loftus <ciara.loftus@intel.com>,
	 Shepard Siegel <shepard.siegel@atomicrules.com>,
	Ed Czeck <ed.czeck@atomicrules.com>,
	 John Miller <john.miller@atomicrules.com>,
	Igor Russkikh <irusskikh@marvell.com>,
	 Steven Webster <steven.webster@windriver.com>,
	Matt Peters <matt.peters@windriver.com>,
	 Somalapuram Amaranath <asomalap@amd.com>,
	Rasesh Mody <rmody@marvell.com>,
	 Shahed Shaikh <shshaikh@marvell.com>,
	Bruce Richardson <bruce.richardson@intel.com>,
	 Konstantin Ananyev <konstantin.ananyev@intel.com>,
	Ruifeng Wang <ruifeng.wang@arm.com>,
	 Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
	Marcin Wojtas <mw@semihalf.com>,
	 Michal Krawczyk <mk@semihalf.com>,
	Shai Brandes <shaibran@amazon.com>,
	 Evgeny Schemeilin <evgenys@amazon.com>,
	Igor Chauskin <igorch@amazon.com>,
	 Gagandeep Singh <g.singh@nxp.com>, Gaetan Rivet <grive@u256.net>,
	Ziyang Xuan <xuanziyang2@huawei.com>,
	 Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,
	Guoyang Zhou <zhouguoyang@huawei.com>,
	 Yisen Zhuang <yisen.zhuang@huawei.com>,
	Lijun Ou <oulijun@huawei.com>,
	 Jingjing Wu <jingjing.wu@intel.com>,
	Qiming Yang <qiming.yang@intel.com>,
	 Andrew Boyer <aboyer@pensando.io>, Rosen Xu <rosen.xu@intel.com>,
	 Srisivasubramanian Srinivasan <srinivasan@marvell.com>,
	Jakub Grajciar <jgrajcia@cisco.com>,
	 Zyta Szpak <zr@semihalf.com>, Liron Himi <lironh@marvell.com>,
	 Stephen Hemminger <sthemmin@microsoft.com>,
	Long Li <longli@microsoft.com>,
	 Martin Spinler <spinler@cesnet.cz>,
	Heinrich Kuhn <heinrich.kuhn@netronome.com>,
	Jiawen Wu <jiawenwu@trustnetic.com>,
	Tetsuya Mukawa <mtetsuyah@gmail.com>,
	 Harman Kalra <hkalra@marvell.com>,
	Anoob Joseph <anoobj@marvell.com>,
	 Nalla Pradeep <pnalla@marvell.com>,
	Radha Mohan Chintakuntla <radhac@marvell.com>,
	 Veerasenareddy Burru <vburru@marvell.com>,
	Devendra Singh Rawat <dsinghrawat@marvell.com>,
	 Jasvinder Singh <jasvinder.singh@intel.com>,
	Maciej Czekaj <mczekaj@marvell.com>,
	Jian Wang <jianwang@trustnetic.com>,
	Maxime Coquelin <maxime.coquelin@redhat.com>,
	 Chenbo Xia <chenbo.xia@intel.com>,
	Yong Wang <yongwang@vmware.com>,
	 Nicolas Chautru <nicolas.chautru@intel.com>,
	David Hunt <david.hunt@intel.com>,
	Harry van Haaren <harry.van.haaren@intel.com>,
	 Bernard Iremonger <bernard.iremonger@intel.com>,
	Anatoly Burakov <anatoly.burakov@intel.com>,
	 John McNamara <john.mcnamara@intel.com>,
	Kirill Rybalchenko <kirill.rybalchenko@intel.com>,
	 Byron Marohn <byron.marohn@intel.com>,
	Yipeng Wang <yipeng1.wang@intel.com>, dev <dev@dpdk.org>,
	Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: add namespace
Date: Mon, 30 Aug 2021 11:41:25 +0200	[thread overview]
Message-ID: <CAJFAV8wbN8-qRL=6zYMQ+A5vP64U3GGEM0X1vYONQRQ-ajDD+w@mail.gmail.com> (raw)
In-Reply-To: <20210827011903.1566409-1-ferruh.yigit@intel.com>

Hi Ferruh,

On Fri, Aug 27, 2021 at 3:26 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> Add 'RTE_ETH' namespace to all enums & macros in a backward compatible

For completeness, there are some struct renames too in this patch.


> way. The macros for backward compatibility can be removed in next LTS.

Olivier had provided a script when he prefixed librte_net macros.
https://inbox.dpdk.org/dev/20190529144602.5tpfb5p3yasz3tvl@platinum/

Did you use a script to do those renames and can you share it?
Or maybe we can simply reuse Olivier script.


>
> Internal components switched to new enum & macro names.

I found remaining references for macros and structs.
Enums look fine.

With this patch applied:

# For structs:
$ for word in $(git show -- 'lib/ethdev/rte_ethdev.h' |awk '/^-struct
/ {print $2}' |sort -u); do git grep -w $word |grep -v '#define
'$word'[[:space:]]'; done
lib/ethdev/rte_ethdev.h:    struct rte_fdir_conf fdir_conf; /**< FDIR
configuration. DEPRECATED */
lib/ethdev/rte_ethdev.h:    struct rte_intr_conf intr_conf; /**<
Interrupt mode configuration. */

# Enums look fine:
$ for word in $(git show -- 'lib/ethdev/rte_ethdev.h' |awk '/^-enum /
{print $2}' |sort -u); do git grep -w $word |grep -v '#define
'$word'[[:space:]]'; done
$ for word in $(git show -- 'lib/ethdev/rte_ethdev.h' |awk
'/^-\t(RTE|ETH)_[^ ,]*,/ {print $2}' |sort -u); do word=${word%%,};
git grep -w $word |grep -v '#define '$word'[[:space:]]'; done
$ for word in $(git show -- 'lib/ethdev/rte_ethdev.h' |awk
'/^-\t(RTE|ETH)_[^ ,]* = / {print $2}' |sort -u); do git grep -w $word
|grep -v '#define '$word'[[:space:]]'; done

# For macros:
$ for word in $(git show -- 'lib/ethdev/rte_ethdev.h' |awk '/^-#define
/ {print $2}' |sort -u); do git grep -w $word |grep -v '#define
'$word'[[:space:]]' && echo; done
doc/guides/rel_notes/release_18_11.rst:  To request keeping CRC,
application should set ``DEV_RX_OFFLOAD_KEEP_CRC``

doc/guides/rel_notes/release_19_11.rst:  * Added new Rx offload flag
``DEV_RX_OFFLOAD_RSS_HASH`` which can be used to

lib/ethdev/rte_ethdev.h:    } tc_rxq[ETH_MAX_VMDQ_POOL][ETH_DCB_NUM_TCS];
lib/ethdev/rte_ethdev.h:    } tc_txq[ETH_MAX_VMDQ_POOL][ETH_DCB_NUM_TCS];
lib/ethdev/rte_ethdev.h:    uint8_t tc_bws[ETH_DCB_NUM_TCS]; /**< TX
BW percentage for each TC */

lib/ethdev/rte_ethdev.h:    uint8_t dcb_tc[ETH_DCB_NUM_USER_PRIORITIES];
lib/ethdev/rte_ethdev.h:    uint8_t dcb_tc[ETH_DCB_NUM_USER_PRIORITIES];
lib/ethdev/rte_ethdev.h:    uint8_t dcb_tc[ETH_DCB_NUM_USER_PRIORITIES];
lib/ethdev/rte_ethdev.h:    uint8_t dcb_tc[ETH_DCB_NUM_USER_PRIORITIES];
lib/ethdev/rte_ethdev.h:    uint8_t
prio_tc[ETH_DCB_NUM_USER_PRIORITIES]; /**< Priority to tc */

[snipped the rest of the output] etc...


-- 
David Marchand


  parent reply	other threads:[~2021-08-30  9:41 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-29 13:46 [dpdk-dev] [PATCH] " Ferruh Yigit
2021-06-29 15:02 ` Tyler Retzlaff
2021-06-30  6:29 ` David Marchand
2021-06-30  9:08   ` Ferruh Yigit
2021-08-27  1:19 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2021-08-27  7:59   ` Andrew Rybchenko
2021-08-27 20:24     ` Ferruh Yigit
2021-08-28 14:26     ` Ajit Khaparde
2021-08-29  7:47       ` Jerin Jacob
2021-08-29  8:17       ` Wisam Monther
2021-08-30  2:13         ` Xu, Rosen
2021-08-30  5:27           ` Xia, Chenbo
2021-08-30  6:24         ` Hemant Agrawal
2021-08-30  9:41   ` David Marchand [this message]
2021-08-30 17:01     ` Ferruh Yigit
2021-08-30 17:19   ` [dpdk-dev] [PATCH v3] " Ferruh Yigit
2021-08-31  7:59     ` Thomas Monjalon
2021-10-18 15:43     ` [dpdk-dev] [PATCH v4] " Ferruh Yigit
2021-10-20 19:23       ` [dpdk-dev] [PATCH v5] " Ferruh Yigit
2021-10-22  2:02         ` [dpdk-dev] [PATCH v6] " Ferruh Yigit
2021-10-22  6:44           ` Andrew Rybchenko
2021-10-22  8:25             ` Ferruh Yigit
2021-10-22  9:48           ` Pattan, Reshma
2021-10-22 11:03           ` [dpdk-dev] [PATCH v7] " Ferruh Yigit
2021-10-22 11:28             ` Andrew Rybchenko
2021-10-22 12:29               ` Somnath Kotur
2021-10-22 16:26                 ` Ferruh Yigit
2021-10-22 13:02               ` Ferruh Yigit
2021-11-01  9:23             ` Jiawen Wu
2021-11-01 12:39               ` Ferruh Yigit
2021-11-01 12:48                 ` Ferruh Yigit
2021-11-01 13:20                   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8wbN8-qRL=6zYMQ+A5vP64U3GGEM0X1vYONQRQ-ajDD+w@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=aboyer@pensando.io \
    --cc=ajit.khaparde@broadcom.com \
    --cc=anatoly.burakov@intel.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=anoobj@marvell.com \
    --cc=asomalap@amd.com \
    --cc=beilei.xing@intel.com \
    --cc=bernard.iremonger@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=byron.marohn@intel.com \
    --cc=chas3@att.com \
    --cc=chenbo.xia@intel.com \
    --cc=ciara.loftus@intel.com \
    --cc=cloud.wangxiaoyun@huawei.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=david.hunt@intel.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=dsinghrawat@marvell.com \
    --cc=ed.czeck@atomicrules.com \
    --cc=evgenys@amazon.com \
    --cc=ferruh.yigit@intel.com \
    --cc=g.singh@nxp.com \
    --cc=gakhil@marvell.com \
    --cc=grive@u256.net \
    --cc=haiyue.wang@intel.com \
    --cc=harry.van.haaren@intel.com \
    --cc=heinrich.kuhn@netronome.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=hkalra@marvell.com \
    --cc=humin29@huawei.com \
    --cc=hyonkim@cisco.com \
    --cc=igorch@amazon.com \
    --cc=irusskikh@marvell.com \
    --cc=jasvinder.singh@intel.com \
    --cc=jay.jayatheerthan@intel.com \
    --cc=jerinj@marvell.com \
    --cc=jgrajcia@cisco.com \
    --cc=jianwang@trustnetic.com \
    --cc=jiawenwu@trustnetic.com \
    --cc=jiayu.hu@intel.com \
    --cc=jingjing.wu@intel.com \
    --cc=john.mcnamara@intel.com \
    --cc=john.miller@atomicrules.com \
    --cc=johndale@cisco.com \
    --cc=keith.wiles@intel.com \
    --cc=kirankumark@marvell.com \
    --cc=kirill.rybalchenko@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=linville@tuxdriver.com \
    --cc=lironh@marvell.com \
    --cc=longli@microsoft.com \
    --cc=maryam.tahhan@intel.com \
    --cc=matan@nvidia.com \
    --cc=matt.peters@windriver.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=mczekaj@marvell.com \
    --cc=mdr@ashroe.eu \
    --cc=mk@semihalf.com \
    --cc=mtetsuyah@gmail.com \
    --cc=mw@semihalf.com \
    --cc=ndabilpuram@marvell.com \
    --cc=nicolas.chautru@intel.com \
    --cc=olivier.matz@6wind.com \
    --cc=orika@nvidia.com \
    --cc=oulijun@huawei.com \
    --cc=pbhagavatula@marvell.com \
    --cc=pnalla@marvell.com \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=radhac@marvell.com \
    --cc=radu.nicolau@intel.com \
    --cc=rahul.lakkireddy@chelsio.com \
    --cc=reshma.pattan@intel.com \
    --cc=rmody@marvell.com \
    --cc=roretzla@linux.microsoft.com \
    --cc=rosen.xu@intel.com \
    --cc=ruifeng.wang@arm.com \
    --cc=sachin.saxena@oss.nxp.com \
    --cc=shahafs@nvidia.com \
    --cc=shaibran@amazon.com \
    --cc=shepard.siegel@atomicrules.com \
    --cc=shshaikh@marvell.com \
    --cc=skori@marvell.com \
    --cc=skoteshwar@marvell.com \
    --cc=somnath.kotur@broadcom.com \
    --cc=spinler@cesnet.cz \
    --cc=srinivasan@marvell.com \
    --cc=steven.webster@windriver.com \
    --cc=sthemmin@microsoft.com \
    --cc=sthotton@marvell.com \
    --cc=thomas@monjalon.net \
    --cc=vburru@marvell.com \
    --cc=viacheslavo@nvidia.com \
    --cc=wisamm@nvidia.com \
    --cc=xiao.w.wang@intel.com \
    --cc=xiaoyun.li@intel.com \
    --cc=xuanziyang2@huawei.com \
    --cc=yipeng1.wang@intel.com \
    --cc=yisen.zhuang@huawei.com \
    --cc=yongwang@vmware.com \
    --cc=zhouguoyang@huawei.com \
    --cc=zr@semihalf.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).