From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92C2AA034F; Mon, 30 Aug 2021 11:41:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A036F41161; Mon, 30 Aug 2021 11:41:45 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 299BA41155 for ; Mon, 30 Aug 2021 11:41:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630316503; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=17NBAgbn4R8MhRMQ2R4rH+XAfCXXeAQH7Mm7y8VggDg=; b=OSnRz+yW4ucEzyh/dIARWe8NTf3EveS0ndlR/gNZ9eBKXFGLWq275m7A8yT0xCwGcIeGY2 a937h0kT4oVxcX/8DTLwDhj0bogbVF71igXZpukYst19ZSXKCNo67VivwjWDKlaCtNXEuu tvIGLG8KTb/jxam2KXf3mCKjqMc41H0= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-251-bjTYpilRP0WW23TX1ttuag-1; Mon, 30 Aug 2021 05:41:39 -0400 X-MC-Unique: bjTYpilRP0WW23TX1ttuag-1 Received: by mail-lj1-f199.google.com with SMTP id q62-20020a2e2a41000000b001d37080f948so4815366ljq.17 for ; Mon, 30 Aug 2021 02:41:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=17NBAgbn4R8MhRMQ2R4rH+XAfCXXeAQH7Mm7y8VggDg=; b=B1+XZKAUIGoSPH83saAJEbdTIDN5p2TpfsOYyrQdN4FeIp5UIz0lV5+l9Q3CL0Gs2i cIezBnucux8fBMwvRUzC+gzo2sY7qJXGq3EEIZLi7LRNIN46sNy/YykHSUlPBZUaZ93f Jn7D9W6Lu+BdOI1H0oMDMvfAEoKzTHekbcxxAHPf2pl93SMnDuun+7EWMuL6LldWAZyN +dRW9z5yLb7vFjad10/lropfCo/ig4UpDdEOoHIUmtV5FWwaOz5EVL9sVtfEh0pdL91e 3y8OnQneT+M0ApQzW4xoy8mb0esChj5nRpUHxLV32rT2lwsPMSEYzLLM7B1lKa9C0KeB rvPw== X-Gm-Message-State: AOAM531hWg0gvq3ngC8EcCOHMhMDNM8KgJOYrH+mlquYxsi5Bu8CWkv0 8o5hVfi65m2nBfPnffopwqGmUGqK/cTKpTf1OMewuDtoUuBxKrlrCNkeetQR58qvJ1uL04cEU59 /jgfl77KONFrbYuhTifQ= X-Received: by 2002:a2e:a4a9:: with SMTP id g9mr19782709ljm.162.1630316497485; Mon, 30 Aug 2021 02:41:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxJp5n0kCjRkzErNBykiJ4eHY8qB0UoZKhbsNZ99ZSlVT4u8JM/acA9lzWOpt+kKVdXfUqcorg4VSV3nNjodyY= X-Received: by 2002:a2e:a4a9:: with SMTP id g9mr19782648ljm.162.1630316497172; Mon, 30 Aug 2021 02:41:37 -0700 (PDT) MIME-Version: 1.0 References: <20210629134632.525037-1-ferruh.yigit@intel.com> <20210827011903.1566409-1-ferruh.yigit@intel.com> In-Reply-To: <20210827011903.1566409-1-ferruh.yigit@intel.com> From: David Marchand Date: Mon, 30 Aug 2021 11:41:25 +0200 Message-ID: To: Ferruh Yigit Cc: Maryam Tahhan , Reshma Pattan , Jerin Jacob , Wisam Jaddo , Cristian Dumitrescu , Xiaoyun Li , Thomas Monjalon , Andrew Rybchenko , Jay Jayatheerthan , Chas Williams , "Min Hu (Connor)" , Pavan Nikhilesh , Shijith Thotton , Ajit Khaparde , Somnath Kotur , John Daley , Hyong Youb Kim , Qi Zhang , Xiao Wang , Beilei Xing , Haiyue Wang , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Keith Wiles , Jiayu Hu , Olivier Matz , Ori Kam , Akhil Goyal , Declan Doherty , Ray Kinsella , Radu Nicolau , Hemant Agrawal , Sachin Saxena , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , "John W. Linville" , Ciara Loftus , Shepard Siegel , Ed Czeck , John Miller , Igor Russkikh , Steven Webster , Matt Peters , Somalapuram Amaranath , Rasesh Mody , Shahed Shaikh , Bruce Richardson , Konstantin Ananyev , Ruifeng Wang , Rahul Lakkireddy , Marcin Wojtas , Michal Krawczyk , Shai Brandes , Evgeny Schemeilin , Igor Chauskin , Gagandeep Singh , Gaetan Rivet , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Yisen Zhuang , Lijun Ou , Jingjing Wu , Qiming Yang , Andrew Boyer , Rosen Xu , Srisivasubramanian Srinivasan , Jakub Grajciar , Zyta Szpak , Liron Himi , Stephen Hemminger , Long Li , Martin Spinler , Heinrich Kuhn , Jiawen Wu , Tetsuya Mukawa , Harman Kalra , Anoob Joseph , Nalla Pradeep , Radha Mohan Chintakuntla , Veerasenareddy Burru , Devendra Singh Rawat , Jasvinder Singh , Maciej Czekaj , Jian Wang , Maxime Coquelin , Chenbo Xia , Yong Wang , Nicolas Chautru , David Hunt , Harry van Haaren , Bernard Iremonger , Anatoly Burakov , John McNamara , Kirill Rybalchenko , Byron Marohn , Yipeng Wang , dev , Tyler Retzlaff Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] ethdev: add namespace X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ferruh, On Fri, Aug 27, 2021 at 3:26 AM Ferruh Yigit wrote: > > Add 'RTE_ETH' namespace to all enums & macros in a backward compatible For completeness, there are some struct renames too in this patch. > way. The macros for backward compatibility can be removed in next LTS. Olivier had provided a script when he prefixed librte_net macros. https://inbox.dpdk.org/dev/20190529144602.5tpfb5p3yasz3tvl@platinum/ Did you use a script to do those renames and can you share it? Or maybe we can simply reuse Olivier script. > > Internal components switched to new enum & macro names. I found remaining references for macros and structs. Enums look fine. With this patch applied: # For structs: $ for word in $(git show -- 'lib/ethdev/rte_ethdev.h' |awk '/^-struct / {print $2}' |sort -u); do git grep -w $word |grep -v '#define '$word'[[:space:]]'; done lib/ethdev/rte_ethdev.h: struct rte_fdir_conf fdir_conf; /**< FDIR configuration. DEPRECATED */ lib/ethdev/rte_ethdev.h: struct rte_intr_conf intr_conf; /**< Interrupt mode configuration. */ # Enums look fine: $ for word in $(git show -- 'lib/ethdev/rte_ethdev.h' |awk '/^-enum / {print $2}' |sort -u); do git grep -w $word |grep -v '#define '$word'[[:space:]]'; done $ for word in $(git show -- 'lib/ethdev/rte_ethdev.h' |awk '/^-\t(RTE|ETH)_[^ ,]*,/ {print $2}' |sort -u); do word=${word%%,}; git grep -w $word |grep -v '#define '$word'[[:space:]]'; done $ for word in $(git show -- 'lib/ethdev/rte_ethdev.h' |awk '/^-\t(RTE|ETH)_[^ ,]* = / {print $2}' |sort -u); do git grep -w $word |grep -v '#define '$word'[[:space:]]'; done # For macros: $ for word in $(git show -- 'lib/ethdev/rte_ethdev.h' |awk '/^-#define / {print $2}' |sort -u); do git grep -w $word |grep -v '#define '$word'[[:space:]]' && echo; done doc/guides/rel_notes/release_18_11.rst: To request keeping CRC, application should set ``DEV_RX_OFFLOAD_KEEP_CRC`` doc/guides/rel_notes/release_19_11.rst: * Added new Rx offload flag ``DEV_RX_OFFLOAD_RSS_HASH`` which can be used to lib/ethdev/rte_ethdev.h: } tc_rxq[ETH_MAX_VMDQ_POOL][ETH_DCB_NUM_TCS]; lib/ethdev/rte_ethdev.h: } tc_txq[ETH_MAX_VMDQ_POOL][ETH_DCB_NUM_TCS]; lib/ethdev/rte_ethdev.h: uint8_t tc_bws[ETH_DCB_NUM_TCS]; /**< TX BW percentage for each TC */ lib/ethdev/rte_ethdev.h: uint8_t dcb_tc[ETH_DCB_NUM_USER_PRIORITIES]; lib/ethdev/rte_ethdev.h: uint8_t dcb_tc[ETH_DCB_NUM_USER_PRIORITIES]; lib/ethdev/rte_ethdev.h: uint8_t dcb_tc[ETH_DCB_NUM_USER_PRIORITIES]; lib/ethdev/rte_ethdev.h: uint8_t dcb_tc[ETH_DCB_NUM_USER_PRIORITIES]; lib/ethdev/rte_ethdev.h: uint8_t prio_tc[ETH_DCB_NUM_USER_PRIORITIES]; /**< Priority to tc */ [snipped the rest of the output] etc... -- David Marchand