From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4BA51A00C2; Wed, 5 Oct 2022 22:10:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 016C9410FB; Wed, 5 Oct 2022 22:10:27 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 1A44B40DFB for ; Wed, 5 Oct 2022 22:10:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665000624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1E+qg6ujWeGEK8lkc27rel+gj56DMcGbs7GMVq9aNGU=; b=SvWP4V9NBtG4H35FC6fRynse3G1twjfuOAREjM2v3wLjKtyw14wrMQo7E4YWbjJFFNMkpB tPPogRX2m/KGWCPHrS/ZXOzbq+7Aiw+6Lr+I+dUGtcKd4gU2fvCQGeDeS4ONvLG3CYZqp3 rH7cQHiXNQpXj4dMtQnWkU3P6J/sWPQ= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-542-CF10tuLvOmypq_rN-DTalw-1; Wed, 05 Oct 2022 16:10:23 -0400 X-MC-Unique: CF10tuLvOmypq_rN-DTalw-1 Received: by mail-pl1-f199.google.com with SMTP id x13-20020a170902ec8d00b00177f0fa642cso12952446plg.10 for ; Wed, 05 Oct 2022 13:10:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=1E+qg6ujWeGEK8lkc27rel+gj56DMcGbs7GMVq9aNGU=; b=I5eIRN0OAsysE7igEYper4x5jjJGuT+gMqUgNSfGuOZqALHPMdjLxJZH3hgIAK9OI1 FqHTh8PME1PdYIpXv3I+YLI1XQfilnlNUbBW5wf+BJQxY+DLGjMnBHJgIkuzGcRqIr7J dQXRKOUEBSbF5JQnXYYOs4PLbo8/JW+44s3S2c6K9y0KRp3aL79ppoCnD9+NCwMHNAOM KtU7rZWf9jjPyAojfSF7giGoRlAj4vFW80sb5TeD0T/ixiPxKrjavMCey0det6OlPuCQ GItazQRoDzY+Byw55CYE4D5mPY5xImevbx5mTHPZ51WT/BHYNvnV50OuSqCgpx96QMQO fkbw== X-Gm-Message-State: ACrzQf0UgrUJBXf6im08WcZcTZCNmKTXMTvbglTSBjRu0zmkMMQQkE6e b6z7SAV4SDyY+EIzKugHDEttaLSugXOXXPX6n+e3wXH9YkFmrnwRNOrN4pZbiRR3vxoTU5f8jDP IPbtPM2Bytej3Ef/TlkY= X-Received: by 2002:a17:90a:428e:b0:205:d5fe:e0b3 with SMTP id p14-20020a17090a428e00b00205d5fee0b3mr1426399pjg.33.1665000621812; Wed, 05 Oct 2022 13:10:21 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5Ie5TwWyOuEuI1PympsHS6CQ7UDKA9FWwDM1J6m61WX29fkNKu6BGfCykpIFnb0S2xxpTVPRwglNNKtzEKjgc= X-Received: by 2002:a17:90a:428e:b0:205:d5fe:e0b3 with SMTP id p14-20020a17090a428e00b00205d5fee0b3mr1426377pjg.33.1665000621550; Wed, 05 Oct 2022 13:10:21 -0700 (PDT) MIME-Version: 1.0 References: <20221005143451.157613-1-bruce.richardson@intel.com> In-Reply-To: <20221005143451.157613-1-bruce.richardson@intel.com> From: David Marchand Date: Wed, 5 Oct 2022 22:10:10 +0200 Message-ID: Subject: Re: [PATCH 1/2] kni: flag deprecated status at build time To: Bruce Richardson Cc: dev@dpdk.org, techboard@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= , Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 5, 2022 at 4:35 PM Bruce Richardson wrote: > > To ensure all users are aware of KNI's deprecated status at build time > we can take the following actions: > > 1. disable the library by default. It can be re-enabled by setting > disabled_libs to the empty string (or other string not including > 'kni') > > 2. add support for a list of deprecated libs to the lib/meson.build file > so the error message for KNI being disabled includes the fact that it > is a deprecated library. > > 3. for the dependent NIC driver, drivers/net/kni, modify its disabled > message to also reference the fact that KNI is disabled. Let's say I want to re-enable the net/kni driver. How should I do this? Passing -Denable_drivers=net/kni results in only getting net/kni. Passing -Denable_drivers=*/* gives the same result as passing none: net/kni is disabled because relying on a deprecated lib. > > NOTE: This is part of the deprecation process for KNI agreed by the DPDK > technical board.[1] > > [1] http://mails.dpdk.org/archives/dev/2022-June/243596.html > > Signed-off-by: Bruce Richardson -- David Marchand