From: David Marchand <david.marchand@redhat.com>
To: Deepak Khandelwal <deepak.khandelwal@intel.com>
Cc: "Burakov, Anatoly" <anatoly.burakov@intel.com>,
dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>,
balaji.chintalapalle@intel.com
Subject: Re: [PATCH v2] eal/linux: skip attaching to external memory chunk
Date: Thu, 28 Apr 2022 14:08:35 +0200 [thread overview]
Message-ID: <CAJFAV8wbg6dF5sX8nMY3xw1Fq+McbnmHdyQwKkyKG3jG9K9vQQ@mail.gmail.com> (raw)
In-Reply-To: <1650532281-193591-1-git-send-email-deepak.khandelwal@intel.com>
On Thu, Apr 21, 2022 at 11:36 AM Deepak Khandelwal
<deepak.khandelwal@intel.com> wrote:
>
> Currently, EAL init in secondary processes will attach all fbarrays
> in the memconfig to have access to primary process' page tables.
> However, fbarrays corresponding to external memory segments should
> not be attached at initialization, because this will happen as part
> of `rte_extmem_attach` or `rte_malloc_heap_memory_attach` calls.
>
> Both external memory API's document this:
>
> rte_malloc:
> http://doc.dpdk.org/api/rte__malloc_8h.html#af6360dea35bdf162feeb2b62cf149fd3
>
> rte_extmem:
> http://doc.dpdk.org/api/rte__memory_8h.html#a2796da68de6825f8edf53759f8e4d230
>
> Fixes: ff3619d6244b ("malloc: allow attaching to external memory chunks")
> Cc: stable@dpdk.org
>
> Signed-off-by: Deepak Khandelwal <deepak.khandelwal@intel.com>
> Suggested-by: Anatoly Burakov <anatoly.burakov@intel.com>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Applied, thanks Deepak.
--
David Marchand
prev parent reply other threads:[~2022-04-28 12:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 12:32 [PATCH] " Deepak Khandelwal
2022-04-20 15:26 ` Burakov, Anatoly
2022-04-20 15:32 ` Burakov, Anatoly
2022-04-21 9:11 ` [PATCH v2] " Deepak Khandelwal
2022-04-28 12:08 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8wbg6dF5sX8nMY3xw1Fq+McbnmHdyQwKkyKG3jG9K9vQQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=balaji.chintalapalle@intel.com \
--cc=deepak.khandelwal@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).