From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F289A0C43; Tue, 19 Oct 2021 10:50:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1491440142; Tue, 19 Oct 2021 10:50:08 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 963B94003E for ; Tue, 19 Oct 2021 10:50:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634633406; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ctYdGz1RaTkZXavHZkTOcmB9yjefyWLKELStDsGq6V0=; b=aNiOM3nB73kyK5hZqhUq6CgYCag5MMwCsNh4iaZhD+I+JSCKAfUfZmI1Zs63k0uPc1QN0E BlJhJCirX1aTn7THCiOP9DzUSRVsLrIqFVEEJysL7kSc7TlR7slqVdK3QbiZVwfKMAkRiz 90COh/cZn7Y7ylhWaU6HAaL1fFUl4zo= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-479-HHAkuSYmPnKG-fP29_E4kQ-1; Tue, 19 Oct 2021 04:50:02 -0400 X-MC-Unique: HHAkuSYmPnKG-fP29_E4kQ-1 Received: by mail-lj1-f199.google.com with SMTP id k12-20020a2ea26c000000b00210f22d4769so634616ljm.4 for ; Tue, 19 Oct 2021 01:50:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ctYdGz1RaTkZXavHZkTOcmB9yjefyWLKELStDsGq6V0=; b=F4Hpm/tis8kvSsAmX8UjweQRcy50KaFQvj174ljcF73WXkCvElw9VL+zAf60vmseS7 NO0WyhfW9s62V5ZSU+Em9qD5Ooc79sYERNupYFRn1SBlzs5f4kLzlC09rPNGGulWIh5I o01kp/SV2RJQmg95AvXMAwrDa04BFBBT2LAt87EBi7QqiZVY+A/WNthjkHjUSNBs8kru vnl78RiMWuHWME0i2SL/uatsy4np+R6llZtJuKvGqL9ubmXJu+mAV8Z8dK9GfagJLprK MvKgn2OcJ5F3s6CJjjWw7SVL6EFIS+fay4XAvtNBFzMs+1yYNaZpbpNolCfWi0vGrYhv Ga4g== X-Gm-Message-State: AOAM533GVtK41kDUTlF91eVqrcUhRYeOBGsxJLFPoWK2TV89Jr9rBoEQ u3v0fJfaZHpb3Ac+Jv2A2cfqx5it8dki8NRaL+r6pbwpDOEXfpAik4x17nLJEIId2nPZZMrPtna ZcDwuGGJzYYntVOxJdms= X-Received: by 2002:a2e:2f02:: with SMTP id v2mr5178562ljv.46.1634633401342; Tue, 19 Oct 2021 01:50:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyNog8Jt+eqB7F0aJCsaazaCmAGW2vkT2NS6WxnqxJUO5LU+q9aBDb/61O+QDythVOx4ClazTedqDBZTD3j5cc= X-Received: by 2002:a2e:2f02:: with SMTP id v2mr5178538ljv.46.1634633401170; Tue, 19 Oct 2021 01:50:01 -0700 (PDT) MIME-Version: 1.0 References: <20211018144907.1145028-1-andrew.rybchenko@oktetlabs.ru> <20211018144907.1145028-6-andrew.rybchenko@oktetlabs.ru> In-Reply-To: <20211018144907.1145028-6-andrew.rybchenko@oktetlabs.ru> From: David Marchand Date: Tue, 19 Oct 2021 10:49:49 +0200 Message-ID: To: Andrew Rybchenko Cc: Olivier Matz , Ray Kinsella , "Artem V. Andreev" , Ashwin Sekhar T K , Pavan Nikhilesh , Hemant Agrawal , Sachin Saxena , Harman Kalra , Jerin Jacob , Nithin Dabilpuram , dev , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 5/6] mempool: add namespace to driver register macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 18, 2021 at 4:50 PM Andrew Rybchenko wrote: > > Add RTE_ prefix to macro used to register mempool driver. > The old one is still available but deprecated. ODP seems to use its own mempools. $ git grep-all -w MEMPOOL_REGISTER_OPS OpenDataplane/platform/linux-generic/pktio/dpdk.c:MEMPOOL_REGISTER_OPS(odp_pool_ops); I'd say it counts as a driver macro. If so, we could hide it in a driver-only header, along with rte_mempool_register_ops getting marked as internal. $ git grep-all -w rte_mempool_register_ops FD.io-VPP/src/plugins/dpdk/buffer.c: rte_mempool_register_ops (&ops); FD.io-VPP/src/plugins/dpdk/buffer.c: rte_mempool_register_ops (&ops); -- David Marchand