DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Ciara Loftus <ciara.loftus@intel.com>,
	Qi Zhang <qi.z.zhang@intel.com>,
	 Xiaolong Ye <xiaolong.ye@intel.com>, dev <dev@dpdk.org>,
	dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 6/7] net/af_xdp: remove useless assignment
Date: Wed, 18 Nov 2020 15:42:43 +0100
Message-ID: <CAJFAV8wdgLR_giQx=KHuLAUoeR1EoV+EL9XkCbmfE5pi6BXtAg@mail.gmail.com> (raw)
In-Reply-To: <20201118114525.99053-7-ferruh.yigit@intel.com>

On Wed, Nov 18, 2020 at 12:47 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> Assignment of function parameter 'umem' removed.
>
> Fixes: f0ce7af0e182 ("net/af_xdp: remove resources when port is closed")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>  drivers/net/af_xdp/rte_eth_af_xdp.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c
> index 2c7892bd7e..7fc70df713 100644
> --- a/drivers/net/af_xdp/rte_eth_af_xdp.c
> +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c
> @@ -840,7 +840,6 @@ xdp_umem_destroy(struct xsk_umem_info *umem)
>  #endif
>
>         rte_free(umem);
> -       umem = NULL;
>  }
>
>  static int

Reviewed-by: David Marchand <david.marchand@redhat.com>

-- 
David Marchand


  reply	other threads:[~2020-11-18 14:43 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-17 17:14 [dpdk-dev] [PATCH 0/4] cppcheck Ferruh Yigit
2020-11-17 17:14 ` [dpdk-dev] [PATCH 1/4] app/procinfo: fix redundant condition Ferruh Yigit
2020-11-17 17:14 ` [dpdk-dev] [PATCH 2/4] app/procinfo: fix negative check on unsigned variable Ferruh Yigit
2020-11-17 17:14 ` [dpdk-dev] [PATCH 3/4] app/procinfo: remove suspicious sizeof Ferruh Yigit
2020-11-17 18:07   ` Varghese, Vipin
2020-11-17 17:14 ` [dpdk-dev] [PATCH 4/4] app/procinfo: remove useless assignment Ferruh Yigit
2020-11-17 18:04   ` Varghese, Vipin
2020-11-18 10:46     ` Ferruh Yigit
2020-11-18 11:45 ` [dpdk-dev] [PATCH v2 0/7] cppcheck Ferruh Yigit
2020-11-18 11:45   ` [dpdk-dev] [PATCH v2 1/7] app/procinfo: fix redundant condition Ferruh Yigit
2020-11-18 14:10     ` David Marchand
2020-11-19  9:34       ` Ferruh Yigit
2020-11-18 11:45   ` [dpdk-dev] [PATCH v2 2/7] app/procinfo: fix negative check on unsigned variable Ferruh Yigit
2020-11-18 14:10     ` [dpdk-dev] [dpdk-stable] " David Marchand
2020-11-18 11:45   ` [dpdk-dev] [PATCH v2 3/7] app/procinfo: remove suspicious sizeof Ferruh Yigit
2020-11-18 14:10     ` [dpdk-dev] [dpdk-stable] " David Marchand
2020-11-18 11:45   ` [dpdk-dev] [PATCH v2 4/7] app/procinfo: remove useless assignment Ferruh Yigit
2020-11-18 14:11     ` David Marchand
2020-11-18 11:45   ` [dpdk-dev] [PATCH v2 5/7] net/pcap: remove local variable shadown outer one Ferruh Yigit
2020-11-18 14:11     ` David Marchand
2020-11-18 11:45   ` [dpdk-dev] [PATCH v2 6/7] net/af_xdp: remove useless assignment Ferruh Yigit
2020-11-18 14:42     ` David Marchand [this message]
2020-11-18 11:45   ` [dpdk-dev] [PATCH v2 7/7] net/bnxt: fix redundant return Ferruh Yigit
2020-11-18 14:42     ` [dpdk-dev] [dpdk-stable] " David Marchand
2020-11-18 16:12       ` Ajit Khaparde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8wdgLR_giQx=KHuLAUoeR1EoV+EL9XkCbmfE5pi6BXtAg@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=ciara.loftus@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    --cc=xiaolong.ye@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git