From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE4B0430FE; Fri, 25 Aug 2023 11:55:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 81C9B40695; Fri, 25 Aug 2023 11:55:41 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4B40C400D5 for ; Fri, 25 Aug 2023 11:55:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692957339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YrF7TRdg74WArSzqjQi56H0dXtQsW54GHk2zlTWLhCE=; b=HrXk9GaZQliSRXqdu0F4FWwZkQ3BgWkAoI2pT6S7Dtjb45QHO9BD9m8GsOUPhu/jhkfxf4 oYukYdgicWVCls2EQywKIzpREH9KYIJfC05TByL91T0GhmBrlt76Klw485GVO0OkGgQxc3 BPS6PNjPyfcn1ONq6I4Jipg7HyxPqpA= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-613-ZtKMLKDVOTeezw19HNfHRw-1; Fri, 25 Aug 2023 05:55:36 -0400 X-MC-Unique: ZtKMLKDVOTeezw19HNfHRw-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-500a10289e3so822066e87.2 for ; Fri, 25 Aug 2023 02:55:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692957335; x=1693562135; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YrF7TRdg74WArSzqjQi56H0dXtQsW54GHk2zlTWLhCE=; b=GkLDtX5CZdVRWrjI7vKbIar9dC3z9craf9Fanoyi97yuT816A2gnuLfP59x7P0LrvA x8a2EY/47i5cjwVjLNaY7LqAMf6aC6RywBlXcUouu/tpl556P0h1x2Zor3kIll+YWrQA tEB4qSn5pt/JWbNpjxou0Kf9yQ1C3oZJ9V+fvpzaQ7ViIZPVyJMcMZSCfawB8UVskhy9 4x2ML3iS3my8YnfWBm0DOvHSUNxOUsX0BbabYY5C6TBehcVU13cVcATY6MDrcM9kbYv3 EQpx0rKwysnIO0gUZ1XBNRl2rwfUXbvRShTHQsLg03lhvCoDrxUzsmw2zJoWyxkD+gLD hJsg== X-Gm-Message-State: AOJu0YyOndL1XG62O2w0lKj0SnGG/+60xcTsgbQnSIjN9D7VuI58H8Mz piK7H9tCrbzDp2+Q4SeuKVOjOshIDws7oBLld11C9KK9/TOjU68NNb89Ycza6re4MVOhuGn0U02 pwjKLo0+bJLrBM5j0sl8= X-Received: by 2002:a05:6512:1287:b0:4fc:4f3e:9cbf with SMTP id u7-20020a056512128700b004fc4f3e9cbfmr15270911lfs.50.1692957335058; Fri, 25 Aug 2023 02:55:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFm+mbwnnMOKiabWLQd/qDV6yarjbuKvXvMhYVhTqIdBHVMvQuR/adUzm4WQB1B2zAS7k69hTqO3ISL+YRZhl0= X-Received: by 2002:a05:6512:1287:b0:4fc:4f3e:9cbf with SMTP id u7-20020a056512128700b004fc4f3e9cbfmr15270893lfs.50.1692957334745; Fri, 25 Aug 2023 02:55:34 -0700 (PDT) MIME-Version: 1.0 References: <20191213141322.32730-1-maxime.coquelin@redhat.com> In-Reply-To: <20191213141322.32730-1-maxime.coquelin@redhat.com> From: David Marchand Date: Fri, 25 Aug 2023 11:55:23 +0200 Message-ID: Subject: Re: [dpdk-dev] [PATCH 0/4] Add external contiguous memory support to Virtio-user To: Maxime Coquelin Cc: dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com, anatoly.burakov@intel.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Dec 13, 2019 at 3:13=E2=80=AFPM Maxime Coquelin wrote: > > Somme applications/frameworks using DPDK allocate their own memory > for its buffers. This is the case of Seastar, and also VPP. > > It is currently not possible to use Virtio-user PMD with these > applications because Virtio-user requires file descriptor for this > memory to be shared with the vhost-user backend (vDPA in our case [0]). > > This series introduces a new API in EAL to register external memory > that is contiguous in both the VA and the IOVA space. > > It also enables VDEVs to implement the DMA map/unmap callback, and > implement it in Virtio-user PMD. > > Please note that extmem unit tests are missing. I'm working on it > and it will be in v2. Just share this v1 for early reviews. > > Maxime Coquelin (4): > eal: add new API to register contiguous external memory > eal: allow getting memory segment FD with external memory > bus/vdev: add DMA mapping supprt > net/virtio: add DMA mapping callback to virtio-user > > drivers/bus/vdev/rte_bus_vdev.h | 24 +++++ > drivers/bus/vdev/vdev.c | 50 +++++++++++ > .../net/virtio/virtio_user/virtio_user_dev.c | 10 +-- > .../net/virtio/virtio_user/virtio_user_dev.h | 3 + > drivers/net/virtio/virtio_user_ethdev.c | 58 +++++++++++++ > lib/librte_eal/common/eal_common_memory.c | 87 ++++++++++++++++--- > lib/librte_eal/common/include/rte_memory.h | 46 ++++++++++ > lib/librte_eal/common/malloc_heap.c | 17 +++- > lib/librte_eal/common/malloc_heap.h | 2 +- > lib/librte_eal/common/rte_malloc.c | 2 +- > lib/librte_eal/rte_eal_version.map | 3 + > 11 files changed, 278 insertions(+), 24 deletions(-) I am not sure this feature is still needed as there was no activity for a long time. There was some feedback from Anatoly and the series needs a rebase in any c= ase. I marked the series as Changes requested so it is clear it can't be considered for merging in its current state. Thanks. --=20 David Marchand