From: David Marchand <david.marchand@redhat.com>
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"dpdklab@iol.unh.edu" <dpdklab@iol.unh.edu>,
"ci@dpdk.org" <ci@dpdk.org>,
"Honnappa.Nagarahalli@arm.com" <Honnappa.Nagarahalli@arm.com>,
"mattias.ronnblom" <mattias.ronnblom@ericsson.com>,
"mb@smartsharesystems.com" <mb@smartsharesystems.com>,
"roretzla@linux.microsoft.com" <roretzla@linux.microsoft.com>,
"aconole@redhat.com" <aconole@redhat.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [PATCH] service: split tests to perf and autotest to avoid spurious CI failures
Date: Tue, 7 Mar 2023 14:48:46 +0100 [thread overview]
Message-ID: <CAJFAV8web7P_26iwx0xGTOUY5MToaCJYxnZMw0U1jFy=HAQMRw@mail.gmail.com> (raw)
In-Reply-To: <BL3PR11MB56993968591CA877D1A3AD28D7B39@BL3PR11MB5699.namprd11.prod.outlook.com>
On Fri, Mar 3, 2023 at 11:59 AM Van Haaren, Harry
<harry.van.haaren@intel.com> wrote:
> > > + .setup = testsuite_setup,
> > > + .teardown = testsuite_teardown,
> > > + .unit_test_cases = {
> > > + TEST_CASE_ST(dummy_register, NULL, service_attr_get),
> > > + TEST_CASE_ST(dummy_register, NULL, service_lcore_attr_get),
> > > + TEST_CASE_ST(dummy_register, NULL, service_lcore_start_stop),
> >
> > Looking at service_lcore_running_check(), don't you think
> > service_may_be_active() and service_active_two_cores() are also
> > subject to race?
>
> Perhaps, but those haven't *actually* been failing in any of the reports.
> I'd prefer leave tests running if they're not causing issues in the CI.
service_may_be_active did fail in the near past (report from October
that triggered the discussion and the timeout extension patch).
So my fear is that we will see some ocurrences.
Time will tell.
--
David Marchand
next prev parent reply other threads:[~2023-03-07 13:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 17:36 Harry van Haaren
2023-02-27 16:08 ` David Marchand
2023-03-03 8:37 ` David Marchand
2023-03-03 10:59 ` Van Haaren, Harry
2023-03-07 13:48 ` David Marchand [this message]
2023-03-03 13:00 ` [PATCH v2] " Harry van Haaren
2023-03-07 13:48 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8web7P_26iwx0xGTOUY5MToaCJYxnZMw0U1jFy=HAQMRw@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=aconole@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=ci@dpdk.org \
--cc=dev@dpdk.org \
--cc=dpdklab@iol.unh.edu \
--cc=harry.van.haaren@intel.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=mb@smartsharesystems.com \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).