From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64503A0599; Sun, 19 Apr 2020 09:08:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 98DEE1D593; Sun, 19 Apr 2020 09:08:25 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 47B3D1D591 for ; Sun, 19 Apr 2020 09:08:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587280102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4a8poHbjcRacu+OFblMAej5GgeXbTYzRv5bWP2QEF/o=; b=i7jgL7JDfNuaTBJAYboNFiPS0QEUB+fzHbuna701GSwZTjnp3VWeq8TLTgLVYS4aOov7fg fJY5Ldgwy3iWsE5C2Sgfzne6PGIv0qSEW6opHWr43sdXdNRTsoy+lj8VLS6b8LuA69yq+e zLT9Ck20pPnhS/MK0v4ifNOrKjvbWrY= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-50-x6o1gQiJPXGraA4ivhRbXQ-1; Sun, 19 Apr 2020 03:08:17 -0400 X-MC-Unique: x6o1gQiJPXGraA4ivhRbXQ-1 Received: by mail-ua1-f70.google.com with SMTP id y11so3115362uaq.4 for ; Sun, 19 Apr 2020 00:08:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MvRIJdjS1fq76xKJEzymvnFEIG2DtmGjjimR2LuhobM=; b=TFluR/susV0DJA7Jm3jgaYocaNxQk1+V2k/beezb+fZ0M3gL31QE3xkJve3X63q8dn 1jXc6WGKTztNVIO8gkRyOGVXRvtGv4SkTMdH1pHtEjtxv1MfT0e9s8QECHK4OTEfHeON XKUYe7iziosDMBXg44y5z4sEmpE88M4dRMf2R3ges1hJDbqfPjjQZNLQ1J+5LKI5fa2b N79LKtd+QnWiTdS7drjBb2yqFoVSk95UzQV3OQraB0OPKvniuogKwivlrCxvS9XXdgJi DOEBjM3ys4EfR3FBTglzRryS5o8kNuz2EnOPzFXGZEQ78bOZ5DHHgbvHy3pUln+ni8yq vQ0w== X-Gm-Message-State: AGi0PuZsQLYNOk1mrftLKBKczE6RVKTqD4JwQO0rZBiAPYRBxaYksd7t d4SO2lghHl1XQgvFObUd3SEvs+TZTdUUAOajpt3vLm2oqf1wA5Vq2oCdie76n/ylTVyIHySq504 S/s2p6T1fjF0Y1gBfnsw= X-Received: by 2002:a67:8dc8:: with SMTP id p191mr7797398vsd.198.1587280096558; Sun, 19 Apr 2020 00:08:16 -0700 (PDT) X-Google-Smtp-Source: APiQypLys/+z22vuQZJNc/54V9Ame/zhzjcKfMI+g0+rLIyKz/ODJjt8JCEWEukoYMt4wXQHF0+D9COJyy4uy3SYje4= X-Received: by 2002:a67:8dc8:: with SMTP id p191mr7797389vsd.198.1587280096281; Sun, 19 Apr 2020 00:08:16 -0700 (PDT) MIME-Version: 1.0 References: <20200418131942.1388633-1-thomas@monjalon.net> In-Reply-To: <20200418131942.1388633-1-thomas@monjalon.net> From: David Marchand Date: Sun, 19 Apr 2020 09:08:04 +0200 Message-ID: To: Thomas Monjalon Cc: dev , Bruce Richardson X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] devtools: reduce examples in static builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Apr 18, 2020 at 3:20 PM Thomas Monjalon wrote= : > > Static builds can take a lot of space, so reduce the number of examples > built when testing those static builds. > > As makefile-based build is close to end of life, completely skip examples > in case of static linkage with make. > > Signed-off-by: Thomas Monjalon > --- > devtools/test-build.sh | 1 + > devtools/test-meson-builds.sh | 7 ++++++- > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/devtools/test-build.sh b/devtools/test-build.sh > index e6e40588c6..a298115002 100755 > --- a/devtools/test-build.sh > +++ b/devtools/test-build.sh > @@ -257,6 +257,7 @@ for conf in $configs ; do > echo "=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Buil= d examples for $conf" > export RTE_SDK=3D$(readlink -f $dir)/install/share/dpdk > ln -sTf $(pwd)/lib $RTE_SDK/lib # workaround for vm_power_manager > + grep -q 'SHARED_LIB=3Dn' $dir/.config || # skip examples with sta= tic libs > ${MAKE} -j$J -sC examples \ > EXTRA_LDFLAGS=3D"$DPDK_DEP_LDFLAGS" $verbose \ > O=3D$(readlink -f $dir)/examples > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.s= h > index c1ff2bb50a..b1c0380809 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -74,7 +74,12 @@ config () # > return > fi > options=3D > - options=3D"$options --werror -Dexamples=3Dall" > + options=3D"$options --werror" > + if echo $* | grep -qw -- '--default-library=3Dstatic' ; then > + options=3D"$options -Dexamples=3Dl3fwd" > + else > + options=3D"$options -Dexamples=3Dall" > + fi Ok, this is hypothetical, but this would not work when no default-library option is passed (static is the default value). How about inverting the check and look for default-library=3Dshared ? Besides, you won't catch already configured directories. While for make environments, this change will have an effect right away. --=20 David Marchand