DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: David Marchand <david.marchand@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] pipeline: fix build with glibc < 2.26
Date: Fri, 2 Oct 2020 13:50:32 +0200	[thread overview]
Message-ID: <CAJFAV8wgRshnizJ97BBE=gUF5OmNyyjPfD=7XXXctoHXZ0-AnA@mail.gmail.com> (raw)
In-Reply-To: <CY4PR11MB17026167221EB7CC367A3941EB310@CY4PR11MB1702.namprd11.prod.outlook.com>

On Fri, Oct 2, 2020 at 12:38 PM Dumitrescu, Cristian
<cristian.dumitrescu@intel.com> wrote:
> > -----Original Message-----
> > From: David Marchand <david.marchand@redhat.com>
> > Sent: Friday, October 2, 2020 9:29 AM
> > To: dev@dpdk.org
> > Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> > Subject: [PATCH] pipeline: fix build with glibc < 2.26
> >
> > reallocarray has been introduced in glibc 2.26 but we still support
> > glibc >= 2.7.
> > Simply replace with realloc, as the considered sizes are unlikely to
> > overflow.
> >
> > """
> > The reallocarray() function changes the size of the memory block
> > pointed to by ptr to be large enough for an array of nmemb elements,
> > each of which is size bytes.  It is equivalent to the call
> >
> >        realloc(ptr, nmemb * size);
> >
> > However, unlike that realloc() call, reallocarray() fails safely in
> > the case where the multiplication would overflow.  If such an over‐
> > flow occurs, reallocarray() returns NULL, sets errno to ENOMEM, and
> > leaves the original block of memory unchanged.
> > """
> >
> > Fixes: 3ca60ceed79a ("pipeline: add SWX pipeline specification file")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Applied.


-- 
David Marchand


      reply	other threads:[~2020-10-02 11:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-02  8:28 David Marchand
2020-10-02 10:38 ` Dumitrescu, Cristian
2020-10-02 11:50   ` David Marchand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8wgRshnizJ97BBE=gUF5OmNyyjPfD=7XXXctoHXZ0-AnA@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).