From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6DED45556; Thu, 4 Jul 2024 17:21:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA2F7410F1; Thu, 4 Jul 2024 17:21:32 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id C3C574042F for <dev@dpdk.org>; Thu, 4 Jul 2024 17:21:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720106491; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ax2qKzkdB2pcdYZDcVjntGDht/Bb3dKdPXBT2mDihr4=; b=f8nIKjBkX11XHSouMSxsM8RpwdXuQcDscIsphjTlsKoK1rWTCEy1IutQHeyWXl9vSnYoM4 uGkvsxCLtST5Rsg6quyXOipr8GHZOaWYMnMc3xC9pWMRcnJR4ekBg+8PbH/7i3dAHA/ts9 F5dXm8ZAKeq3R1NkLopoMGgxE3pXtPA= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-530-dKe8QjocO_q3n3ne9dpOzA-1; Thu, 04 Jul 2024 11:21:30 -0400 X-MC-Unique: dKe8QjocO_q3n3ne9dpOzA-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-52e9f195bf6so934445e87.3 for <dev@dpdk.org>; Thu, 04 Jul 2024 08:21:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720106488; x=1720711288; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ax2qKzkdB2pcdYZDcVjntGDht/Bb3dKdPXBT2mDihr4=; b=pwDVunj9lztpVJsgsdibKMcwRtrAbrWi8/9oP+mYtTVLA7Juov5QMM5B2+5v2wSdTx wpl8oql/XuDUNSPm+FZsYkEuGYHEhDr+dI5clHiblj34QZf1pdepUK7zq2mFqb+ABbCo vyppjNic3wrXpLxrL1lTbg3CiRNwn3DwWoy+qmKB3Dv0cLfTsaRI/bmR9hP183RIDUNl EuGp+HHjS3r/Yu+vF7+Ll2im5u/FcDR9YU099LtaNIKavyG9ehIz9ZNQNVrnfY4skGlk OBGZ+IdvqoyuE/W+ZPnVQmw2EOZC75G8i6xPzBlI9F0vqZraXa71emrUG03eCkYmXrkC +V5A== X-Gm-Message-State: AOJu0YzQp9omoyD/kmJCFz41MgUnEs64jes1/HJFFW3IAjPfSgDLWre2 G8ZJBTdKEWyASds5e70p6X03kEy0LkegF1rANtGKk1vCx3GbYxaHeM5NTZTqDNqLfRt+lRLseO+ eGbKbe2U+j+mfwCmPO+3/cj4AGokXbnHbtS+WIxPCBPUpgtYKebCyZQyMQUG1UAiKvndh8tDhbx FJAgK9z+l9hGJf1YY= X-Received: by 2002:ac2:482b:0:b0:52c:dcdc:f186 with SMTP id 2adb3069b0e04-52ea0623691mr1640759e87.27.1720106488709; Thu, 04 Jul 2024 08:21:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG26vJpPzWnqfgJ8udsxesZoeBdK16/xM9tjMdNUorHsfl7Ue+LKl3U65cdoJPcN9IQIDl4LJjldwUP4m8U9m8= X-Received: by 2002:ac2:482b:0:b0:52c:dcdc:f186 with SMTP id 2adb3069b0e04-52ea0623691mr1640743e87.27.1720106488323; Thu, 04 Jul 2024 08:21:28 -0700 (PDT) MIME-Version: 1.0 References: <20240408195036.182545-1-stephen@networkplumber.org> <20240529225732.442539-1-stephen@networkplumber.org> In-Reply-To: <20240529225732.442539-1-stephen@networkplumber.org> From: David Marchand <david.marchand@redhat.com> Date: Thu, 4 Jul 2024 17:21:16 +0200 Message-ID: <CAJFAV8wgUR3hHX+0ZuxeuiLJxhxK_Akg-vd289Ts-PsRPUjdEQ@mail.gmail.com> Subject: Re: [PATCH v6 0/8] latencystats: improvements to algorithm and test To: "Pattan, Reshma" <reshma.pattan@intel.com> Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Thu, May 30, 2024 at 12:57=E2=80=AFAM Stephen Hemminger <stephen@networkplumber.org> wrote: > > Latencystats uses unnecessary floating point and is inaccurate if the num= ber > of cycles per ns is not an integral value. Cleanup the code and add > more tests as well. > > v6 - rebase and combine updates to test > > Stephen Hemminger (8): > latencystats: replace use of VLA > latencystats: handle fractional cycles per ns > latencystats: do not use floating point > latencystats: fix log messages > latencystats: update include files > latencystats: enforce that unused callback function is NULL > latencystats: add metric for number of samples > test: update to latencystats tests > > app/test/test_latencystats.c | 84 ++++++---- > lib/latencystats/rte_latencystats.c | 232 ++++++++++++++++------------ > 2 files changed, 188 insertions(+), 128 deletions(-) > Please review. Thanks. --=20 David Marchand