From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 4F80DA0524;
Fri, 27 Nov 2020 13:14:20 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id CE864C938;
Fri, 27 Nov 2020 13:14:18 +0100 (CET)
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [63.128.21.124])
by dpdk.org (Postfix) with ESMTP id 15253C926
for <dev@dpdk.org>; Fri, 27 Nov 2020 13:14:15 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1606479254;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
in-reply-to:in-reply-to:references:references;
bh=3JCL9tG6gxeN1Xe9h06llkRy6bhmv9do9eY62vgHtqo=;
b=RUPpeB9Ivl0xxbLc05sDU4nB2v5mYYX7d4+LUIo4AH8+8KmxKiIMPq1zox7IrnY0jmKm8v
5qvhwVMaDAQQ996RokqQ/BIkQiyCT5yYoLSxzflez+vjjtOEbflsjzgcWP9l4bMx0USwF7
YSHcbzxXbvsMC5SyWn2g+iM7SctTzj0=
Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com
[209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-72-0Hz8NEWAPjWljjv42ea-yQ-1; Fri, 27 Nov 2020 07:14:10 -0500
X-MC-Unique: 0Hz8NEWAPjWljjv42ea-yQ-1
Received: by mail-vk1-f200.google.com with SMTP id x65so1694202vke.5
for <dev@dpdk.org>; Fri, 27 Nov 2020 04:14:10 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=3JCL9tG6gxeN1Xe9h06llkRy6bhmv9do9eY62vgHtqo=;
b=e9Cp2moTTZ7CwBQ2sWQC+6c0tImOKeuLxN3ReQG6akn7Q9b00n7osYYCsi5LZAcZ9i
pWc8RAHUd2ZIi6QCya1Xb31TKjjNySc6cTFOGi7WvWpH274bVAd6rz7A0VKDvOxwnDe9
Xph/+KpCRKWp62/18juhxL/0fmL4cDRJfqEix4FMdVI1tR4Bq5SgubWmLGUf8Ej43pAF
R9FSUyQcjZV832Rs7uNlCyffmnYWS+g3Fpt7DUkRI2A7qRbk8tQgf5LsAkosB1ExviSc
ncOIrCkSDUfspVaNS61mY6wH9gskuxNx5UiqrUq7BVsPrs1TFzsNAM/1C9fqa1CV0Md8
vnXg==
X-Gm-Message-State: AOAM530aRO6WjrFSngetSPx6TCSBZKJIjTpnTN9ZXL5AGJfxH8+4x7tL
r7Yrzev4KGVgwjCgMEbCdPVkwZGsrkI19jg6QPfWUdpqcydMLyex5ZEOPbQPXwTHDnLgDPRQm9y
hwmVLoq2WSHvoM6q/lBs=
X-Received: by 2002:a1f:4e81:: with SMTP id c123mr4920340vkb.20.1606479249702;
Fri, 27 Nov 2020 04:14:09 -0800 (PST)
X-Google-Smtp-Source: ABdhPJw7grNtxF0tlFKl98riOlGJyJoM6I9BouFXZ/yVtWqmS7I9THzvzrdtgGvwrbp4AYAOWY3GBHJclLaOGltOTUM=
X-Received: by 2002:a1f:4e81:: with SMTP id c123mr4920293vkb.20.1606479249399;
Fri, 27 Nov 2020 04:14:09 -0800 (PST)
MIME-Version: 1.0
References: <20201127080903.26817-1-ruifeng.wang@arm.com>
<20201127080903.26817-3-ruifeng.wang@arm.com>
<CAJFAV8x_8=z8G-_TVuGEABq116_kQFE05BxwdCD=Q7j4w1=-EA@mail.gmail.com>
In-Reply-To: <CAJFAV8x_8=z8G-_TVuGEABq116_kQFE05BxwdCD=Q7j4w1=-EA@mail.gmail.com>
From: David Marchand <david.marchand@redhat.com>
Date: Fri, 27 Nov 2020 13:13:57 +0100
Message-ID: <CAJFAV8whKYfCub67daTNGnkYEhATMap7VwggQ=tbRM+A3Z9CTg@mail.gmail.com>
To: Bruce Richardson <bruce.richardson@intel.com>, "Yigit,
Ferruh" <ferruh.yigit@intel.com>
Cc: Jeff Guo <jia.guo@intel.com>, Haiyue Wang <haiyue.wang@intel.com>,
Alvin Zhang <alvinx.zhang@intel.com>, dev <dev@dpdk.org>,
Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>, nd <nd@arm.com>,
Ruifeng Wang <ruifeng.wang@arm.com>, Feifei Wang <feifei.wang2@arm.com>
Authentication-Results: relay.mimecast.com;
auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH 2/2] net/igc: fix gcc build for optimization
level 0
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Fri, Nov 27, 2020 at 10:02 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Fri, Nov 27, 2020 at 9:10 AM Ruifeng Wang <ruifeng.wang@arm.com> wrote:
> >
> > Gcc build with '-O0' failed for:
> > ../drivers/net/igc/base/igc_api.c
> > Assembler messages:
> > 29: Error: selected processor does not support `casp x0,x1,x2,x3,[x4]'
> > 82: Error: selected processor does not support `caspa x0,x1,x2,x3,[x4]'
> > 135: Error: selected processor does not support `caspl x0,x1,x2,x3,[x4]'
> > 188: Error: selected processor does not support `caspal x0,x1,x2,x3,[x4]'
> >
> > This is due to c_args not been passed to meson.
> >
> > Fixes: 8cb7c57d9b3c ("net/igc: support device initialization")
> > Cc: alvinx.zhang@intel.com
> >
> > Reported-by: Feifei Wang <feifei.wang2@arm.com>
> > Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
>
> I did not get to reproduce it yet (get an error on first patch...).
>
> The patch looks fine but I fear some compilation problems since a lot
> of base drivers filter cflags.
> Still waiting for CI results...
>
> Bruce,Ferruh,
> Wdyt?
Comparing before/after patch on x86, gcc, static build, the only difference is:
-march=native -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API
-Wno-format-truncation
Which corresponds to drivers/meson.build:
default_cflags = machine_args
default_cflags += ['-DALLOW_EXPERIMENTAL_API']
default_cflags += ['-DALLOW_INTERNAL_API']
if cc.has_argument('-Wno-format-truncation')
default_cflags += '-Wno-format-truncation'
endif
So little risk wrt warning flags.
Still I'd like to hear from Intel, thanks.
--
David Marchand