From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28ECEA0C46; Tue, 14 Sep 2021 12:16:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6B6A0410DC; Tue, 14 Sep 2021 12:16:55 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id C71FD4003C for ; Tue, 14 Sep 2021 12:16:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631614613; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IuU/nhvX0OHvTGk8gwIfuqr1W3Y2TpooQJlU/LDPC4w=; b=C+pw/ai71vya+gZkBUiJxnGTDW5YwKslCZVgldTMkt+XyFEyCZkZJc/tTQwFMWBYxMASeT pUPCvJhAbD2gXCwTcqjuNvnzyZ1moRDKYrTmJwvs3w1reXgXAOlgkx9Y8bWYAtBQC3GYWE dDV1fgLs2DxVASnqA0tVmZ7oOGuczUI= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-189-QoOYG-RtOUSHOp9k5qM7sg-1; Tue, 14 Sep 2021 06:16:50 -0400 X-MC-Unique: QoOYG-RtOUSHOp9k5qM7sg-1 Received: by mail-lj1-f198.google.com with SMTP id w28-20020a2e161c000000b001ba14fc0cd4so5660714ljd.10 for ; Tue, 14 Sep 2021 03:16:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IuU/nhvX0OHvTGk8gwIfuqr1W3Y2TpooQJlU/LDPC4w=; b=mV96AB9K568bvuR/f5yVV7JTfvJwr6YQ8dLXLNxLnvMQCRl9NDDGz6/Y6nAGr4XPzI Be0mjhLimcCJvU9A+VaaYmqfBsZVikdMiJTt8chuhfxCv7SOVIQDwsKoODeIpFbeSmGd BoUhAGWnQPfVhv14ic4/VlKJ02b46sSgNgPLvXReL/ibGnWF0jMFiuwQRqx+STX612Zx wXwcuP1Q2vNUcMbR1ancxmrpF3daLhKOS0AkGxlx0B7P2LpBNMJfiuibwcNLm7Y34AqF X+VtM53XAdreWpdwd0ZxtdomtqRL7Woh5hGx32AIe5+7gvsVYDCHX8EMNj+Kc+HkCq+/ ttzQ== X-Gm-Message-State: AOAM530msh+9OrvQF+24Jg8Pupy2zPn9MTwkfDeGirQrtLdcusAsOdLy tPcOYRcG72JzkSuc9K7uPe/8+my8pHAOfKntTDD/mrg4O7sCiMZbcatIlPXEP++BeQkaIj37/61 nDa/J17UAVhGfiREPgUM= X-Received: by 2002:a05:6512:3095:: with SMTP id z21mr12201042lfd.265.1631614608597; Tue, 14 Sep 2021 03:16:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwpdgcEkmQp7DX+1mpd+wB8jq4rpkMMRhsRWyvxlEXQ70uRyW5ULp1yxj3Nj6S7XidULaLM0nh2T2UVh2ro6NE= X-Received: by 2002:a05:6512:3095:: with SMTP id z21mr12201031lfd.265.1631614608326; Tue, 14 Sep 2021 03:16:48 -0700 (PDT) MIME-Version: 1.0 References: <20210623161620.49916-1-drc@linux.vnet.ibm.com> <20210902235326.3236718-1-drc@linux.vnet.ibm.com> In-Reply-To: From: David Marchand Date: Tue, 14 Sep 2021 12:16:36 +0200 Message-ID: To: Ferruh Yigit , Bruce Richardson Cc: David Christensen , dev , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] config/ppc: ignore gcc 11 psabi warnings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Sep 14, 2021 at 11:18 AM Ferruh Yigit wrote: > > On 9/3/2021 12:53 AM, David Christensen wrote: > > Suppress the gcc warning "note: the layout of aggregates containing > > vectors with 4-byte alignment has changed in GCC 5" on POWER systems > > by setting "-Wno-psabi". Warning was originally added to gcc in > > commit https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=9832651 to warn > > of the vector alignment changes introduced in GCC 5. Older gcc > > versions forced vector alignment to 16 bytes due to requirements for > > POWER 6 and earlier CPUs, but these restrictions don't apply to CPUs > > supported by DPDK. > > > > Bugzilla ID: 739 > > > > Signed-off-by: David Christensen > > --- > > v2: > > - update copyright year > > - rebase for 21.11-rc0 > > --- > > config/ppc/meson.build | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/config/ppc/meson.build b/config/ppc/meson.build > > index adf49e1f42..5354db4e0a 100644 > > --- a/config/ppc/meson.build > > +++ b/config/ppc/meson.build > > @@ -1,5 +1,6 @@ > > # SPDX-License-Identifier: BSD-3-Clause > > # Copyright(c) 2018 Luca Boccassi > > +# Copyright(c) 2021 IBM Corporation > > > > if not dpdk_conf.get('RTE_ARCH_64') > > error('Only 64-bit compiles are supported for this platform type') > > @@ -17,6 +18,12 @@ if not power9_supported > > dpdk_conf.set('RTE_MACHINE','power8') > > endif > > > > +# Suppress the gcc warning "note: the layout of aggregates containing > > +# vectors with 4-byte alignment has changed in GCC 5". > > +if cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0') and cc.version().version_compare('<12.0') and cc.has_argument('-Wno-psabi') > > + add_project_arguments('-Wno-psabi', language: 'c') > > +endif > > + > > # Certain POWER9 systems can scale as high as 1536 LCORES, but setting such a > > # high value can waste memory, cause timeouts in time limited autotests, and is > > # unlikely to be used in many production situations. Similarly, keeping the > > -- > > I am getting following build error in my environment: > "config/ppc/meson.build:23:6: ERROR: Unknown statement." > > The compiler I have is: > powerpc64le-linux-gcc (gcc 10.2.0 "powerpc64le-linux-gcc.br_real (Buildroot > 2020.08-14-ge5a2a90) 10.2.0") > > meson version: Version: 0.59.1 Good catch. My fault, and I did not see it because I was still testing with gcc 9. > > Multi-line statements seems need to be merged with '\': > > diff --git a/config/ppc/meson.build b/config/ppc/meson.build > index 0b1948fc7cb9..f95009c77e7a 100644 > --- a/config/ppc/meson.build > +++ b/config/ppc/meson.build > @@ -20,7 +20,7 @@ endif > > # Suppress the gcc warning "note: the layout of aggregates containing > # vectors with 4-byte alignment has changed in GCC 5". > -if cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0') and > +if cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0') and \ > cc.version().version_compare('<12.0') and cc.has_argument('-Wno-psabi') I based this update of mine on other existing multiline statements in dpdk. But I did not notice that all of them are within parens. So both \ and () are fine. Bruce, I did not see this described in our meson coding style. Do you have an opinion for multiline statements in meson? -- David Marchand