From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7BB754374F; Thu, 21 Dec 2023 10:49:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1F00E402E7; Thu, 21 Dec 2023 10:49:46 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id B4060402C0 for ; Thu, 21 Dec 2023 10:49:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703152184; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zQO7/7+3D2btpBGCclp2cj7hrl0sBAvCcjWJFSJzRbk=; b=aJ2PL1+DS5wWWgOCtvXmvbdyGlbQB6b/TFRyp30BOsOt327Qc+LXCznkmGeRILyyCGUstA GhxGLApIO2H4xy0iUqK5Gun57GwPrwaA+AsqEo+8aBLbCG5yfAtIv1PIl7/XbaIvHW+vzT jEg2kxVmI612gGUz52xTAxBrr8AyLwA= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-526-0bb3OPffNUG11A8NHr5v9w-1; Thu, 21 Dec 2023 04:49:42 -0500 X-MC-Unique: 0bb3OPffNUG11A8NHr5v9w-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-50e3b3ab0e7so505495e87.0 for ; Thu, 21 Dec 2023 01:49:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703152181; x=1703756981; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zQO7/7+3D2btpBGCclp2cj7hrl0sBAvCcjWJFSJzRbk=; b=QFLV+gKMzY7AOhUGNgxQbSTN80Q/aA+fmSerGZPL9bxHehBqYWGIZ+/J+Y2FZjEDH5 j3ecsDxWaYeSPzRj4l0y1r+Tni+kr29mnZ92ghyMgJXLlrv5JC7/1amdCdbtY3VHtqGv CeY6O2Z90KqPbAtSaAf5mMH13v0vCXhueKhofFPd0uu7Aa9V16y+J5d9jxpDjzo+0Mfm RKVg8sd25bPK98h7bTUTGsmPJLbSr4LYK20aXckdpu/mrEPcda7lCAQ9d4HenY1facOP rvmpiiYiPDgm6OO/M+tNqU2sQP+EPMEBtEoPILMy7JaFvxbIuNiW7/2KfyYwHzX0liJq HPtg== X-Gm-Message-State: AOJu0YzJRxxWGiS86kZEntYdNe2jIA7WIoXBk4AGRQLv7+10e7Q4Xf7W dmMT8wLyiTjtjjiPEuboiDtjLrWk8Go8HZjgK98GNfOe8kAimRGqfOMWL3AAW1aCjG0a+37CXjY iPDCYMmboXylzDQjd31c= X-Received: by 2002:ac2:4a61:0:b0:50e:603e:9cd4 with SMTP id q1-20020ac24a61000000b0050e603e9cd4mr238626lfp.138.1703152181255; Thu, 21 Dec 2023 01:49:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IEevtb6z6upHfsYbSy1fXAcsSkMYAqS1F9LpD6sRJOEjhyjwrKGaSJ24KpAJH3ke0xpPo9WU4qq9FHkIFPr2dU= X-Received: by 2002:ac2:4a61:0:b0:50e:603e:9cd4 with SMTP id q1-20020ac24a61000000b0050e603e9cd4mr238618lfp.138.1703152180908; Thu, 21 Dec 2023 01:49:40 -0800 (PST) MIME-Version: 1.0 References: <20231213014408.612051-1-stephen@networkplumber.org> <20231218192631.699267-1-stephen@networkplumber.org> <20231218192631.699267-8-stephen@networkplumber.org> In-Reply-To: <20231218192631.699267-8-stephen@networkplumber.org> From: David Marchand Date: Thu, 21 Dec 2023 10:49:29 +0100 Message-ID: Subject: Re: [PATCH v4 07/17] raw/cnxk: replace PMD logtype with dynamic type To: Stephen Hemminger Cc: dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Dec 18, 2023 at 8:27=E2=80=AFPM Stephen Hemminger wrote: > > Driver should not be using PMD logtype, they should have their > own logtype. > > Signed-off-by: Stephen Hemminger [snip] \ > diff --git a/drivers/raw/cnxk_bphy/cnxk_bphy.c b/drivers/raw/cnxk_bphy/cn= xk_bphy.c > index 15dbc4c1a637..831f0d001adc 100644 > --- a/drivers/raw/cnxk_bphy/cnxk_bphy.c > +++ b/drivers/raw/cnxk_bphy/cnxk_bphy.c > @@ -251,7 +251,7 @@ cnxk_bphy_irq_enqueue_bufs(struct rte_rawdev *dev, > > /* get rid of last response if any */ > if (qp->rsp) { > - RTE_LOG(WARNING, PMD, "Previous response got overwritten\= n"); > + CNXK_BPHY_LOG(ERR, "Previous response got overwritten"); This level change is unrelated to $SUBJECT. > rte_free(qp->rsp); > } > qp->rsp =3D rsp; --=20 David Marchand