From: David Marchand <david.marchand@redhat.com>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>,
Qiming Yang <qiming.yang@intel.com>,
Wenjun Wu <wenjun1.wu@intel.com>
Cc: dev@dpdk.org, "Morten Brørup" <mb@smartsharesystems.com>
Subject: Re: [Bug 1249] [dpdk-23.07] ixgbe port stop failed after launch testpmd
Date: Tue, 13 Jun 2023 11:50:48 +0200 [thread overview]
Message-ID: <CAJFAV8whdvPQ-TBrfrxdbJ=_7HT9KzRUVrEeLFcf7hVvTbOUVA@mail.gmail.com> (raw)
In-Reply-To: <20230612163242.GB18991@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
Hello,
On Mon, Jun 12, 2023 at 6:32 PM Tyler Retzlaff
<roretzla@linux.microsoft.com> wrote:
> If there has been a broad regression here could I ask for your help in
> either reverting it until I can look at it properly or if you see the
> obvious problem fixing it.
>
> There were multiple instances of flags being converted to bool in the
> series it may be that they all need to be backed out.
I relooked at Tyler series, and I think the net/ixgbe patch is the
only one that has an issue.
It converted:
- rte_atomic32_t link_thread_running;
+ bool link_thread_running;
IIUC, link_thread_running was used as a kind of refcount before Tyler change.
So rather than revert, I suppose the fix is to move to a uint32_t (and
rename the variable maybe).
ixgbe maintainers, please confirm.
--
David Marchand
next prev parent reply other threads:[~2023-06-13 9:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 7:29 bugzilla
2023-06-12 7:43 ` David Marchand
2023-06-12 16:32 ` Tyler Retzlaff
2023-06-13 9:50 ` David Marchand [this message]
2023-06-14 6:57 ` Yang, Qiming
2023-06-14 7:13 ` David Marchand
2023-06-14 7:18 ` Morten Brørup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8whdvPQ-TBrfrxdbJ=_7HT9KzRUVrEeLFcf7hVvTbOUVA@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
--cc=qiming.yang@intel.com \
--cc=roretzla@linux.microsoft.com \
--cc=wenjun1.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).