From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 89D22A04C3; Mon, 28 Sep 2020 12:22:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 16CA11D6F3; Mon, 28 Sep 2020 12:22:52 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 6B5041D6E7 for ; Mon, 28 Sep 2020 12:22:49 +0200 (CEST) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601288567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uIJg0Ata9EcEM4hrMU/D8GC5sr2Qk1Rk9nxiEw1lwTc=; b=RfaV1V/PUeXJZPhu2xyUbGPXQvpsw8lQpGLF6iIZttv4B9x+QaK7zadHShD77yca8Z4zOB D841pNGh+JfDA7EVMbl/6pok5c9E1IUHUj+Fsp+ZuO/4kMvFxlUZfD2DjGPIvwsnzSB0NZ aGv4SFMH29HWwE0jnrah66QmvdCDvrU= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-581-QpRxMgntPymjYZp7qr60QA-1; Mon, 28 Sep 2020 06:22:46 -0400 X-MC-Unique: QpRxMgntPymjYZp7qr60QA-1 Received: by mail-ua1-f71.google.com with SMTP id b13so85639uas.9 for ; Mon, 28 Sep 2020 03:22:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uIJg0Ata9EcEM4hrMU/D8GC5sr2Qk1Rk9nxiEw1lwTc=; b=mg9wO0BMkwCDcYR/vPxWUYoGAvoAucF1PWgNJ6QmyIPzVPHbdcryhr6364avEJvFHs +W0H36axx2r0W/TvH/NApRcKjsR7lcxeGeb549siJqy3zdqsyzcVqAseqbbtruQn5nt8 mBpM93LwOwYFjSeB2PvSfhpeuNTrLKE3B6gTgu9DY1Ptw9r+JXKBdZCCSBQP416xqBqL 0y3YvrvS6dcURRPsSaAouPyceTMDU05Xo8Bb1z8vp31k8gWtnydUt6d5Ac/IBG4ZIp7S 1WFRegNv6zrF2G7DOg1kuwllvpeNFO5gmV9y/+DTyQu6WqwkrE4U6WVn5gxFcaEAMsIz Tw+w== X-Gm-Message-State: AOAM531kPRn+3E6Ss0HNlh2wtbeJFY68VaxJq9JJY5K/DiVsC9UqyTB9 SZHYvcBH60+9fs71WoYig2VsFncyAxlUoH/ifICLGnzGNPrP1UiBwauh4b4IGpCLCAFO9nB2a2c Q8KVJbnKlpQbaV2bIobQ= X-Received: by 2002:ab0:7603:: with SMTP id o3mr192704uap.126.1601288565564; Mon, 28 Sep 2020 03:22:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwf57RoT/DeC0QP25Ksvj5HtKE/L/IdfsnYVpEtVtHqHOZsGG/6V+LqwCgZ/bwndHXodP267OjZY+f0Snd9O+Q= X-Received: by 2002:ab0:7603:: with SMTP id o3mr192695uap.126.1601288565374; Mon, 28 Sep 2020 03:22:45 -0700 (PDT) MIME-Version: 1.0 References: <20200911152938.8019-1-steven.lariau@arm.com> <20200925174340.10014-1-steven.lariau@arm.com> <20200925174340.10014-2-steven.lariau@arm.com> In-Reply-To: <20200925174340.10014-2-steven.lariau@arm.com> From: David Marchand Date: Mon, 28 Sep 2020 12:22:34 +0200 Message-ID: To: Steven Lariau , Gage Eads Cc: Olivier Matz , dev , nd Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 1/5] lib/stack: fix inconsistent weak / strong cas X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Sep 25, 2020 at 7:44 PM Steven Lariau wrote: > > Fix cmpexchange usage of weak / strong. > The generated code is the same on x86 and ARM (there is no weak > cmpexchange), but the old usage was inconsistent. > For push and pop update size, weak is used because cmpexchange is inside > a loop. > For pop update root, strong is used even though cmpexchange is inside a > loop, because there may be a lot of operations to do in a loop iteration > (locate the new head). Is this patch backport material? Thanks. -- David Marchand