From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A212A00BE; Thu, 10 Feb 2022 15:37:26 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 63022426EE; Thu, 10 Feb 2022 15:37:26 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id B2B1E4013F for ; Thu, 10 Feb 2022 15:37:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644503844; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=o89TzR64p9ocsXTE3L0xhD3mQtYUvsmMQWf4Sscod/g=; b=MywCvXtTWKZ6kGA37GZ921DbQtAtiYUWNNKTvwFFKwTHc0TnDVFRCQDZJuFrvNjBSE/y3n Ra9wIc+Ygtu+k+P+61bRw1VnSChHYd9iUFlhF7BbzG3H3rJnuRktvQ5WQ/XzQhAqv9BqOW vB4fkrgzipT6Cyjis1q628TbkHaJ01s= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-464-8nqa676uPzmDmlh87Cj_5A-1; Thu, 10 Feb 2022 09:37:17 -0500 X-MC-Unique: 8nqa676uPzmDmlh87Cj_5A-1 Received: by mail-lj1-f198.google.com with SMTP id i8-20020a2ea228000000b002449296c787so1085630ljm.18 for ; Thu, 10 Feb 2022 06:37:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=o89TzR64p9ocsXTE3L0xhD3mQtYUvsmMQWf4Sscod/g=; b=TV0Y99n8Bj/x+QszM+5JIN8xpJmY4p9/s5TjUQV1PKp2GObwsMkHoR7vXPf1VwlMBc sCTTQz+jLJCnl8SjTV3Cw8/9fCfMH+oy9EXhbqhwVPufnHw3882nBaHoJJnnkwC9owBl cEOJoa0UjZDTeQ2+DAACaCVbVKeWuubNCzSMq+xlXCVivkl3HTAeNpKdkdDBYfP8oIzK ZbMGce/jBXYYaNIOu8bP3/H6KMeIBcaM35EZYdF4u5DwkHod9cugQassi3jKKKyI3P8Y KIv0i1BNimlKdw9BfDWOrP9swCEkoiRtdEYyGzwgp5Fcsupcn7jRBXEKZqmcd6RNVDt0 ukAA== X-Gm-Message-State: AOAM532XxeNzkM8+zyEAWLPHKV/eydx1GN4uJWIQ0gJ6jp/E9RAPJrs/ hLlwiqJ6Pbbb8WbwPgmzhlOsqpr0/ac5Rbuwgd+LhMvxoiBUFySS/Q4YKkpDHy4LGAxEk35grQf rv4Cx4nHc7mqHliN6w/Q= X-Received: by 2002:a05:6512:3f84:: with SMTP id x4mr4181913lfa.484.1644503836144; Thu, 10 Feb 2022 06:37:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJxr21EAG1gcixxr6Z6P0+SSoKLw2brs5Pmj3GPzAEltpkuTMCdjDMWlJkx+l2LkdBKEYLCCeWZ+v/U9gmi+gK4= X-Received: by 2002:a05:6512:3f84:: with SMTP id x4mr4181905lfa.484.1644503835863; Thu, 10 Feb 2022 06:37:15 -0800 (PST) MIME-Version: 1.0 References: <20220204174209.440207-1-bruce.richardson@intel.com> <20220210140355.586399-1-bruce.richardson@intel.com> <20220210140355.586399-8-bruce.richardson@intel.com> In-Reply-To: <20220210140355.586399-8-bruce.richardson@intel.com> From: David Marchand Date: Thu, 10 Feb 2022 15:37:04 +0100 Message-ID: Subject: Re: [PATCH v3 7/7] buildtools/chkincs: test headers for C++ compatibility To: Bruce Richardson Cc: dev , Aaron Conole , Michael Santana , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Feb 10, 2022 at 3:05 PM Bruce Richardson wrote: > > Add support for checking each of our headers for issues when included in > a C++ file. > > Signed-off-by: Bruce Richardson > --- > .ci/linux-build.sh | 1 + > buildtools/chkincs/main.cpp | 4 ++++ > buildtools/chkincs/meson.build | 20 ++++++++++++++++++++ > 3 files changed, 25 insertions(+) > create mode 100644 buildtools/chkincs/main.cpp > > diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh > index c10c1a8ab5..67d68535e0 100755 > --- a/.ci/linux-build.sh > +++ b/.ci/linux-build.sh > @@ -74,6 +74,7 @@ fi > > if [ "$BUILD_32BIT" = "true" ]; then > OPTS="$OPTS -Dc_args=-m32 -Dc_link_args=-m32" > + OPTS="$OPTS -Dcpp_args=-m32 -Dcpp_link_args=-m32" > export PKG_CONFIG_LIBDIR="/usr/lib32/pkgconfig" > fi > Even though check_includes=true is not forced for 32bits in test-meson-builds.sh, I sometimes enable more checks for some targets. Can this change be applied to test-meson-builds.sh too? https://git.dpdk.org/dpdk/tree/devtools/test-meson-builds.sh#n249 -- David Marchand