From: David Marchand <david.marchand@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>, joshwash@google.com
Cc: dev@dpdk.org, Chengwen Feng <fengchengwen@huawei.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Potnuri Bharat Teja <bharat@chelsio.com>,
Jie Hai <haijie1@huawei.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Chenbo Xia <chenbox@nvidia.com>, Gaetan Rivet <grive@u256.net>
Subject: Re: [PATCH] pci: define more standard register offsets
Date: Wed, 16 Apr 2025 17:31:18 +0200 [thread overview]
Message-ID: <CAJFAV8wiK6qwdX6nVkd2Urf670VnQ1DDHteiUGxaaKE3CPK1mw@mail.gmail.com> (raw)
In-Reply-To: <20250416073716.0a4e3b4a@hermes.local>
On Wed, Apr 16, 2025 at 4:37 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Wed, 16 Apr 2025 08:10:34 +0200
> David Marchand <david.marchand@redhat.com> wrote:
>
> > The PCI standard defines registers for:
> > - subsystem id,
> > - revision id,
> > - status of the device,
> > - vital product data,
> >
> > Add them to rte_pci.h and use in existing drivers.
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
>
> Makes sense and aligns with <linux/pci_regs.h>
>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Thanks for the review and merging it.
@Joshua Washington
The gve patch https://patchwork.dpdk.org/project/dpdk/patch/20250416024421.722135-1-joshwash@google.com/
should now use RTE_PCI_REVISION_ID.
--
David Marchand
next prev parent reply other threads:[~2025-04-16 15:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 6:10 David Marchand
2025-04-16 14:37 ` Stephen Hemminger
2025-04-16 15:31 ` David Marchand [this message]
2025-04-18 2:13 ` Joshua Washington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8wiK6qwdX6nVkd2Urf670VnQ1DDHteiUGxaaKE3CPK1mw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=ajit.khaparde@broadcom.com \
--cc=bharat@chelsio.com \
--cc=chenbox@nvidia.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=grive@u256.net \
--cc=haijie1@huawei.com \
--cc=jingjing.wu@intel.com \
--cc=joshwash@google.com \
--cc=somnath.kotur@broadcom.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).